i m getting an error "Input string was not in a correct format.". i am not able to figure out y ?

Question

0.00/5 (No votes)

See more:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Data;

public partial class Default2 : System.Web.UI.Page
{
    SqlConnection con = new SqlConnection();

    protected void Page_Load(object sender, EventArgs e)
    {
        con.ConnectionString = "server=a2ul-pc;uid=sa;pwd=rascal;database=cgrt";
    }
    protected void Button1_Click(object sender, EventArgs e)
    {
        SqlCommand cmd = new SqlCommand();
        cmd.CommandText = "insert into yearly (pcode,fyyear,yearlyalloc,salary,ta,contigency,nrc,institcharges,others) values (@pcode,@fyyear,@yearlyalloc,@salary,@ta,@contigency,@nrc,@institcharges,@others)";
        cmd.Parameters.AddWithValue("@pcode", DropDownList1.SelectedItem.ToString());
        cmd.Parameters.AddWithValue("@fyyear", TextBox10.Text +"-"+ TextBox2.Text);
        cmd.Parameters.AddWithValue("@yearlyalloc", Convert.ToInt32(TextBox3.Text));
        cmd.Parameters.AddWithValue("@salary", Convert.ToInt32(TextBox4.Text));
        cmd.Parameters.AddWithValue("@ta", Convert.ToInt32(TextBox5.Text));
        cmd.Parameters.AddWithValue("@contigency", Convert.ToInt32(TextBox6.Text));
        cmd.Parameters.AddWithValue("@nrc", Convert.ToInt32(TextBox7.Text));
        cmd.Parameters.AddWithValue("@institcharges", Convert.ToInt32(TextBox8.Text));
        cmd.Parameters.AddWithValue("@others",Convert.ToInt32(TextBox9.Text));

        cmd.Connection = con;
        con.Open();
        cmd.ExecuteNonQuery();
        cmd.Dispose();
        con.Close();

        DropDownList1.SelectedIndex = 0;
        TextBox2.Text = "";
        TextBox3.Text = "";
        TextBox4.Text = "";
        TextBox5.Text = "";
        TextBox6.Text = "";
        TextBox7.Text = "";
        TextBox8.Text = "";
        TextBox9.Text = "";

        Response.Write("<script type=\"text/javascript\">alert('Done!');</script>");
    }
}

[edit]Code block added - OriginalGriff[/edit]

Posted 28-Oct-12 23:26pm

a2ulthakur

Updated 28-Oct-12 23:33pm

OriginalGriff

v2

Add a Solution

3 solutions

Solution 1

Check that the columns of the table are compatible with the given data types. Also take a look for the lenght of strings and Int32 to smallint columns.

Posted 28-Oct-12 23:33pm

BlackMilan

Comments

a2ulthakur 29-Oct-12 5:41am

i checked the data type and its all ok :
USE [CGRT]
GO
/****** Object: Table [dbo].[yearly] Script Date: 10/29/2012 15:08:38 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
SET ANSI_PADDING ON
GO
CREATE TABLE [dbo].[yearly](
[pcode] [varchar](50) NOT NULL,
[fyyear] [varchar](50) NOT NULL,
[yearlyalloc] [int] NOT NULL,
[salary] [int] NULL,
[ta] [int] NULL,
[contigency] [int] NULL,
[nrc] [int] NULL,
[institcharges] [int] NULL,
[others] [int] NULL,
[misc1] [varchar](50) NULL,
[misc2] [varchar](50) NULL,
[misc3] [varchar](50) NULL
) ON [PRIMARY]

this is my table script ? still after checking so many times i dont know whats wrong ?

BlackMilan 29-Oct-12 5:47am

TextBox3.Text may be empty and yearlyalloc do not allow NULL value

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Street Racers · Accepted Answer · 2012-10-28T23:37:00

usually this will happen because of "empty string converstion to int".

eg: Convert.ToInt32(TextBox.Text)); //here 'TextBox.Text' is empty.

Please make sure that all the "TextBox.Text" value is "not empty" before the Int32 conversion or use "int.TryParse".

Sample:

C#

int test1223 = -1;
         TextBox1.Text="2";
         int.TryParse(TextBox1.Text, out test1223); // 'test1223' value is "2"

         TextBox1.Text="";
         int.TryParse(TextBox1.Text, out test1223); //'test1223' value is "0"

Please refer the following link for more details about "int.TryParse" method.

http://msdn.microsoft.com/en-us/library/f02979c7.aspx[^]

OriginalGriff · Accepted Answer · 2012-10-28T23:38:00

It's pretty simple: the Convert.ToInt32 function is failing for one of your parameters because the TextBox value is not an integer - it may contain nothing, or an alphabetic character or similar.

I would strongly suggest that you convert these all to int values as the first part of the event handler using teh int.TryParse method, and report problems to your user so they know what to correct. Only when the values are good should you try to pass them to SQL.

Well done BTW on using parametrised queries! :thumbsup:

i m getting an error "Input string was not in a correct format.". i am not able to figure out y ?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0