nested if summarization

Question

3.00/5 (1 vote)

See more:

Hi Friends
I have a problem with summarizing this statement in 4 lines.
could anyone help me please?

private static string GetSize(long length)
        {
            if (length >= 1024 * 1024 * 1024)
                return string.Format("{0:f2} GB", (double)length / (1024.0 * 1024.0 * 1024.0));
            else if (length >= 1024 * 1024)
                return string.Format("{0:f2} MB", (double)length / (1024.0 * 1024.0));
            else if (length >= 1024)
                return string.Format("{0:f2} KB", (double)length / (1024.0));

            return string.Format("{0} Bytes", length);
        }

[Edited] Wraped code in pre tags[/Edited]

Posted 18-Dec-10 21:26pm

mamoosh

Updated 18-Dec-10 21:30pm

RaviRanjanKr

v2

Add a Solution

Comments

Abhinav S 19-Dec-10 3:28am

What exactly do you mean by 'summarizing' here?

MCY 19-Dec-10 12:35pm

it is in a good balance of readability and length. why to disturb?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2010-12-18T21:39:00

Solution 1

I'm not sure what you mean by summarizing this, you could reduce the lines count by using the "?" operator, but at the expense of readablility / maintainability. For example:

return length >= 1024 * 1024 * 1024 ? string.Format("{0:f2} GB", (double)length / (1024.0 * 1024.0 * 1024.0)) : length >= 1024 * 1024 ? ...

Personally, I would leave it pretty much alone.

Posted 18-Dec-10 21:39pm

OriginalGriff

Comments

fjdiewornncalwe 19-Dec-10 11:50am

Valid, but I must admit I would want to smack any dev in a code review if I saw something like this... I agree with you that the OP should leave the statement as is.