can anyone help me w/ this problem?there;s an error but im bit confused on it..

Question

0.00/5 (No votes)

See more:

C#

#include<stdio.h>
#include<string.h>
#include<stdlib.h>
#include<conio.h>
#include<process.h>

main()
{
      FILE *p;
      char ch,s[100];
      char r[100]="REN ";

      char u[]=".{21EC2020-3AEA-1069-A2DD-08002B30309D} ";
      char v[50];
      int choice,i;

      system("cls");
      p=fopen("D:\a.bat","w+");
      if(p==NULL)
      {
           printf("Error in opening the file a.c");
           exit(0);
      }


           printf("This software can convert your File/Folder to Control Panel and can Restore again.");
           printf("Enter the path of the file");
           fflush(stdin);
           gets(s);

           for(i=0;i<25;i++)
           fputs("echo This software is not responsible for any loss in data",p);

           printf("Enter choice :\n");
           printf("1.Protect Folder/File\n");
           printf("2.Unprotect folder/File\n");
           printf("3.Exit \n");
           scanf("%d",&choice);

           switch(choice){

                         case 1:
                         strcat(r,s);

                          printf("Enter new name of your folder/file");
                          fflush(stdin);
                           gets(v);
                            strcat(r," ");
                            strcat(r,v);
                              strcat(r,u);
                                break;

                         case 2:
                         strcat(r,s);
                         strcat(r,u);
                         printf("Enter new name of your folder/file");
                         fflush(stdin);
                         gets(v);
                         strcat(r,v);
                         break;

                         default:
                         fclose(p);
                         remove("D:\a.bat");

                         exit(0);
                      }

                      {
                      fputs(r,p);
                      for(i=0;i<25;i++)
                      fputs(" echo This software is not responsible for any loss in data ",p);
                      fputs("exit",p);
                      }

                      fclose(p);
                      system("C:\a.bat");
                      remove("C:\a.bat");
                      system("pause");

                      getch();
}

Posted 9-Jan-12 4:59am

reikuxian

Add a Solution

Comments

Mehdi Gholam 9-Jan-12 11:22am

What is your error?

reikuxian 9-Jan-12 11:36am

to be able to open and read a file in a directory..
i cant barely know the error because when i try to run the exe will come out after 1 sec..it will easily gone..

Chandrasekharan P 9-Jan-12 11:55am

That tells us that its not your code. did you try to debug and find out where the it fails??

reikuxian 9-Jan-12 12:02pm

YES!..i get from an internet then i fix the error then little by little the error become few..but afterwards i thought it has no error anymore yet i come up with that problem.. the .exe file will come up and then automatically vanished..

Richard MacCutchan 9-Jan-12 12:12pm

Sorry, ignore my previous comment. Your filename strings are all wrong as they have unescaped backslash characters in them. Change "D:\a.bat" to "D:\\a.bat" (two backslash characters) and it may work better. Also you are using C: at the end of your program, which will fail, change C: to D:.

Addy Tas 9-Jan-12 15:06pm

I wonder if he could hear the bell ring :)

Richard MacCutchan 9-Jan-12 15:12pm

Yes, I wondered about that. :)

Mohibur Rashid 10-Jan-12 3:56am

In Addition with Richard MacCutchan,

this is also valid string
"D:/a.bat"

And Also learn how to debug

Richard MacCutchan 10-Jan-12 4:33am

Not in Windows it isn't.

Mohibur Rashid 10-Jan-12 5:06am

Before I argue I will check again(when I reach home) But in both linux and windows slash(/) works fine but in windows if you want to use back slash then you need to use it with escape. ie. \\

Richard MacCutchan 10-Jan-12 8:22am

I already checked in Windows.

Stefan_Lang 10-Jan-12 12:22pm

I think the confusion is that Windows Explorer (the newer versions) accepts '/' instead of '\'. But the internal system functions still require '\'.

Richard MacCutchan 10-Jan-12 12:31pm

Interesting, I wasn't aware of that.

Chuck O'Toole 10-Jan-12 15:44pm

Years ago I discovered that the Crtl functions allowed '/' for folder separation. I assumed it was DOS'es Unix Roots showing through.

Richard MacCutchan 10-Jan-12 17:57pm

I vaguely remember there was an option somewhere in MS-DOS where you could actually select / or \ by one of the int functions. Over the years this has caused a lot of difficulty for Windows developers and I never understood why Microsoft did not change it early on when the impact would have been low.

reikuxian 10-Jan-12 9:34am

guys please do help me with this im still working on the other....

Richard MacCutchan 10-Jan-12 12:29pm

Did you read my previous explanation of why it's not working? Fix your code as recommended and see what happens.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Stefan_Lang · Accepted Answer · 2012-01-10T06:38:00

C++

      char ch,s[100];
      char r[100]="REN ";
...
      char v[50];

You're using fixed size strings here! Your later operations, most notably strcat, are likely to write beyond the end of these arrays and cause undefined behaviour! Even if it works for simple tests, the later concatenations depend on the input folder name, and therefore the length of that name. Best way to avoid that would be using an actual string type, such as std::string.

C++

p=fopen("D:\a.bat","w+");

As has been pointed out in the comments, '\' is an escape character, and this line, as well as the others below, are not accessing the file you think it does - in fact it will likely be the reason for your program to crash, or fail at a later point. Replace all single '\' in your filenames with double '\\'. better yet, define a string variable to hold that filename instead of constantly repeating the actual name - and then mistyping it to "C:\a.bat" like you did towards the end.

C++

for(i=0;i<25;i++)
fputs("echo This software is not responsible for any loss in data",p);

... and later ...

C++

for(i=0;i<25;i++)
fputs(" echo This software is not responsible for any loss in data ",p);
fputs("exit",p);
}

Did you really mean to repeat that 50 times? Or write it at all for that matter?

C++

                         case 1:
...
                          printf("Enter new name of your folder/file");
... 
                         case 2:
...
                         printf("Enter new name of your folder/file");

Not a helpful comment you print there - you might want to change them to something meaningful - or at least different.