Calling A Function From A Header

Question

1.00/5 (1 vote)

See more:

I have this code in a header file that I included in my cpp file and I am trying to call this function which returns the url of the current webpage. The function works fime when I run it from the header file, now how do I get it to run from the cpp file? The function is...PrintBrowserInfo()

The code...

C++

#include "stdafx.h"
#include <stdio.h>
#include <wchar.h>
#include <windows.h>
#include <exdisp.h>
#include <string>

#pragma warning(disable: 4192)
#pragma warning(disable: 4146)
#import <mshtml.tlb>
#import <shdocvw.dll>
//using namespace std;
 
void PrintBrowserInfo(IWebBrowser2 *pBrowser) {
	BSTR bstr;
 	IDispatchPtr spDisp;
	if (pBrowser->get_Document(&spDisp) == S_OK && spDisp != NULL) {
		MSHTML::IHTMLDocument2Ptr spHtmlDocument(spDisp);
		if (spHtmlDocument != NULL) {
			MSHTML::IHTMLElementPtr spHtmlElement;
			spHtmlDocument->get_body(&spHtmlElement);
		}
		spDisp.Release();
	}
	pBrowser->get_LocationURL(&bstr);
	wprintf(L"  URL: %s\n\n", bstr);
	/////////////////////////////////
	std::wstring wsURL;
	wsURL = bstr;
 	size_t DSlashLoc = wsURL.find(L"//www.");
 	if (DSlashLoc >= 0)
	{
		wsURL.erase(wsURL.begin(), wsURL.begin() + DSlashLoc + 6);
	}
		DSlashLoc = wsURL.find(L"/");
			if (DSlashLoc != wsURL.npos)
                 wsURL.erase(DSlashLoc);
 	wprintf(L"  URL: %s\n\n", wsURL.c_str());
	///////////////////////////////////
	SysFreeString(bstr);
}
 
int urlmain() {
	CoInitialize(NULL);
	SHDocVw::IShellWindowsPtr spSHWinds;
	IDispatchPtr spDisp;
	if (spSHWinds.CreateInstance(__uuidof(SHDocVw::ShellWindows)) == S_OK) {
		long nCount = spSHWinds->GetCount();
		for (long i = 0; i < nCount; i++) {
			_variant_t va(i, VT_I4);
			spDisp = spSHWinds->Item(va);
			SHDocVw::IWebBrowser2Ptr spBrowser(spDisp);
			if (spBrowser != NULL) {
				PrintBrowserInfo((IWebBrowser2 *)spBrowser.GetInterfacePtr());
				spBrowser.Release();
			}
		}
	} else {
		puts("Shell windows failed to initialise");
	}
	system("PAUSE");
	return 0;
}

Posted 7-Nov-11 14:01pm

Member 7766180

Updated 7-Nov-11 15:17pm

Philippe Mori

v4

Add a Solution

Comments

Member 7766180 7-Nov-11 20:21pm

I dropped this in and I am getting these errors.

printf("\n Source IP: %s", ipSrc);
myfile << "\n Source IP:" << ipSrc;
PrintBrowserInfo(IWebBrowser2 *pBrowser);

2 IntelliSense: identifier "pBrowser" is undefined
1 IntelliSense: type name is not allowed

Philippe Mori 7-Nov-11 20:27pm

IntelliSense message are not always errors. Sometime IntelliSense is not smart enough or not yet up-to-date. Try to build the application anyway.

Member 7766180 7-Nov-11 20:51pm

Tried to several times. Won't run.

Error 2 error C2065: 'pBrowser' : undeclared identifier

Error 3 error C2275: 'IWebBrowser2' : illegal use of this type as an expression

Chuck O'Toole 7-Nov-11 21:13pm

OK, so you moved the function from a header file to the CPP file. What did you do about including the header file? Were there other things in the header file that were important but you forgot to move, like the definition of "IWebBrowser2" or some nested include?

Member 7766180 7-Nov-11 21:19pm

No, I have the header file in the includes of the cpp file.

Chuck O'Toole 7-Nov-11 21:24pm

What I mean is, "PrintBrowserInfo()" used to be in a header file (your words imply this) and it worked. Now it's in the CPP file (your posted code). So, what else was in that previous header file? Did you copy *everything*? Are you "including" it in this code (I don't see anything but system includes so my guess is no)? Anyway, if it compiled when it was in a header file but now it doesn't, you missed copying something. If I'm wrong about what your exact problem is now, then ignore this message.

Philippe Mori 7-Nov-11 21:25pm

Check all includes you have in your original CPP file that are before the included file above. Does the new cpp file include exdisp.h as the problem is clearly the definition of IWebBrowser2 not visible from that source file.

Member 7766180 7-Nov-11 22:09pm

OK. I moved this into the spot of the cpp file...
CoInitialize(NULL);
SHDocVw::IShellWindowsPtr spSHWinds;
IDispatchPtr spDisp;
if (spSHWinds.CreateInstance(__uuidof(SHDocVw::ShellWindows)) == S_OK)
{//if one open
long nCount = spSHWinds->GetCount();
for (long i = 0; i < nCount; i++)
{//for open
_variant_t va(i, VT_I4);
spDisp = spSHWinds->Item(va);
SHDocVw::IWebBrowser2Ptr spBrowser(spDisp);
if (spBrowser != NULL)
{//if open
PrintBrowserInfo((IWebBrowser2 *)spBrowser.GetInterfacePtr());
spBrowser.Release();
}//if close
}//for close
}//if one close
else
{//else open
puts("Shell windows failed to initialise");
}//else close
return 0;

Then I put the entire PrintBrowserInfo() at the end of the cpp file.
I put all of the includes and such with the others in the cpp file.
Now when I run it I get this error...

Error 1 error C3861: 'PrintBrowserInfo': identifier not found

Philippe Mori 8-Nov-11 8:00am

In C++, identifiers must be declared before they are used. So either put the prototype of PrintBrowserInfo at the top of the file or put the functions in the original order.

Member 7766180 8-Nov-11 12:10pm

Got Thank you.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Chuck O'Toole · Accepted Answer · 2011-11-07T15:10:00

OK, this is going to sound strange but there's nothing "special" about header files. All they really are are text files compiled in place. Think of them as if you just "pasted" the content of the header file right where the #include statement is.

The reason to create a header file is to allow multiple source files to share the same definitions and declarations without "pasting" the same stuff over and over or having the same thing in multiple files and then trying to keep them up to date when you want to change something.

So, knowing that, there's no special "output of the header file" that is part of the executable, anything in the header is included in the object file of the CPP file.

Common conventions say not to put "code" into header files but to put only declarations and definitions there, leaving the code to be in the cpp modules. This is to prevent you bulking up your executable with multiple copies of routines. In reality, you will either get linker errors or the linker will be smart enough to collapse the multiple entries, depending on what the function is. And, in reality, Microsoft sticks code in their header files all the time.

So, you don't "execute something in the header", it's in the CPP file's object file. However, if it makes you feel more comfortable to have it in the CPP file, just copy / cut it from the header and paste it into the CPP file.

(now there is such a thing as a precompiled header file but all that is is just a way of making the compilation go faster by avoiding the parsing of the header file over and over for different CPP modules but we can avoid that quirk until another day, it's not really relevant to this discussion).

And since your original question says you got it to run, I'm only addressing your questions about getting it to "run from the CPP file"