data is not comming from the DataBase

Question

0.00/5 (No votes)

See more:

Hi,

I'm Trying to get data from a Database.

I wrote the stored Procedure for Selecting the values from the table as

ALTER Procedure [dbo].[Select_Students](@Sno int)
As
Begin
If @Sno Is Null
Select Sno,Sname,Class,Fees From Stu 
Else
Select Sname,Class,Fees From Stu Where Sno=@Sno
End

and code for the Get button as

private void button1_Click(object sender, EventArgs e)
        {
            cmd.Parameters.Clear();
            ds = new DataSet();
            da = new SqlDataAdapter();
            cmd.CommandText = "Select_Students";
            da.Fill(ds, "Stu");
            
            if (ds.Tables[0].Rows.Count > 0)
            {
                textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
                textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
                textBox4.Text = ds.Tables[0].Rows[0][3].ToString();
            }
            else
                MessageBox.Show("Record Not Existed");
        }

But the data is not coming from the database.

Can any one tell me the problem in this code.

Thank you so much

Posted 16-Aug-11 21:03pm

usha nelavalli

Updated 16-Aug-11 21:33pm

Dalek Dave

v3

Add a Solution

Comments

nagendrathecoder 17-Aug-11 3:08am

Have to tried to execute procedure in database?
Try to execute it and check whether its showing data or not.

vivek_cool 17-Aug-11 3:09am

use google

nagendrathecoder 17-Aug-11 3:13am

You have replied to me. :D

vivek_cool 17-Aug-11 3:14am

yes

nagendrathecoder 17-Aug-11 3:15am

i guess you wanted to tell this to OP right.

vivek_cool 17-Aug-11 3:16am

no i want to tell u that answer can be any formated its not need format its required that answer can be any it should give some hint or solution k

nagendrathecoder 17-Aug-11 3:20am

Answer should be formatted so that it would be easy for OP to understand the code.
Anyways, lets stop it here only.

vivek_cool 17-Aug-11 3:23am

k thanks for your suggestion but why you need to downvoted the answer

usha nelavalli 17-Aug-11 3:34am

Any thing wrong is in the below code:

if (ds.Tables[0].Rows.Count > 0)
{
textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
textBox4.Text = ds.Tables[0].Rows[0][3].ToString();

it always displays the top record values only not related values of the sno value passed by us

nagendrathecoder 17-Aug-11 3:39am

You need to pass parameter to the SqlCommand object.
I guess your stored procedure is executing the query without where condition.
And in the code you are fetching row[0], so its always showing top row from datatable.
Pass parameter to stored procedure again after you are clearing parameters.

usha nelavalli 17-Aug-11 4:26am

Can you help me to know how to write the code to get data from database.I don't How to
Pass parameter to stored procedure again after you are clearing parameters.

nagendrathecoder 17-Aug-11 4:34am

Just add this line
cmd.Parameters.Add("@sno", value_of_sno);

usha nelavalli 17-Aug-11 5:40am

where i need to add this line in my Code.

private void button1_Click(object sender, EventArgs e)
{
cmd.Parameters.Clear();
ds = new DataSet();
da = new SqlDataAdapter();
cmd.CommandText = "Select_Students";
da = new SqlDataAdapter(cmd);
da.Fill(ds, "Stu");
string value_of_sno = textBox1.Text;
cmd.Parameters.Add("@sno", value_of_sno);

if (ds.Tables[0].Rows.Count > 0)
{
textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
textBox4.Text = ds.Tables[0].Rows[0][3].ToString();
}
else
MessageBox.Show("Record Not Existed");
}

nagendrathecoder 17-Aug-11 8:00am

Add that line after cmd.CommandText = "Select_Students"

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Toniyo Jackson · Answer 1 · 2011-08-16T21:20:00

Solution 4

Check this link.

http://sharpertutorials.com/calling-sql-server-stored-procedures/[^]

Posted 16-Aug-11 21:20pm

Toniyo Jackson

usha nelavalli · Answer 2 · 2011-08-16T21:23:00

Solution 5

I added your code

C#

ds = new DataSet();
da = new DataAdapter(cmd);
da.Fill(ds, "Stu");

and I executed my stored procedure in database there it get executed nicely.
after adding your code it displays the top record values for all.

Posted 16-Aug-11 21:23pm

usha nelavalli

Updated 16-Aug-11 22:26pm

v2

Comments

nagendrathecoder 17-Aug-11 3:30am

it will display the records of the "sno" you have passed to stored procedure.
So i guess you are getting correct result.
Do you want anything else too?

nagendrathecoder 17-Aug-11 3:32am

You can comment on my answer, you don't need to add new answer for that.

senthil sennu · Answer 3 · 2011-08-16T21:09:00

Solution 1

You want to assign the command object to sqlDataAdapter

C#

da = new SqlDataAdapter(cmd);

Hope this helps!

Posted 16-Aug-11 21:09pm

senthil sennu

Comments

nagendrathecoder 17-Aug-11 3:14am

She is clearing parameters and later not passing any parameter.

nagendrathecoder · Answer 4 · 2011-08-16T21:11:00

Solution 2

Code is not correct.
Where are you passing the parameter to stored procedure.
Try using this code:

//After creating SqlCommand object and adding parameters to it
ds = new DataSet();
da = new DataAdapter(cmd);
da.Fill(ds, "Stu");

Posted 16-Aug-11 21:11pm

nagendrathecoder