Error while saving data from page to XML file

Question

1.00/5 (2 votes)

See more:

I have 2 accounts one is confirm and other one is unconfirm. whe user click on reportComparison button, it shows data of both accounts. if user think data is wrong he can change it from available dropdowns,dropdown is also on the same page. and then he can add remarks to it in given text area. there is one bureau id which is automatically selected. no the problem is when user click on report buton to save data of accounts in xml file it throws object reference error,although I have add conditional checks.if value is null for anayaccout then replace it with 0.

What I have tried:

C#

[HttpPost]
public ActionResult SaveReport(int BureauID, string Note, int? Incorrect_CustomerAccountId, int? Incorrect_C_CustomerAccountId, int? Correct_CustomerAccountId, int? Correct_C_CustomerAccountId)
{
	try
	{
		var report = new Report
		{
			BureauID = BureauID,
			Note = Note,
		};

		report.InCorrectMapping.CustomerAccount = Incorrect_CustomerAccountId.HasValue
			? new VM_CustomerAccount().FindDetailsById(Incorrect_CustomerAccountId.Value)
			: null;

		report.InCorrectMapping.CCustomerAccount = Incorrect_C_CustomerAccountId.HasValue
			? new VM_CustomerAccount().FindDetailsById(Incorrect_C_CustomerAccountId.Value)
			: null;

		report.CorrectMapping.CustomerAccount = Correct_CustomerAccountId.HasValue
			? new VM_CustomerAccount().FindDetailsById(Correct_CustomerAccountId.Value)
			: null;

		report.CorrectMapping.CCustomerAccount = Correct_C_CustomerAccountId.HasValue
			? new VM_CustomerAccount().FindDetailsById(Correct_C_CustomerAccountId.Value)
			: null;


		var serializer = new XmlSerializer(typeof(Report));
		using (var writer = new StreamWriter(Server.MapPath("~/XML/Report.xml")))
		{
			serializer.Serialize(writer, report);
		}

		return Content("XML data saved successfully!", "text/plain");
	}
	catch (Exception ex)
	{
		return Content("Error: " + ex.Message, "text/plain");
	}
}

$("#report").click(function () {
            var bureauid = bureauID;
            var note = $("#note").val();

            var Incorrect_CustomerAccountId = @Model.CustomerAccountId ?? 0;
            var Incorrect_C_CustomerAccountId = @Model.C_CustomerAccountId ?? 0;

            var Correct_CustomerAccountId = @Model.CustomerAccountId ?? 0;
            var Correct_C_CustomerAccountId = @Model.C_CustomerAccountId ?? 0;


            @*var selectElement = $("select[name='" + @Model.CustomerAccountId + "']");
            var Correct_CustomerAccountId = selectElement.val();

            var C_selectElement = $("select[name='" + @Model.C_CustomerAccountId + "']");
           var Correct_C_CustomerAccountId = C_selectElement.val();*@

            var requestData = {
                BureauID: bureauid,
                Note: note,
                Correct_C_CustomerAccountId: Correct_C_CustomerAccountId,
                Correct_CustomerAccountId: Correct_CustomerAccountId,
                Incorrect_C_CustomerAccountId: Incorrect_C_CustomerAccountId,
                Incorrect_CustomerAccountId: Incorrect_CustomerAccountId
            };

            console.log(requestData);

            $.ajax({
                type: "POST",
                url: "/Enterprise/AutoDispute/SaveReport",
                data: JSON.stringify(requestData),
                contentType: "application/json; charset=utf-8",
                success: function (data) {
                    alert("Saved Successfully");
                    console.log(data);

                },
                error: function () {
                    alert("Error.");
                }
            });
        });

error

BureauID: 2Correct_C_CustomerAccountId: "DPT ED/NAVI - 98207235891E0072****"Correct_CustomerAccountId: undefinedIncorrect_C_CustomerAccountId: 0Incorrect_CustomerAccountId: 54780Note: "bvj"

Error: Object reference not set to an instance of an object.

you can ignore this

var Correct_CustomerAccountId = @Model.CustomerAccountId ?? 0;
            var Correct_C_CustomerAccountId = @Model.C_CustomerAccountId ?? 0;

Posted 9-Oct-23 2:17am

codiagirl

Updated 9-Oct-23 2:26am

v3

Add a Solution

Comments

Graeme_Grant 9-Oct-23 8:23am

You are using nullable parameters but you're not checking if any are null.

Which line is throwing the error? You also need to post the full error details. Use the "Improve question" link to add the extra details.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graeme_Grant · Answer 1 · 2023-10-09T02:52:00

Solution 1

Still unsure which line is throwing the error... The full error message with stack trace would identify where the error occurred.

Have you set a breakpoint and check the line with the error?

At a guess, report.InCorrectMapping &/or report.CorrectMapping are not initialised before being assigned a value.

Posted 9-Oct-23 2:52am

Graeme_Grant

Updated 9-Oct-23 2:56am

v2

Comments

codiagirl 9-Oct-23 11:08am

they are initialised
[Serializable]
[XmlRoot(ElementName = "Report")]
public class Report
{
public Report()
{
//CorrectMapping = new CorrectMapping();
InCorrectMapping = new InCorrectMapping();
}
[XmlElement(ElementName = "BureauID")]
public int BureauID { get; set; }

[XmlElement(ElementName = "Note")]
public object Note { get; set; }

//[XmlElement(ElementName = "CorrectMapping")]
//public CorrectMapping CorrectMapping { get; set; }

[XmlElement(ElementName = "InCorrectMapping")]
public InCorrectMapping InCorrectMapping { get; set; }

}

Graeme_Grant 9-Oct-23 18:27pm

For a third time, still unsure which line is throwing the error... We can't run your code nor see your screen, so if you don't share, we can not help you. Use the "Improve question" link to add the extra details.

codiagirl 10-Oct-23 16:10pm

Thank you, I have resolved the issue.

OriginalGriff · Answer 2 · 2023-10-09T02:58:00

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

C#

private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!