Why my output is not coming as predicted

Question

1.00/5 (1 vote)

See more:

`\#include \<bits/stdc++.h\>
using namespace std;
int main(){
int N;
cin \>\> N;
int sum = 0;

vector\<int\> a(N);

int A, B;
cin \>\> A \>\> B;

for (int i = 0; i \< N; i++) {
a\[i\] = i + 1;
int num = a\[i\];
int digitsum = 0;

     if((a[i] >= A) && (a[i] <= B)) {
        sum = sum + a[i];
    } else if (a[i] > 0) {
        while (a[i] > 0) {
            digitsum += a[i] % 10;
            a[i] = a[i] / 10;
        }
        if (digitsum >= A && digitsum <= B) {
            sum = sum + num;
        }
    }

}

cout \<\< sum \<\< endl;
}

`

What I have tried:

for eg N=100 A=4 B=16
outpt should be 4554 but coming 4587

Posted 25-Jul-23 22:35pm

awesome priyanshu

Updated 25-Jul-23 23:48pm

Add a Solution

Comments

Member 15627495 26-Jul-23 4:49am

add few 'cout' , in the aim of reading the values in your var.

it's a part of debuging "vars tracing".

organize few test with different values for A and B.

Richard MacCutchan 26-Jul-23 5:01am

What are the rules for converting the input numbers to the output answer?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2023-07-25T23:13:00

Assuming I understand what the code is supposed to do, I would start by simplify the code:

C++

<pre>`\#include \<bits/stdc++.h\>
using namespace std;
int main(){
int N;
cin \>\> N;
int sum = 0;

vector\<int\> a(N);

int A, B;
cin \>\> A \>\> B;

for (int i = 0; i \< N; i++) {
a\[i\] = i + 1;
int num = a\[i\];
int digitsum = 0;

     if((a[i] >= A) && (a[i] <= B)) {
        sum = sum + a[i];
    } else if (a[i] > 0) {
        while (a[i] > 0) {
            digitsum += a[i] % 10;
            a[i] = a[i] / 10;
        }
        if (digitsum >= A && digitsum <= B) {
            sum = sum + num;
        }
    }

}

cout \<\< sum \<\< endl;
}

`

12 is not the sum of its digits.

CPallini · Answer 2 · 2023-07-25T23:47:00

Based on Patrice solution, I would simplify further:

C++

#include <iostream>
  
using namespace std;
int main()
{
  int N;
  int A, B;
  cin >> N;
  cin >> A >> B;

  int sum = 0;
  for (int i = 1; i <= N; ++i)
  {

    int num = i, digitsum = 0;
    while (num > 0)
    {
        digitsum += num % 10;
        num /= 10;
    }
    if (digitsum >= A && digitsum <= B)
    {
        sum += i;
    }
  }
  cout << sum << endl;
}

Why my output is not coming as predicted

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0