I was making a simple stone paper scissor game and the if else is not exexuting

Question

1.00/5 (1 vote)

See more:

if and else not executing.....

What I have tried:

Java

package practice;
import java.util.Scanner;

public class pract4 {

	public static void main(String[] args) {
	
	Scanner sc = new Scanner (System.in);


     System.out.println("enter rock,paper,scissor");
	 String user1 = sc.nextLine();	 
	 System.out.println("enter rock,paper,scissor");
	 String user2 = sc.nextLine();	
	 
	 
	 
	 if ( user1 ==("rock") && user2 ==("paper"))	{
	 
		 System.out.println("user1 wins!");
	 }
	
	  
	 else if (user1==("rock")&& user2==("scissor"))
	 {
		 System.out.println("user1 wins!");
	 }
		
	 else if (user1==("paper") && user2==("rock"))
	 {
		 System.out.println("user1 wins!");
	 }
	 
	 else if (user1==("paper") && user2==("scissor"))
	 {
		 System.out.println("user2 wins!");
	 }
		
	 else if (user1==("scissor") && user2==("rock"))
	 {
		 System.out.println("user2 wins!");
	 }
		
	 else if (user1==("scissor") && user2==("paper"))
	 {
		 System.out.println("user1 wins!");
	 }
		
	 else
	 {
		 System.out.println(user1==user2);
	 }
		
   }
}<pre>

Posted 3-Jun-23 22:06pm

For Use

Updated 3-Jun-23 23:25pm

OriginalGriff

v2

Add a Solution

Comments

Graeme_Grant 4-Jun-23 4:37am

Please trim your title so as not to be tagged as spam.

Richard Deeming 5-Jun-23 4:18am

if ( user1 ==("rock") && user2 ==("paper"))	{
    System.out.println("user1 wins!");
}

That's some strange variation on the game; usually, "paper wraps rock" means that user2 would win in this case.

2 solutions

Solution 2

You may be interested in:
Java String equals() Method[^]
String Comparison in Java - javatpoint[^]
https://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java[^]

Posted 3-Jun-23 22:52pm

Patrice T

Comments

CPallini 5-Jun-23 2:14am

5.

Patrice T 5-Jun-23 3:58am

thank you

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2023-06-03T23:25:00

The first thing I'd do is change that: rather than getting the user to type out their action in full, prompt them for a number: 0 for Scissor, 1 for Rock, 2 for Paper.
That makes life a lot easier for them: they don't have to be able to type accurately, and easier for you because it's easier to verify what is happening: you just add a test for value entered is a valid number. If you work with strings, you make life difficult for yourself as "scissor" is not the same string as "Scissor, "SCISSOR", or any other combination of upper and lower case characters.

Now you can use numbers most of the time. First check if they are the same and if so, print that it's a draw.

Then check who wins:

Paper beats Rock, Rock beats Scissor, Scissor beats paper

Or using numbers:

2 beats 1, 1 beats 0, 0 beats 2

So you could just add one to user 2 input modulo 3 and compare that to the user 1 input: if they are the same, user1 wins. If not, user 2 does!
think about it: it's pretty obvious when you get your head around it!

Simpler tests, shorter, easier code.