My code is displaying right ans for sample input but codechef is displaying wrong answer and time limit exceed.

Question

1.00/5 (1 vote)

See more:

It's a lockdown. You’re bored in your house and are playing golf in the hallway.

The hallway has N+2 tiles numbered from 0 to N+1 from left to right. There is a hole on tile number x. You hit the ball standing on tile 0. When you hit the ball, it bounces at lengths of k, i.e. the tiles covered by it are 0,k,2k,…, and so on until the ball passes tile N+1.

If the ball doesn't enter the hole in the first trial, you try again but this time standing on the tile N+1. When you hit the ball, it bounces at lengths of k, i.e. the tiles covered by it are (N+1),(N+1−k),(N+1−2k),…, and so on until the ball passes tile 0.

Find if the ball will enter the hole, either in its forward journey or backward journey.

Note: The input and output of this problem are large, so prefer using fast input/output methods.

Input
The first line contains an integer T, the number of test cases. Then the test cases follow.
The only line of each test case contains three integers N,x,k.
Output
Output in a single line, the answer, which should be "YES" if the ball enters the hole either in the forward or backward journey and "NO" if not.

You may print each character of the string in uppercase or lowercase (for example, the strings "yEs", "yes", "Yes" and "YES" will all be treated as identical).

Constraints
1≤T≤105
1≤x,k≤N≤109
Subtasks
Subtask #1 (10 points): N≤102
Subtask #2 (90 points): original constraints

Sample Input
3
5 4 2
5 3 2
5 5 2

Sample Output
YES
NO
NO

What I have tried:

Python

t = int(input())
arr = []
for _ in range(t):
    n, x, k = input().split()
    i = 0
    while int(k) * i <= int(x):
        arr.append(int(k) * i)
        i += 1
    j = 0

    while (int(n) + 1) - int(k) * j >= int(x):
        arr.append(int((int(n) + 1) - int(k) * j))
        j += 1
    if int(x) not in arr:
        print("NO")
    else:
        print("YES")

my code is displaying the right answer for sample input but not for other subtasks :(

Posted 7-May-21 22:56pm

Muskan Verma 2021

Updated 19-May-21 8:09am

Add a Solution

Comments

Muskan Verma 2021 8-May-21 4:59am

URL for this ques is
https://www.codechef.com/MAY21C/problems/LKDNGOLF

Richard MacCutchan 8-May-21 5:20am

Convert your input values to int types as you read them, not in every calculation. That will affect the time it takes.

Muskan Verma 2021 8-May-21 7:45am

ok sir, thank you

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2021-05-07T23:18:00

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

C#

int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

How do you expect to learn how to do this, if every time your code fails you ask us to fix it for you? Ask yourself: is there any point in my trying to do "code challenges" if someone else does the complicated bit?

Patrice T · Accepted Answer · 2021-05-08T12:51:00

Quote:
time limit exceed.

This usually mean that your code is too simple minded and that is at the expense of runtime.
Think of a multiplication x*y, you can add x, y times to a total, it works, but it is not efficient.
You have the same kind of problem with your algorithm.
-----
As programmer, your job is also to debug your code.

Quote:
my code is displaying the right answer for sample input but not for other subtasks

Rather simple: Either your algorithm is wrong or incomplete, either your do not translate correctly your algorithm.

First, you need to check if the code is correct but your code is a black box, the debugger allow you to execute your code step by step and to check every variable as your code execute. At every step, check if variables evolve as expected.

If the code is correct, this means that the algorithm is not, or incomplete.
-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

My code is displaying right ans for sample input but codechef is displaying wrong answer and time limit exceed.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0