Run a time counter on form1 and form2 C# winforms

Question

1.00/5 (2 votes)

See more:

How can i run the time counter on form1 as well as the form 2. currently my code for running the counter on form 1 is

What I have tried:

 **form1 timer**

   private void UpdateTime()
    {
      
        lbltime.Text = GetTimeString(watch.Elapsed);
    }

    private string GetTimeString(TimeSpan elapsed)
    {
        string result = string.Empty;

        result = string.Format("{0:00}:{1:00}:{2:00}",
            elapsed.Hours,
            elapsed.Minutes,
            elapsed.Seconds,
            elapsed.Milliseconds);

        return result;
    }

    **form 2**
    lblcountertime=GetTimeString(watch.Elapsed);
    but it is not working.
I want that counting of lbltime counting "00:01:10" to run on form 2 as well. how can i achive that please guide me.

Posted 7-Jan-21 0:20am

Member 14852747

Updated 7-Jan-21 2:39am

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2021-01-07T00:36:00

Solution 1

You should use a Timer Class (System.Timers) | Microsoft Docs[^], which will allow you to update your counters at regular intervals.

Posted 7-Jan-21 0:36am

Richard MacCutchan

Comments

Member 14852747 7-Jan-21 6:40am

I use this class but it is not working
public class MyTime
{
public string GetTimeString(TimeSpan elapsed)
{
string result = string.Empty;

result = string.Format("{0:00}:{1:00}:{2:00}",
elapsed.Hours,
elapsed.Minutes,
elapsed.Seconds,
elapsed.Milliseconds);

return result;
}
}

Richard MacCutchan 7-Jan-21 6:57am

Your format string contains only three fields, but you are passing four values.

OriginalGriff · Answer 2 · 2021-01-07T00:43:00

You need to pass a reference to watch to Form2 when you display it from Form1 or use a static variable to hold it.

The first is difficult, because TimeSpan is a struct and thus a value type, so every time you use it you take a copy of the current value.
The second if simple, but I still wouldn't use it like that.
Instead, create a static DateTime which you preset when you start the timer - either to DateTime.Now for a "up" timer, or the finish time for a "down" timer. Then each form can use that independently to display it's information by generating a TimeSpan by subtraction using the current time.

And by the way ... you are only displaying three items via your call to string.Format, but you pass four items as parameters ...

Maciej Los · Answer 3 · 2021-01-07T02:39:00

First of all, i'd suggest to read this: Five Common Daylight Saving Time Antipatterns of .NET Developers[^]

If you want to measure elapsed time, i'd recommend to use Stopwatch[^] together with Timer[^].

Steps to do:

Form 1

1. Drop Timer (timer1) on the form
2. Set the following properties: Interval=100, Modifiers=Internal
3. Add Label (label1) and set property Text="00:00:00"
4. Button (button1) and set property Text="Open form 2"
5. Paste below code:

C#

public partial class Form1 : Form
{

    private readonly Stopwatch sw = new Stopwatch();

    public Form1()
    {
        InitializeComponent();
        sw.Start();
        timer1.Start();
    }

    private void timer1_Tick(object sender, EventArgs e)
    {
        label1.Text = sw.Elapsed.ToString(@"hh\:mm\:ss");
    }

    public string ElapsedTime
    {
        get => label1.Text;
    }

    private void button1_Click(object sender, EventArgs e)
    {
        Form2 frm = new Form2(this);
        frm.Show();
    }

    private void Form1_FormClosing(object sender, FormClosingEventArgs e)
    {
        timer1.Stop();
        sw.Stop();
    }

}

Form 2

1. Add Label (label1) and set property Text="00:00:00"
2. Button (button1) and set property Text="Close"
3. Paste below code:

C#

public partial class Form2 : Form
{
    Form1 frm;
    public Form2(Form1 f)
    {
        InitializeComponent();
        frm = f;
        label1.Text = frm.ElapsedTime;
        frm.timer1.Tick += OnTimerTick;
    }

    private void button1_Click(object sender, EventArgs e)
    {
        frm.timer1.Tick -= OnTimerTick;
        this.Close();
    }

    private void OnTimerTick(object sender, EventArgs e)
    {
        label1.Text = frm.ElapsedTime;
    }

}

Build project and have a fun!