Update query not working

Question

1.00/5 (1 vote)

See more:

A first chance exception of type 'System.Data.SqlClient.SqlException' occurred in System.Data.dll

Additional information: Incorrect syntax near '='.

C#

private void buttonupdate_Click(object sender, EventArgs e)
        {
            connection.Open();
            //SqlCommand command = new SqlCommand();
            //command.Connection = connection;
            SqlCommand command = new SqlCommand("UPDATES entry SET  Name = @name, Father Name = @fathername, Gender = @gender, CNIC = @cnic, Mobile = @mobile, Date of Birth = @birthdate, Address = @address,Village Council =  @vc, Tehsil = @tehsil, District = @district, occupation = @occupation where Serial No = @serialno", connection);
            command.Parameters.Add(new SqlParameter("@serialno", textBoxserialno.Text));
            command.Parameters.Add(new SqlParameter("@name", textBoxname.Text));
            command.Parameters.Add(new SqlParameter("@fathername", textBoxfathername.Text));
            command.Parameters.Add(new SqlParameter("@gender", comboBoxgender.GetItemText(comboBoxgender.SelectedItem)));
            command.Parameters.Add(new SqlParameter("@cnic", textBoxcnic.Text));
            command.Parameters.Add(new SqlParameter("@mobile", textBoxmobile.Text));
            command.Parameters.Add(new SqlParameter("@birthdate", dateTimePickerdob.Value.ToString()));
            command.Parameters.Add(new SqlParameter("@address", textBoxvillage.Text));
            command.Parameters.Add(new SqlParameter("@vc", textBoxvc.Text));
            command.Parameters.Add(new SqlParameter("@tehsil", textBoxtehsil.Text));
            command.Parameters.Add(new SqlParameter("@district", textBoxdistrict.Text));
            command.Parameters.Add(new SqlParameter("@occupation", textBoxoccupation.Text));
            command.ExecuteNonQuery();
            connection.Close();
            MessageBox.Show(textBoxname.Text, "Update", MessageBoxButtons.OK, MessageBoxIcon.Information);
           

        }

What I have tried:

I have tried but not succeeded.

Posted 6-May-20 9:21am

AttaUrRahman

Updated 6-May-20 10:36am

Maciej Los

v2

Add a Solution

Comments

Maciej Los 6-May-20 16:13pm

UPDATES??? It should be UPDATE!!!

AttaUrRahman 6-May-20 16:40pm

Thanks.

4 solutions

Solution 3

Does the field 'Father Name' have a space in it if so you need to put the field name in square brackets.

Posted 6-May-20 10:20am

Tony Hill

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2020-05-06T10:15:00

Solution 2

Try this:

C#

SqlCommand command = new SqlCommand("UPDATE entry SET  Name = @name, [Father Name] = @fathername, Gender = @gender, CNIC = @cnic, Mobile = @mobile, [Date of Birth] = @birthdate, Address = @address, [Village Council] =  @vc, Tehsil = @tehsil, District = @district, occupation = @occupation
where [Serial No] = @serialno", connection);

Changes:
1. UPDATES replaced with UPDATE
2. Every column name with space between words has been arounded with []

Posted 6-May-20 10:15am

Maciej Los

Updated 6-May-20 10:18am

v3

Comments

AttaUrRahman 6-May-20 16:42pm

Thank You Sir.

Maciej Los 6-May-20 16:51pm

You're very welcome.

MadMyche 6-May-20 19:13pm

+5

Maciej Los 7-May-20 0:39am

Thank you.

MadMyche · Accepted Answer · 2020-05-06T10:36:00

If you have access to an SQL Development program (such as Sql Server Management Studio) you should author your SQL Command there and try them out. And pay attention to the intellisense and highlighting that it applies.

SQL

UPDATES @Entry                      -- UPDATES is NOT highlighted

SET Name            = @names        -- Name is highlighted
,   Father Name     = @fathername   -- Name is highlighted
,   Gender          = @gender
,   CNIC            = @cnic
,   Mobile          = @mobile
,   Date of Birth   = @birthdate    -- Date is highlighted
,   Address         = @address      -- Address is highlighted
,   Village Council =  @vc
,   Tehsil          = @tehsil
,   District        = @district
,   occupation      = @occupation

where (Serial No = @serialno)      -- Both Serial and No are highlighted

1. It should be UPDATE as previously noted
2. Name is a "special" word
3. Space in column name, should be wrapped [Father Name]
4. Date is a data type, space in column name
5. Address is a "special" word
6. Both Serial and No are special words

My rules of development...
1. If a column name or variable changes colors when I type, I change that items name
2. No spaces in column names (or variables)
3. Use a SQL IDE when developing a query for writing and testing

Tony Hill · Accepted Answer · 2020-05-06T09:28:00

Solution 1

SqlCommand command = new SqlCommand("UPDATES entry SET Name = @name, Father Name = @fathername, Gender = @gender ...<br />
                            Try removing the space between 'Father' and 'Name'

Posted 6-May-20 9:28am

Tony Hill

Updated 6-May-20 9:31am

v3

Comments

AttaUrRahman 6-May-20 16:40pm

Thanks.

Update query not working

4 solutions

Solution 2

Solution 4

Solution 1

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us