Too many initializer values error TCHAR

Question

0.00/5 (No votes)

See more:

i cannot seem to get rid of this error

TCHAR exts[] = { TEXT(".txt") ,TEXT(".docx") ,TEXT(".doc")}; /* null terminated array */

What I have tried:

TCHAR *exts;
exts = (TCHAR*)param;
//exts = param;

while (*exts) {
TCHAR *cur_ext;
cur_ext = PathFindExtension(file_path);
if (cur_ext) {
if (_tcscmp(cur_ext, exts) == 0) {
/* do what you want here with the file */
/* printf as an example here */
// _tprintf(TEXT("%s\n"), file_path);
//file << quoted(chk);
file << (TEXT("\n"))<

Posted 15-Feb-20 0:57am

Member 12899279

Updated 19-Feb-20 18:22pm

v4

Add a Solution

2 solutions

Solution 1

Most likely it is because CHAR is not a defined type. Did you mean to use TCHAR?

[edit]
Try:

C++

TCHAR* exts[] = { TEXT(".txt") ,TEXT(".docx") ,TEXT(".doc")}; /* null terminated array of strings */

or better still

C++

PTCSTR exts[] = { TEXT(".txt") ,TEXT(".docx") ,TEXT(".doc")}; /* null terminated array */

[/edit]

[edit sequence="2"]
Something like ...

C++

// caller
PTCSTR exts[] = { TEXT(".txt") ,TEXT(".docx") ,TEXT(".doc"), NULL}; // null terminated array

DoSearch(TEXT("rootdirectory"), exts);
// ...

// function
... DoSearch(PCTSTR rootDirectory, PCTSTR* extensions)
{
    while (*extensions != NULL)
    {
        // process next extension
        Recursive(rootDirectory, *extensions);

        extensions++; point to the next entry
    }
}

[/edit]

Posted 15-Feb-20 1:03am

Richard MacCutchan

Updated 15-Feb-20 1:50am

v3

Comments

Member 12899279 15-Feb-20 7:17am

ohh sorry my mistak yes it ws TCHAR i changed to CHAR whie trying to remove error

Member 12899279 15-Feb-20 7:31am

i actually did tht but the problem is i am passing it to a funton and it aonly takes .txt extension and doesnt check other extensions here's sample of my func in which i am passing this
void ext_search(TCHAR *root_dir, TCHAR *exts)
{
RecursiveDirectory(root_dir, rd_cb, (void *)exts);
}

Richard MacCutchan 15-Feb-20 7:40am

Once again you are only passing a pointer to the first entry: a pointer to an array of characters. Use PTSTR or PCTSTR which is an array of strings, and much clearer.

Also why are you using void* rather than the correct type?

Member 12899279 15-Feb-20 7:41am

can you show how to do that?or can't i use loop to iterate through all extensions one by one?

Member 12899279 15-Feb-20 7:45am

i just checked by replacing it with PTSTR but due to some limitations i can only use tchar so i need to do put some loop here to iterate through all of the extensions one by one and call the recursivedirectory()function with each extension one by one

Richard MacCutchan 15-Feb-20 7:50am

That makes no sense, the only limitation is the one you put in your code. See my updated solution.

Member 12899279 15-Feb-20 8:39am

i am able to terate through all extnsions with this code:
void ext_search(TCHAR *root_dir, PCTSTR *exts)
{
while (*exts != NULL)
{
// process next extension
RecursiveDirectory(root_dir, rd_cb, (VOID *)exts);

*exts++;
}
}

void example_func(void)
{

PCTSTR exts[] = { TEXT(".txt") ,TEXT(".docx") ,TEXT(".doc"),NULL }; /* null terminated array */
ext_search(TEXT("C:"), exts);
}
but issue is that its passing some garbage type value to the next function so its unable to match the extension below is the code for matching extension
BOOL WINAPI rd_cb(TCHAR *file_path, VOID *param)
{

TCHAR *exts;
exts = (TCHAR*)param;
//exts = param;

while (*exts) {
TCHAR *cur_ext;
cur_ext = PathFindExtension(file_path);
if (cur_ext) {
if (_tcscmp(cur_ext, exts) == 0) {
/* do what you want here with the file */
/* printf as an example here */
// _tprintf(TEXT("%s\n"), file_path);
//file << quoted(chk);
file << (TEXT("\n"))<

Richard MacCutchan 15-Feb-20 9:35am

Your code is not easy to understand. What is RecursiveDirectory and where is it defined? Also, in rd_cb you should declare param as PCTSTR, as it refers to a single extension string. Don't use void* (and definitely not VOID*) unless you absolutely need to anywhere. And also inside rd_cb you have while (*exts), but exts there is a single string so why are you trying to iterate over it?

And finally you say "but issue is that its passing some garbage". You need to show where that is happening and exactly what this "garbage" is.

Member 12899279 15-Feb-20 9:44am

i have posted complete code now in which RecursiveDirectory func is defined

Member 12899279 15-Feb-20 9:46am

when i pass from from ext_search to rd_cb then the second param in rd_cb is not getting what was passed as extension from ext_search you can now paste whole code and just call the ext_search from main and you can see that in debug what i am talking about

Member 12899279 15-Feb-20 9:32am

that doesn't work either here's the complete code

Code moved to question.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2020-02-15T04:52:00

This is a basic routine that works.

C++

BOOL rd_cb(LPTSTR lpszFile, PCTSTR pszExtension)
{
    PCTSTR cur_ext = PathFindExtension(lpszFile);
    if (cur_ext && _tcscmp(cur_ext, pszExtension) == 0)
    {
        wcout << "Found: " << lpszFile << endl;
        return TRUE;
    }
    
    return FALSE;
}

int RecursiveDirectory(PCTSTR lpszPath, PCTSTR pszExtension)
{
    WIN32_FIND_DATA    WFD;
    int                qwCount = 0;
    TCHAR              szFileSpec[MAX_PATH + 1];
    
    PathCombine(szFileSpec, lpszPath, TEXT("*.*"));
    HANDLE hSearch = FindFirstFile(szFileSpec, &WFD);
    if (hSearch == INVALID_HANDLE_VALUE) return 0;
    do
    {
        if (_tcscmp(WFD.cFileName, TEXT("..")) && _tcscmp(WFD.cFileName, TEXT("."))) 
        {
            if (WFD.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY && !(WFD.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT))
            {
                PathCombine(szFileSpec, lpszPath, WFD.cFileName);
                qwCount += RecursiveDirectory(szFileSpec, pszExtension);
            }
            else 
            {
                PathCombine(szFileSpec, lpszPath, WFD.cFileName);
                if (rd_cb(szFileSpec, pszExtension))
                    qwCount++;
            }
        }
    } while (FindNextFile(hSearch, &WFD));
    FindClose(hSearch);
    return qwCount;
}

The initial call would be something like:

C++

RecursiveDirectory(TEXT("C:\\Users\\username\\Documents"), TEXT(".txt"));

[edit]
Replaced the lpCallback with a straightforward function call, to simplify the code.
[/edit]