Check this c# code to create a string

Question

0.00/5 (No votes)

See more:

Please see the code:

public static string str1;
   public static string str2;
   public static string str3;
   public static string gets3pending()
   {
       string id = "";
       string Path = "";
       SqlConnection con = Database.GetConnection();
       SqlCommand com = new SqlCommand("Select id,Path from tblShareFile where status=0", con);
       DataSet ds = new DataSet();
       DataTable dt = new DataTable();

       SqlDataAdapter da = new SqlDataAdapter(com);
       //DataSet ds = new DataSet();
       da.Fill(ds, "tblShareFile");
       da.Fill(dt);
       SqlDataReader dr = com.ExecuteReader();

       while (dr.Read())
       {
           if (dt.Rows.Count > 0)
           {
               //for (int i = 0; i < dt.Rows.Count; i++)
               {
                   str1 += dr["id"].ToString() + "'";
                   str2 += dr["Path"].ToString() + "'";

               }
           }
       }

           dr.Close();

           string str3 = str1.ToString() + str2.ToString();

           return str3;

I want to create string like this: 1,path1 2,path2 3,path3 etc.
It's just to show id and path name, but it's not working.

Please, can any one help me?

Thanks in advance.

Posted 18-May-11 19:27pm

rahul dev123

Updated 18-May-11 21:50pm

Dalek Dave

v4

Add a Solution

Comments

saxenaabhi6 19-May-11 1:31am

did you put the break points on str1 and str2 and watched what are the outputs for each iteration in the loop

Dalek Dave 19-May-11 3:50am

Edited for Grammar and Readability.

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2011-05-18T19:32:00

Solution 1

Try

C#

f (dt.Rows.Count > 0)
{
//for (int i = 0; i < dt.Rows.Count; i++)
  {
     str3 + = dr["id"].ToString() + "," + dr["Path"].ToString() + " ";
  }
}

Posted 18-May-11 19:32pm

Abhinav S

v2

Comments

Sergey Alexandrovich Kryukov 19-May-11 1:35am

"+ =" will not compile. And why do you set a bad example of using repeated "+"? It's not good; use "string.Format" for clarity and performance.
--SA

Abhinav S 19-May-11 2:06am

OP can make note of that as well.

rahul dev123 19-May-11 1:43am

please help me providing example code for this

rahul dev123 19-May-11 1:46am

str3 + = dr["id"].ToString() + "," + dr["Path"].ToString() + " ";
it's not supported. different errors are there

Abhinav S 19-May-11 2:05am

This was just to give you an idea of what you need to do - it was not the exact answer.

Dalek Dave 19-May-11 3:51am

Seems Reasonable.

Abhinav S 19-May-11 4:03am

Thanks DD.

Steven.Pinto2000 · Answer 2 · 2011-05-18T20:23:00

Solution 2

It is good to use This

C#

StringBuilder str = new StringBuilder();
            while (dr.Read())
      {
          if (dt.Rows.Count > 0)
          {

          str.Append(dr["id"].ToString());
          str.Append(" ,");
          str.Append(dr["Path"].ToString());
          }
      }

Posted 18-May-11 20:23pm

Steven.Pinto2000

Mahendra.p25 · Answer 3 · 2011-05-18T20:30:00

Solution 3

you can also do it with dataset like below

C#

for(int i=0 ;i<ds.Tables[0].Rows.Count;i++)
             {
                 str1 += ds.Tables[0].Rows[i]["id"].ToString() + "," + ds.Tables[0].Rows[i]["Name"].ToString();
             }

Posted 18-May-11 20:30pm

Mahendra.p25

nit_singh · Answer 4 · 2011-05-18T21:18:00

public static string str1;
    public static string str2;
    public static string str3;
    public static string gets3pending()
    {
        string id = "";
        string Path = "";
        SqlConnection con = Database.GetConnection();
        SqlCommand com = new SqlCommand("Select id,Path from tblShareFile where status=0", con);
        DataSet ds = new DataSet();
        DataTable dt = new DataTable();
      
        SqlDataAdapter da = new SqlDataAdapter(com);
        //DataSet ds = new DataSet();
        //da.Fill(ds, "tblShareFile");
        da.Fill(dt);
        //SqlDataReader dr = com.ExecuteReader();     
        //while (dr.Read())
        //{            
          StringBuilder str = new StringBuilder();

          if (dt.Rows.Count > 0)
            {
                foreach (DataRow dr in dt.Rows)
                {
                    str.Append(dr["id"].ToString());
                    str.Append(" ,");
                    str.Append(dr["Path"].ToString());
                }
            }
        //}          
            //dr.Close();      
            return str.ToString();