Click here to Skip to main content
15,912,400 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
def greedy_cow_transport(cows,limit=10):
    train = []
    while sum(cows.values()) > 0:
        cart = []
        total = 0
        for cow, value in sorted(cows.items(), key=lambda x:x[1], reverse=True):
            if cows[cow] != 0 and value + total <= limit:
                cart.append(cow)
                total += value
                cows[cow] = 0
        train.append(cart)
    return train

The code above gives the output:

[['Betsy', 'Henrietta', 'Herman', 'Oreo', 'Millie', 'Maggie', 'Moo Moo', 'Milkshake', 'Lola', 'Florence']]

I want output to be displayed as shown below:

[['Betsy'],
 ['Henrietta'],
 ['Herman', 'Maggie'],
 ['Oreo', 'Moo Moo'],
 ['Millie', 'Milkshake', 'Lola'],
 ['Florence']] 

How to display this way? Is this going to be counted in greedy algorithm?


What I have tried:

I have tried greedy algorithm but unable to make it work its not giving output. Its only showing "None".
Posted
Updated 9-Nov-19 3:15am
Comments
Patrice T 3-Nov-19 15:45pm    
And the input was ...
Richard MacCutchan 4-Nov-19 4:00am    
It's a secret.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Comments
A. B. Dinshaa 11-Nov-19 9:43am    
You want to say if I am able to give the output given above I may be able to give all the outputs its only depends on use which is going to improve the skill. Right?????
OriginalGriff 11-Nov-19 9:55am    
No - I'm saying that you need to use the debugger to examine exactly what your existing code is doing, and use that information to work out why it isn't working...
Quote:
How to correct the mistake in this code?

You forgot to give us a working piece of code, we can't test your code.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.
 
Share this answer
 
Comments
A. B. Dinshaa 4-Nov-19 11:34am    
I want the second output not the first output which the code is already giving. You have any idea what changes to make? Do you have anything other than the debugger to reach the required output as debugger will take a lot of time to understand....
Patrice T 4-Nov-19 11:36am    
GIVE THE INPUT !
A. B. Dinshaa 4-Nov-19 11:54am    
You mean the dictionary file? or the text file on which I want to do implement the code?
Patrice T 4-Nov-19 12:17pm    
All what is necessary to run your code and get desired output.
including calling code.
A. B. Dinshaa 4-Nov-19 12:35pm    
Ok thankyou got it. Need to learn how to use debugger in order to trace errors.
A second answer after your solution.
By combining the question, I think I finally understood what you try to do.

First rule:
- When you ask a question to people not knowing what you try to do, make sure that everything needed is in the question. When you reread your question, if you need some other knowledge to understand it, something is missing.
Ex: by not giving the input matching the desired output of the question, you make sure that nobody can do anything with it, thus it is impossible to check your code.

This input is over simplified and can't be used to check anything:
Python
limit, cows = 10, {"Jesse": 6, "Maybel": 3, "Callie": 2, "Maggie": 5}

Some will tell you that [["Jesse"],["Maybel", "Callie", "Maggie"]] is a better solution.

Basically, your problem fits with IP problem (Integer Programming), 1D CSP (Cutting Stock Problem) or Bin Packing.
Integer programming - Wikipedia[^]
Cutting stock problem - Wikipedia[^]
Bin packing problem - Wikipedia[^]

Your algorithm is not greedy, it is a FF (First Fit) or FFD (First Fit Decreasing) if input is already sorted.
A greedy algorithm build a solution by repeatedly building the best bin (minimum loss) with remaining cows.
 
Share this answer
 
v2
I hope that I can give the result you have specified. Using a list to display the answer and taking the input from a list written in the code are two different things that's why I mentioned dictionary. Displaying the output which you have specified from my question is easy and can be displayed by writing the list in the code. List is easy but from dictionary may take time.
 
Share this answer
 
Comments
Richard MacCutchan 9-Nov-19 9:45am    
Why have you posted this comment here, it is not a Solution? If you want it to be seen by the person you are trying to talk to then use the Reply button at that person's comment.
A. B. Dinshaa 11-Nov-19 9:41am    
ok

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900