Trying to use a repeater within a 'while' and 'if' condition but reader not working

Question

1.00/5 (1 vote)

See more:

I'm trying to get the repeater to display my data from inside the if condition but for some reason it won't work. Whenever I debug my code it hits inside the if condition because it's true and goes through my code perfectly but the results are wrong. Any help would be appreciated.

Thanks

What I have tried:

C#

private void LoadSchedule()
    {
        string connString = ConfigurationManager.ConnectionStrings["DatabaseConnection"].ConnectionString;
        using (SqlConnection conn = new SqlConnection(connString))
        {
            conn.Open();
            using (SqlCommand comm = new SqlCommand("GetSchedule", conn))
            {
                using (SqlDataReader reader = comm.ExecuteReader())
                {

                    while (reader.Read())
                    {
                        DateTime localDate = DateTime.Now();
                        DateTime PoolStatusActive = Convert.ToDateTime(reader["PoolActive"]);
                        DateTime PoolStatusDisabled = Convert.ToDateTime(reader["PoolDisabled"]);

                        if (localDate > PoolStatusActive && localDate < PoolStatusDisabled)
                        {
                            myRepeater.DataSource = reader;
                            myRepeater.DataBind();
                            MessageBox.Show("True");
                        }

                        else
                        {
                            MessageBox.Show("False");
                        }
                    }
                }
            }
        }
    }

Posted 10-Feb-19 8:45am

Commish13

Updated 12-Feb-19 5:24am

RickZeeland

v2

Add a Solution

Comments

Richard Deeming 12-Feb-19 11:16am

MessageBox.Show("True");

Same problem as your previous question: this will not work in a web application.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2019-02-10T09:25:00

Solution 1

Read what I said when you asked this last time: Sql open connection just once for multiple readers[^]

Posted 10-Feb-19 9:25am

OriginalGriff

Comments

Commish13 10-Feb-19 15:44pm

I appreciate your help but I still don't know how to get the loop and the if statement to work together.

Commish13 10-Feb-19 16:31pm

How can I get someone else to look at this question?

Maciej Los 12-Feb-19 12:04pm

Agree!

Richard Deeming · Answer 2 · 2019-02-12T05:24:00

while (reader.Read())

Keeps executing until there are no more records to read.

myRepeater.DataSource = reader;
myRepeater.DataBind();

Tells the repeater to read all remaining records, and display them. No filter will be applied to those records. When DataBind() returns, there are no more records to read.

If you want to filter the results that you're displaying in the repeater, then you need to filter the data source. For example:

C#

private void LoadSchedule()
{
    string connString = ConfigurationManager.ConnectionStrings["DatabaseConnection"].ConnectionString;
    using (SqlConnection conn = new SqlConnection(connString))
    using (SqlCommand comm = new SqlCommand("GetSchedule", conn))
    {
        SqlDataAdapter adapter = new SqlDataAdapter(comm);
        DataTable table = new DataTable();
        adapter.Fill(table);
        
        DateTime localDate = DateTime.Now;
        
        myRepeater.DataSource = table.AsEnumerable()
            .Where(r => r.Field<DateTime>("PoolActive") < localDate)
            .Where(r => r.Field<DateTime>("PoolDisabled") > localDate);
        
        myRepeater.DataBind(); 
    }
}