The program segment has an 'if' clause embedded in an ADD button. The 'if' clause is not working

Question

1.00/5 (1 vote)

See more:

C#

protected void Add_Click(object sender, EventArgs e)
        {
            //Add Begin
            try
            {
                // Connection to the database
                string str;
                str = ConfigurationManager.ConnectionStrings["WEBHR"].ConnectionString;
                SqlConnection sqlCon = new SqlConnection(str);
                SqlCommand sqlCmd = new SqlCommand("sp_GenerateLeaveID", sqlCon);
                sqlCmd.CommandType = System.Data.CommandType.StoredProcedure;

                // Create and supply the output parameters
                string intno,intno1,intno2;
          
                intno2 = txt_idcnt.Text;

                if (intno2 == "")
                {
                    lblstatus.Text = "No record Selected";
                }

                // Execute the stored procedure
                sqlCmd.ExecuteNonQuery();
                sqlCon.Close();
            }
            catch (Exception ex)
            {
                lblstatus.Text = ex.Message;
            }
            //Add End
        }

What I have tried:

C#

intno2 = txt_idcnt.Text;
                if (intno2 == "")
                {
                    lblstatus.Text = "No record Selected";
                }

When txt_idcnt.Text is empty the condition is skipped

Posted 4-Dec-18 14:28pm

Member 12770648

Updated 4-Dec-18 22:43pm

MadMyche

v2

Add a Solution

Comments

MadMyche 4-Dec-18 20:54pm

Does the procedure execute? What is displayed?

Member 12770648 4-Dec-18 20:59pm

Yes

MadMyche 4-Dec-18 21:04pm

So that portions works out. What is supposed to change based on your input? The only thing I see is the "No Record Selected" label which solely depends on the input page.

Member 12770648 4-Dec-18 21:13pm

If a record is selected from a grid to populate the text boxes on a page and txt_idcnt.Text is empty

intno2 = txt_idcnt.Text;

if (intno2 == "")
{
lblstatus.Text = "No record Selected";
}

Member 12770648 4-Dec-18 21:18pm

Thereafter the ADD button is selected for submission.

If intno2 is empty the conditional statement should kick in.

MadMyche 4-Dec-18 21:51pm

And what does stp-by-step debugging tell you the values are along the way?

Member 12770648 5-Dec-18 1:21am

Null

How do you check for null

Karthik_Mahalingam 4-Dec-18 23:35pm

what is the text being displayed on lblstatus.Text ?

Member 12770648 5-Dec-18 1:20am

How do you check for null?

F-ES Sitecore 5-Dec-18 4:35am

if (myVar == null)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-12-04T20:09:00

Use the debugger - it's the only way to find out what is going on. We can't run your code under the same conditions, so we really can't tell you "do this".

Put a breakpoint on the line

str = ConfigurationManager.ConnectionStrings["WEBHR"].ConnectionString;

And when it reaches it the debugger will stop. Single step each line, looking closely at each variable and follow exactly what is happening. You should be able to work it out for yourself from that, but if you still can't, at least you will have information to give us to help us work it out. At the moment, all you have is "it don't work" which helps no-one!

BTW: I'd strongly suggest that you use using blocks around your SQl objects, to ensure they are closed and disposed correctly:

try
{
    // Connection to the database
    string str;
    str = ConfigurationManager.ConnectionStrings["WEBHR"].ConnectionString;
    using (SqlConnection sqlCon = new SqlConnection(str))
    {
        using (SqlCommand sqlCmd = new SqlCommand("sp_GenerateLeaveID", sqlCon))
        {
            sqlCmd.CommandType = System.Data.CommandType.StoredProcedure;

            // Create and supply the output parameters
            string intno,intno1,intno2;

            intno2 = txt_idcnt.Text;

            if (intno2 == "")
            {
                lblstatus.Text = "No record Selected";
            }

            // Execute the stored procedure
            sqlCmd.ExecuteNonQuery();
        }
    }
}
catch (Exception ex)
{
    lblstatus.Text = ex.Message;
}

Richard MacCutchan · Answer 2 · 2018-12-04T22:43:00

Solution 2

Make use of the proper methods available in the String class: String.IsNullOrEmpty Method (System) | Microsoft Docs[^].

Posted 4-Dec-18 22:43pm

Richard MacCutchan