Comments by Sri Prasad Tadimalla (Top 3 by date)

In the end, this is what I came up with.

<pre lang="c#">public void ExecuteOnReader(string query, Action<idatareader> dataReaderAction)
{
using (OdbcConnection connection = new OdbcConnection(_connectionString))
{
try
{
connection.Open();
Logger.LogInfo("Connection Opened");
}
catch (Exception ex)
{
Logger.LogException(ex, "Executing Query", "Unable to connect to database with: " + _connectionString);
throw;
}
SetDateFormatForOracleDatabases(connection);
Logger.LogSql(query, "Query");
try
{
var w = Logger.StartWatch();
using (var command = new OdbcCommand(query, connection))
{
using (var reader = command.ExecuteReader(CommandBehavior.KeyInfo))
dataReaderAction.Invoke(reader);
}
Logger.StopWatch(w, "Query Execution");
}
catch (Exception ex)
{
Logger.LogException(ex, "Executing Query", "Unable to execute query: " + query);
throw;
}
}
}
</pre>

Thanks everyone. I thought of passing the function in but I usually try to avoid doing that. The generic approach also seems like a good idea, especially if I make T an interface.