Comments by amin.j (Top 35 by date)

Dear Andreas, thanks a lot it works. However, is it possible to explain it more what is the error is about and what the solution does!

I did this code for substituting the typecasting in C++ instead of the above code in C but it doesn't work. There should be a dereferencing after typy casting.

bool equals_int(const void* elem1, const void* elem2){
if (*(static_cast<int*>(elem1)) == *(static_cast<int*>(elem2))){
....

Dear @Philippe, what are your suggestions for me to write real C++ code? I mean what is the fastest and straightforward way to learn that? Is there any tutorial or valuable book or whatever else?

Dear Richard, Many thanks for your suggestions. I did that and it is solved. i have a question: Do you know some tutorial or sth that really teaches great features of C++? I mean to read sth useful in a short time.

-1's are going to the first of the array, not at the last..
-1-1-1345

Can you explain more? If you can give me an example of in which part of the code I use vector, that would be great. If you have suggestions for me to go from C to C++ and correct my way of programming that would be your kindness. Thank you so much for your care.

I have two arrays: equiDisStr1 and equiDisStr2
I want to compare these two arrays and if the size of them are not equal, make it equal by defining new array with the maximum size of two arrays; in fact, I fill the remainder of new array by -1 (which is a flag for me).

--- for example

equiDisStr1 : 2345
equiDisStr2: 3457604

So: size(equiDisStr1) < size(equiDisStr2) ---->
Output: updDisStr == -1-1-12345
equiDisStr2 == 3457604
now, size of both are 7. And based on the other parts of the program, I need to do this way.

Dear @CPallini, I did what you said, program is running now after debugging but I got an strange output something like that: 4765800241! Do you think I'm doing wrong?

int addResult, updLen;
int diffLen = abs(lenStr1 - lenStr2);
if (lenStr1 > lenStr2){
updLen = lenStr1;
int updDisStr2[updLen];
lenEqualize(updDisStr2, equiDisStr2, diffLen, updLen);
cout << updDisStr2[0]; // here is the point
}
else if (lenStr1 < lenStr2){
updLen = lenStr2;
int updDisStr1[updLen];
lenEqualize(updDisStr1, equiDisStr1, diffLen, updLen);
cout << updDisStr1[0];
}
else if (lenStr1 == lenStr2){
updLen = lenStr1;
}



void lenEqualize(int* updDisStr, int* shortLenStr, int diffLen, int updLen){
for (int i = 0; i < updLen; i++){
if (i < diffLen-1){
updDisStr[i] = -1;
}
else {
updDisStr[i] = shortLenStr[i-diffLen];
}
}
}

I read book and know basics of that. But when it comes to practical, it is a different story. First, I didn't write the code in this way which I defined array outside function, but some people said doing this way. Now, what is your suggestion: there is two ways, first I define an array and give it to the function to change, second define the array inside the function and return it.

You mean I use vector instead of pointer?

This is part of my code that gives error: when I changed that to
cout << updDisStr2[0];
now it say that updDisStr2 is not declared, but I declared it in the if. I am really confused?



if (lenStr1 > lenStr2){
updLen = lenStr1;
int updDisStr2[updLen];
lenEqualize(updDisStr2, equiDisStr2, diffLen, updLen);
}
else if (lenStr1 < lenStr2){
updLen = lenStr2;
int updDisStr1[updLen];
lenEqualize(updDisStr1, equiDisStr1, diffLen, updLen);
}

I corrected the code by your comments, the error is solved. Now, how can I reach the element of updDisStr2? I used this for the first element of this array:

cout << *updDisStr2[0] ;


but it sends error.

You got that. It needs size. But the size is not specific at the start of program. Is it possible to have a vector with call by reference?

I want to change the values of that array in the function. And don't return sth.

I removed but it is not solved.

Thanks dear nv3 for your valuable comments. Nice to meet you here today.

Yes, exactly. How it is possible to the outer for loop to write in this way?
for(auto c: s){
}

Thanks. I got that but not completely. If you can give comments about that, it would be great.

Thanks. This kind of for loop, with auto keyword, is the only way to reach elements? I mean isn't there the old fashioned for loop style: for example,
for(int i = 0; i < max; i++)

Dear nv3, many thanks. I want to use the elements of vectors in set s; for example if :

s:
01
02
...

I want to reach the 0, 1, 2, ... in each vector. How can I do that? Old-fashioned for loop I mean simply!

Dear nv3, I have another problem. I don't understand the nested for-loop at the end of program (auto i: c); if it is possible to write it more simply? In fact, I want to use the elements of the set s and how I can do this?

for(auto c: s){
for (auto i: c)
cout << i << " ";
cout << endl;
}

Dear nv3 many thanks for your valuable comments in your solution.

Thanks. But I mean how set is filled; in fact, if it is possible, please give me the explanation of the first iteration of the do-while loop when i = 0; what happens in the loop and what is the output?

Thanks. But I mean how set is filled; in fac, if it is possible, please give me the explanation of the first itheration of the do-while loop when i = 0; what happens in the loop and what is the output?

Thanks dear barneyman, but I want to know the s.insert(v) procedure? What happens there? If you can give me the explanation of one iteration of the do-while loop, that would be great.

I know but how it works? Please give me a kind of example by this program.

Dear Sergey, I don't know how it works and what happens when program reaches this line? If you can give me an explanation by example, that would be great.