transaction problem in procedure

Question

0.00/5 (No votes)

See more:

SQL-server-2000

SQL-Server-2005

, +

i have an procedure
i am using transaction in it .......

create PROCEDURE MY_TEST_PRO
(
@ID INT
)

AS
BEGIN
BEGIN TRAN

DELETE FROM Employee_Test WHERE Emp_ID=@ID

IF(@ID<10)
BEGIN
ROLLBACK;
END
COMMIT TRAN
END

it created successfully . but when i execute it through sql query ...

EXEC MYTESTPRO 1

it execute query for infinite times and status shows that "executing query " until we not cancel it .
can any buddy tell me how to write this procedure ....?

Posted 8-Jan-14 23:58pm

GDdixit

Add a Solution

3 solutions

Solution 3

All these solutions are stupid. Why not do this :

SQL

create PROCEDURE MY_TEST_PRO
(
@ID INT
)

AS
BEGIN

if (@ID > 10)
    DELETE FROM Employee_Test WHERE Emp_ID=@ID

END

But, if you were trying to write pointless code to understand transactions then, yes, you don't commit after a rollback.

Posted 9-Jan-14 12:40pm

Christian Graus

Comments

GDdixit 10-Jan-14 4:01am

yes .. the last line u wrote here , is right . i trying to use trnasaction here :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Animesh Datta · Accepted Answer · 2014-01-09T00:28:00

Solution 2

SQL

create PROCEDURE MY_TEST_PRO
(
@ID INT
)

AS
BEGIN
BEGIN TRAN
DELETE FROM Employee_Test WHERE Emp_ID=@ID
IF(@ID<10)
BEGIN
ROLLBACK;
return --//
END
COMMIT --//

END

Posted 9-Jan-14 0:28am

Animesh Datta

Kornfeld Eliyahu Peter · Accepted Answer · 2014-01-09T00:05:00

Solution 1

SQL

CREATE PROCEDURE MY_TEST_PRO (@ID INT)
AS
BEGIN
  BEGIN TRAN
    DELETE FROM Employee_Test WHERE Emp_ID=@ID

   IF(@ID < 10)
   BEGIN
     ROLLBACK
 
     RETURN -- !!!
   END

   COMMIT TRAN
END

Posted 9-Jan-14 0:05am

Kornfeld Eliyahu Peter

Comments

GDdixit 9-Jan-14 6:08am

nothing happened good on doing as u told here .. u only add rerurn ....

Kornfeld Eliyahu Peter 9-Jan-14 6:12am

So? I can't understand you!
Adding return after rollback is essential (and I also removed ;, that important too!), otherwise also commit will hit and drop SQL into an unstable state (for this SP at least).