Object calling best practice

Question

0.00/5 (No votes)

See more:

Hi, may be this question already has been asked but I am still confused in this. Say I have a class named A which contains some properties, a method to initialize its property, a method to save the object.
then what is best practise to call the save method of the object?
this

C#

A objA = new objA();
objA.Name = "abc";
objA.Address= "xyz";
objA.Save();

OR

C#

A objA = new objA();
objA.Name = "abc";
objA.InitializeProperties("abc", "xyz");
objA.Save()

and suppose another class named B which contains other class object as private property.
When I call B.Update, the following method is executed. in this scenario which practice is better?

C#

public class B
{
 public string Name{get;set;}
 public string Address{get;set;}

 private OtherClass otherClassObject {get;set;}

 private void MappObject(ref OtherClass otherClassObject)
{
otherClassObject.Name = this.Name;
otherClassObject.Address= this.Address;
}

public void Update()
{
 this.MappObject(this.otherClassObject)
otherClassObject.Update();
}
}

Posted 20-Aug-13 2:40am

Faisalabadians

Updated 20-Aug-13 3:29am

v2

Add a Solution

Comments

ZurdoDev 20-Aug-13 8:41am

Go with the first way.

3 solutions

Solution 3

First approach should be a good approach.According to you say there is a class named A with mentioned properties and methods.Then i can initialize the object of that particular class by

C#

A objA = new A()
{
    Name="abc",
    Address="xyz"
};
objA.Save();

or else you can go for the above solution1 approach.

Posted 20-Aug-13 3:40am

Jitendra Sabat

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2013-08-20T03:26:00

Solution 2

The second method has redundance and should be avoided.
Both first and second method allow a possibly 'uninitialised' object to be saved.
I would define a constructor the way OriginalGriff suggested, in order to put the object in a initialized state on its very creation.

Posted 20-Aug-13 3:26am

CPallini

Comments

fjdiewornncalwe 20-Aug-13 11:39am

+5.

OriginalGriff · Accepted Answer · 2013-08-20T02:48:00

Solution 1

I'd go with the first way, or create a constructor:

C#

public A(string name, string address)
   {
   Name = name;
   Address = address;
   }
...
A objbA = new objA("abc", "xyz");
objA.Save();

Posted 20-Aug-13 2:48am

OriginalGriff

Comments

CPallini 20-Aug-13 9:22am

5.

fjdiewornncalwe 20-Aug-13 11:40am

5