It only generates the same number or characters

Question

0.00/5 (No votes)

See more:

I'm trying to generate a random password but it always prints the same number?!?

const characters = ["A","B","C","D","E","F","G","H","I","J","K","L","M","N","O","P","Q","R","S","T","U","V","W","X","Y","Z","a","b","c","d","e","f","g","h","i","j","k","l","m","n","o","p","q","r","s","t","u","v","w","x","y","z", "0", "1", "2", "3", "4", "5", "6", "7", "8", "9","~","`","!","@","#","$","%","^","&","*","(",")","_","-","+","=","{","[","}","]",",","|",":",";","<",">",".","?",
"/"];
let passElOne = document.getElementById("pass1");
let passElTwo = document.getElementById("pass2");

function generatePass()
{
   
        let randomChar = Math.floor(Math.random() * characters.length)
        let newChar = characters[randomChar]
       
    
        let randomPassword = ""
        for(i = 0; i < 15; i++)
        {
            randomPassword += newChar;
        }
        passElOne.textContent = randomPassword;
   
}

What I have tried:

I'm pretty limited on my javascript skills since I'm learning this language the only that I try is to write some if else conditions but it don't work

Posted 14-Jan-23 4:33am

oceanotrash

Updated 15-Jan-23 23:31pm

Add a Solution

3 solutions

Solution 3

Lets see if you can figure out this one :)

JavaScript

[...Array(40)].map(e=>~~(Math.random()*40))

Posted 15-Jan-23 23:31pm

M@dHatter

Solution 2

Or you can use crypto lib built into browser

JavaScript

function bytestohex(bytes) {
    var hexstring='', h;
    for(var i=0; i<bytes.length; i++) {
        h=bytes[i].toString(16);
        if(h.length==1) { h='0'+h; }
        hexstring+=h;
    }   
    return hexstring;
}

bytestohex(window.crypto.getRandomValues(new Uint8Array(15)));

Posted 15-Jan-23 23:16pm

M@dHatter

Comments

Richard Deeming 16-Jan-23 5:22am

👍 Pretty good browser support too:
Crypto.getRandomValues() - Web APIs | MDN[^]

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2023-01-14T04:41:00

JavaScript

for(i = 0; i < 15; i++)
{
    randomPassword += newChar; // add the same character each time
}

You are adding 15 of the same character to your password. You need to generate a new random character each time round the loop:

JavaScript

for(i = 0; i < 15; i++)
{
    let randomIndex = Math.floor(Math.random() * characters.length)
    randomPassword += characters[randomIndex];
}

It only generates the same number or characters

3 solutions

Solution 3

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us