What should I do in “data type mismatch in criteria expression”

Question

1.00/5 (1 vote)

See more:

Imports System.Data
Imports System.Data.OleDb
Public Class Editmember
Dim dr As OleDbDataReader
Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

Dim dr As OleDbDataReader
If Len(Trim(ComboBox6.Text)) = 0 Then
MessageBox.Show("Please Enter Members Registration ID ", "input Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
Exit Sub
End If

Try
cmd.CommandText = "select * From [NewMember] where [ID] ='" & Convert.ToInt32(ComboBox6.Text) & "'"
cmd.Connection = con
con.Open()

dr = cmd.ExecuteReader()
If dr.Read() Then
TextBox9.Text = ("[First name]")
TextBox2.Text = ("[Last name]")
DateTimePicker1.Text = ("[DOB]")
TextBox3.Text = ("[Mobile]")
ComboBox1.Text = ("[Gender]")
TextBox4.Text = ("[Email]")
TextBox5.Text = ("[Occupation]")
TextBox6.Text = ("[Address]")
ComboBox2.Text = ("[Membership]")
TextBox7.Text = ("[Amount]")
ComboBox3.Text = ("[AmtStatus]")
TextBox8.Text = ("[PendingAmt]")

DateTimePicker2.Value = ("[StartDate]")

DateTimePicker3.Value = ("[EndDate]")
ComboBox4.Text = ("[TrainerName]")
ComboBox5.Text = ("[Facility]")
Else
MessageBox.Show("Record not found")
End If

Catch ex As Exception

MsgBox(ex.Message)
Finally

con.Close()

End Try
End Sub

When i press the search button it displays output data type mismatch in criteria expression ?

What I have tried:

Tried changing the values and display options

Posted 10-Jun-21 4:50am

Sean Chikobvu

Updated 10-Jun-21 5:33am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2021-06-10T05:33:00

Couple of things:
1) Never use Convert methods for user input: if they mistype - and they will, often - the Convert methods crash your app or (in your case) emit a pretty useless error message directly to the user.
Instead, use int.TryParse[^] and it's related method, and do "proper" error reporting so he knows what is happening.

2) Do yourself a favour, and stop using Visual Studio default names for everything - you may remember that "TextBox9" is the users first name today, but when you have to modify it in three weeks time, will you then? Use descriptive names - "tbFirstName" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbFirstName" in three keystrokes, where "TextBox9" takes thinking about and 8 keystrokes...

3) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Fix that throughout your app, and the problem you have noticed will go away at the same time.