Collection was modified; enumeration operation may not execute. At foreach

Question

0.00/5 (No votes)

See more:

i try to fetch the data (funds data) and filter the results with its balance

but this error appear :

System.InvalidOperationException: 'Collection was modified; enumeration operation may not execute.'

at <pre> foreach (account_funds f in account_Funds)

What I have tried:

public void loadFunds()
      {


          mrsalesdbEntities DB01 = ConnectionTools.OpenConn();
          var account_Funds = DB01.account_funds.Where(u => u.accfunds_CustodyType == 1 && u.r_branche_ID == BasicVars.Branche).ToList();
          foreach (account_funds f in account_Funds)
          {
              if (trsBalance(f.accfunds_ID) == 0) { account_Funds.Remove(f); }
          }
          account_fundsBindingSource.DataSource = account_Funds;
          NameInput.EditValue = account_Funds.FirstOrDefault().accfunds_ID;

      }

public decimal trsBalance(int ID)
       {
           decimal blc = 0;
           if (ID != 0)
           {
               var DB1 = ConnectionTools.OpenConn();
               var account = DB1.account_items.Where(u => u.accitem_TrsID == ID && u.accitem_TrsType == 0 && u.accitem_AccID == 60);
               decimal debet = Convert.ToDecimal(account.Sum(s => s.accitem_Debit));
               decimal credit = Convert.ToDecimal(account.Sum(s => s.accitem_Credit));
               blc = debet - credit;
           }
           return blc.GetDecimalParts();
       }

Posted 7-Nov-19 0:10am

Golden Basim

Updated 8-Nov-19 8:22am

Add a Solution

3 solutions

Solution 3

Rather than executing

account_Funds.Remove(f);

keep a collection of all the items you want to remove;

var toRemove = new List<account_funds>();
foreach (account_funds f in account_Funds)
          {
              if (trsBalance(f.accfunds_ID) == 0) { toRemove.Add(f); }
          }

after the foreach loop you can then remove the items in toRemove from account_Funds.

Posted 7-Nov-19 0:20am

F-ES Sitecore

Solution 2

You cannot enumerate a collection in a foreach block and modify the collection in the same block.
Usually the solution is to get back to a plain old index iteration, starting from the end of the collection. In clear, change

C#

foreach (account_funds f in account_Funds)
{
   if (trsBalance(f.accfunds_ID) == 0) { account_Funds.Remove(f); }
}

to

C#

for (int i = account_Funds.Count - 1; i > -1; --i)
{
   var f = account_Funds[i];
   if (trsBalance(f.accfunds_ID) == 0) { account_Funds.RemoveAt(i); }
}

Posted 7-Nov-19 0:20am

phil.o

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2019-11-08T08:23:00

Solution 4

Another option:

C#

account_Funds.RemoveAll(f => trsBalance(f.accfunds_ID) == 0);

List<T>.RemoveAll(Predicate<T>) Method (System.Collections.Generic) | Microsoft Docs[^]

Posted 8-Nov-19 8:23am

Richard Deeming