Error while uploading the image

Question

0.00/5 (No votes)

See more:

Register.aspx

C#

string chkUser = "Select * FROM [User] where Email='" + TextBoxEmail.Text + "'";
       dt = dbClass.ConnectDataBaseReturnDT(chkUser);
       if (dt.Rows.Count > 0)
       {

       }
       else
       {
           if (UploadUserPhoto.PostedFile != null)
           {
               string myMap = MapPath("~/").ToLower();
               Random r = new Random();
               int next = r.Next();
               string ImageName = UploadUserPhoto.PostedFile.FileName;
               // ToSaveImageName = DateTime.Now.ToString("yyyy-MM-ddTmm:hh:ss");
               //ToSaveImageName.Replace('-', '1');
               //ToSaveImageName.Replace(':', '2');
               //Directory.CreateDirectory(myMap + ToSaveImageName);
               sImageFileExtension = ImageName.Substring(ImageName.LastIndexOf(".")).ToLower();
               if (sImageFileExtension == ".gif" || sImageFileExtension == ".png" || sImageFileExtension == ".jpg" || sImageFileExtension == ".jpeg" || sImageFileExtension == ".bmp")
               {
                   string ImageSaveURL = myMap + "UserImage/" + next + sImageFileExtension;
                
   
                   {
                       UploadUserPhoto.PostedFile.SaveAs(ImageSaveURL);
                       string RegisterQuery = "INSERT INTO [User] (Email,Password,Name,Country,Description,ImageName) VALUES('" + TextBoxEmail.Text + "','" + TextBoxPassword.Text + "','" + TextBoxName.Text + "','" + TextBoxCountry.Text + "','" + TextBoxComment.Text + "','" + next + sImageFileExtension + "')";
                       dbClass.ConnectDataBaseToInsert(RegisterQuery);
                       Response.Redirect("~/Login.aspx");
                   }
                                 }
               else
               {
               }
           }
           else
           {
               ToSaveImageName = "No";
               sImageFileExtension = "Image";
           }

       }

I have registerpage. When I upload image is successfully uploaded but I allow nulls in my database table so when I am not uploading image then error comes:
StartIndex cannot be less than zero. in this line:

C#

sImageFileExtension = ImageName.Substring(ImageName.LastIndexOf(&quot;.&quot;)).ToLower();

Posted 13-Apr-11 22:50pm

om56

Updated 13-Apr-11 22:54pm

Sandeep Mewara

v2

Add a Solution

Comments

Pong D. Panda 14-Apr-11 5:15am

A lot of bad programming practice and very prone to sql injection.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pong D. Panda · Answer 1 · 2011-04-13T23:08:00

Try this code. You should check if the filename has a value and contains '.'

C#

sImageFileExtension = ImageName.Contains('.') ? imageName.Substring(ImageName.LastIndexOf('.')) : "";

Also, you should not use that kind of approach on inserting or doing sql transaction. If someone put something like this

'; drop table User; --

on your TextBoxEmail.Text.

The resulting query will be

Select * FROM [User] where Email=''; drop table User; --'

Then you're doomed!

Good luck!

Sandeep Mewara · Answer 2 · 2011-04-13T22:57:00

Solution 1

Just wrap the error line(+ all code related to image) and check if file is there or not. If so, move ahead.

C#

if(UploadUserPhoto.HasFile)
{
 ... 
  sImageFileExtension = ImageName.Substring(ImageName.LastIndexOf(".")).ToLower();

... 
...
...
}

Details about the property used here: FileUpload.HasFile Property[^]

Posted 13-Apr-11 22:57pm

Sandeep Mewara

Comments

Manfred Rudolf Bihy 14-Apr-11 7:05am

My 5!