How do I print this-

Question

1.00/5 (1 vote)

See more:

______4
____4 3 4
__4 3 2 3 4
4 3 2 1 2 3 4
__4 3 2 3 4
___ 4 3 4
______4

Write a C++ program to obtain the above double pyramid.
'_' - this indicates space, that's how it is a pyramid.

What I have tried:

#include <iostream>

using namespace std;

int main()
{
     int i,j;
     for(i=4; i>=1; i--){
        for(j=1; j<=i; j++){
           cout<<" ";
        }
     for(int j=4; j>=i; j--){
        cout<<j;
     }
          for( j=i+1; j<=4; j++){
            cout<<j;
            cout<<'\n';
          }
          for(i=2; i<=4; i++){
            for(j=1; j<i; j++){
                cout<<j;
            }
            for(j=1+i; j<=4; j++){
                cout<<j;
                cout<<'\n';
            }
          }

     }
      return 0;
}

I have tried this and I have a feeling that I have done some really stupid mistake. Please help me.

Posted 7-Sep-18 3:52am

Member 13837433

Updated 7-Sep-18 9:14am

Add a Solution

2 solutions

Solution 1

Start by indenting your code properly, or, if you are going to use the execrable 1TB then at least consistently:

int main(){
    int i,j;
    for(i=4; i>=1; i--){
        for(j=1; j<=i; j++){
            cout<<" ";
            }
        for(int j=4; j>=i; j--){
            cout<<j;
            }
        for( j=i+1; j<=4; j++){
            cout<<j;
            cout<<'\n';
            }
        for(i=2; i<=4; i++){
            for(j=1; j<i; j++){
                cout<<j;
                }
            for(j=1+i; j<=4; j++){
                cout<<j;
                cout<<'\n';
                }
            }
        
        }
    return 0;
    }

And now you can see what you are doing. And the first thing that springs to mind is this: you have two loops, both altering i and one of them is inside the other ... so your code never exits.

Posted 7-Sep-18 4:04am

OriginalGriff

Comments

jeron1 7-Sep-18 10:44am

OG wrote: "1TB"

I never know what that format was called, I just cringe when I see it. Apparently the format I favor is called Allman (I never knew that either), I attribute that to the fact that I'm a big Allman Bros. fan! LOL

OriginalGriff 7-Sep-18 11:31am

I agree - difficult to read, that one.
I prefer Whitesmiths:

if (a)
   {
   b = c;
   }

jeron1 7-Sep-18 11:49am

Not bad, I never realized how many formats have been categorized.

Rick York 7-Sep-18 13:48pm

Sometime you should have a look at the UniversalIndentGUI. It's a front end for some code "beautifiers." It has about ten different styles of indentation and it's fairly customizable. It doesn't fully handle how I like to do things but it's close.

jeron1 7-Sep-18 15:46pm

Interesting, thanks.

Rick York 7-Sep-18 12:01pm

I am not sure what it's called but I prefer this one:

if( a )
{
    b = c;
}

OriginalGriff 7-Sep-18 12:04pm

That's Allman - it's a bit too "pascal" for my taste. I prefer Whitesmiths because it indents the brackets the same as the content - which is more consistent with a single statement.

Rick York 7-Sep-18 13:45pm

I used to do that but I grew to dislike it. I think the braces should be indented at the same level as their "container." The only real difference from the OP's style is the position of the opening brace. It's just a different point of view I guess.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2018-09-07T09:14:00

Lets guess the output have too many lines

C++

for( j=i+1; j<=4; j++){
    cout<<j;
    cout<<'\n'; // Remove this line
}
cout<<'\n'; // and put it there

Your program is complicated and for size 4 only.
a little analyze should help to get it better. The diamond have a vertical and horizontal symmetry, all is around the center (1)

C++

Size Rows Cols Center
 1    1    1    0,0
 2    3    3    1,1
 3    5    5    2,2
 4    7    7    3,3

Should not be complicated to store the Size in a variable and reduce Rows, Cols and Center.
You can notice that all '2' are at a distance of 1 col or 1 row from center.
'3' are 1 step further: distance in rows + distance in cols give you the value at position.
if value is more the the size, print a space.
I let you fill the holes as an exercise.

Advice:
- Learn one or more analyze methods, E.W. Djikstra/N. Wirth Stepwize Refinment/top-Down method is a good start.
Structured Programming.pdf[^]
https://en.wikipedia.org/wiki/Top-down_and_bottom-up_design[^]
https://en.wikipedia.org/wiki/Structured_programming[^]
https://en.wikipedia.org/wiki/Edsger_W._Dijkstra[^]
https://www.cs.utexas.edu/users/EWD/ewd03xx/EWD316.PDF[^]