Welcome to the Lounge

Pete O'Hanlon wrote:

This is not just a C# case, but has implications on the thought processes of developers in any OOP language as well as procedural languages

Pete O'Hanlon wrote:

his argument completely fails to address isusues such as cyclomatic complexity.

DateTime dob;
if (!DateTime.TryParse(tbDOB.Text, out dob))
   {
   ... report problem to user ...
   return;
   }
double itemPrice;
if (!Double.TryParse(tbItemPrice.Text, out itemPrice))
   {
   ... report problem to user ...
   return;
   }
...

DateTime dob;
if (!DateTime.TryParse(tbDOB.Text, out dob))
   {
   ... report problem to user ...
   }
else
   {
   double itemPrice;
   if (!Double.TryParse(tbItemPrice.Text, out itemPrice))
      {
      ... report problem to user ...
      }
   else
      {
      ...
      }
   }

int function(...){
  bool condition_ok = true;
  int returnvalue = ERR_OK;
  if (condition_ok) {
    // do phase 1
    if (failed) then {
      condition_ok = false;
      returnvalue = errcode1;
    }
  }

  if (condition_ok) {
    // do phase 2
    if (failed) then {
      condition_ok = false;
      returnvalue = errcode2;
    }
  }
  ...
  return returnvalue;
}

var validator = new MyValidator();
if (validator.Validate(objectToValidate).IsValid)
{
   // Whatever..
}

return;

den2k88 wrote:

every function should validate its input parameters and the data it has access to before using them

Brent Jenkins wrote:

Your method should really focus on what it's supposed to be doing, not extraneous tasks.

den2k88 wrote:

I may have a parameter that should be != 0 but to the current method it does not matter, or on the other hand each other method would accept a != 0 but he needs it to be strictly > threshold.