|
Yeah I think you're right, but they'll do it with the excuse of saving some rare species of slime or to save the environment or some such crap.
New version: WinHeist Version 2.1.1 new web site.
When you are dead you don't know it, it's only difficult for others.
It's the same when you're stupid.
|
|
|
|
|
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out...
This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
|
|
|
|
|
It does not add any obvious value over the standard way.
It does add the obvious disadvantage that it is different from those in all the textbooks and online examples. It would also incur an overhead, introduce the chance of bugs, and increase overall complexity.
But does it actually show a real MessageBox? Or is it something similar, with additional stuff? What does t.Result.LockMessage contain? Whotsitstype?
If it is simply the Windows MessageBox, then it is adding more costs than value
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
My point exactly... plus, they use the Fluent design (method chaining) EVERYWHERE.
I agree - there's not a whole lot of added value, IMHO.
If it's not broken, fix it until it is
|
|
|
|
|
What a fool.
Everyone knows you should use ShowDialog() on MessageBoxes
|
|
|
|
|
That's awful. Much easier to just write (and faster to execute) as:
MessageBox (hWnd,
(LPCTSTR) "Warning"
(LPCTSTR) "Please open the state procedure with a lock."
MB_ICONINFORMATION | MB_OK);
The heck with localization.
/ravi
|
|
|
|
|
Ravi Bhavnani wrote: The heck with localization. Yes, but it's so much fun, Ravi...
Been there, done that, got the UNICODE/UTF-8 scars to prove it.
Software Zen: delete this;
|
|
|
|
|
Coder For Hire wrote: I've been working at this place about a month now, and EVERYTHING is way too abstracted out...
Are you being required to write sh*t like that, too? If so, then leave.
|
|
|
|
|
Already looking
If it's not broken, fix it until it is
|
|
|
|
|
You're put off pretty quickly I have to say, this is really just superficial. Looks like the messages are localized, but other than that doesn't seem unnecessarily verbose.
Wout
|
|
|
|
|
There is no good reason to code a messagebox like that. I'm put off because, like I said, EVERYTHING in this app is way over cooked. It takes FOREVERY to find something, and then FOREVER to make a small change.
If it's not broken, fix it until it is
|
|
|
|
|
Maybe they can switch one compile time flag or library and... Voila! it works on Mac or Linux?
Create your own wrapper/adpater on any vendor specific API.
|
|
|
|
|
You think that's bad, how about working with a class named VirtualEthernetCardDistributedVirtualPortBackingInfo ?
|
|
|
|
|
This reminds me of my current workplace. All the C++ class are heavily templated(The one I am working on, 20 data members are generic), even integer type are templated(can use int32 or int64 ). Very versatile but very difficult to find and read code because intellisense is not working as it does not know the type used; F12 is not working. Development time is impacted. PITA everyday!
|
|
|
|
|
Yeah that's pretty horrible. I hate people over-abstracting... nooooooooooo point.
|
|
|
|
|
Navigator
.PrepareMessageBox(
TheApp
.Messages
.ErrorWarningMessages
.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2,
stateProcedure.StateDescription,
t.Result.LockMessage
)
.UseButtons(MessageBoxOptions.OK).Show();
If I were to deal with code like this, the first thing I would do is sprinkle newlines everywhere...
|
|
|
|
|
Is this guy channelling Salvador Dali or what?
Software Zen: delete this;
|
|
|
|
|
But ... but it's so FLEXIBLE!
|
|
|
|
|
Never trust atoms: they make up everything.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
So that's why Intel Atom wasn't a preferred processor after all.
The sh*t I complain about
It's like there ain't a cloud in the sky and it's raining out - Eminem
~! Firewall !~
|
|
|
|
|
Not enlightenment.
|
|
|
|
|
At the risk of being pedantic what about sub-atomic particles? Logically atoms can't make them.
How do you know so much about swallows? Well, you have to know these things when you're a king, you know.
modified 31-Aug-21 21:01pm.
|
|
|
|
|
And what about the "empty" space between the sub-atomic particles?
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
That's where programmers dreams (reference[^]) come from
How do you know so much about swallows? Well, you have to know these things when you're a king, you know.
modified 31-Aug-21 21:01pm.
|
|
|
|
|
And what about quarks[^] then? Neither atoms nor sub-atomic particles can make them.
You have just been Sharapova'd.
|
|
|
|