C# Discussion Boards - CodeProject

22-Mar-07 3:37

hey,

When I'm trying to delete one of my created files. My program saids it is in use (by himself) but that's because the program is to fast. When I let him wait 10sec the lock is gone... But that not zo good if you have to delete 20-50 files.

How can I unlock them automatically?

Thx!!!

Stefan Troschuetz22-Mar-07 3:58

Stefan Troschuetz

22-Mar-07 3:58

How are the files created? Did you maybe forgot to call close on some streams?

Ollie198622-Mar-07 4:01

22-Mar-07 4:01

There are all created with:

new DirectoryInfo(Path.GetDirectoryName(path)).Create();
StreamWriter writer = new StreamWriter(path);
writer.WriteLine(content);
writer.Close();

But than the locks are fine. But after all the files are created I zip them with "SharpZipLib" and is places locks that last realy long...

thx

Christian Graus22-Mar-07 4:02

22-Mar-07 4:02

Then there's a bug in the zip library, or in how you're using it.

Christian Graus - Microsoft MVP - C++
Metal Musings - Rex and my new metal blog
"I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )

Ollie198622-Mar-07 4:04

22-Mar-07 4:04

I don't think so everything is closed:

using System;
using System.Collections.Generic;
using System.Text;
using System.IO;
using System.Diagnostics;
using System.Threading;
using log4net;
using ICSharpCode.SharpZipLib.Zip;
using System.Collections;
using System.Collections.Specialized;

namespace InterfaceCollector.domain.DAL
{
class Zip
{
private string destination;
private readonly ILog log = LogManager.GetLogger(typeof(Zip));
static Hashtable excludeDirs = new Hashtable();
static string startFolder = String.Empty;
static string outputZipPath = String.Empty;
static string password = String.Empty;

public Zip() {}
static private Zip instance = null;
static public Zip Instance
{
get
{
if (instance == null)
instance = new Zip();
return instance;
}
}

public void ZipIt(string Path,string password)
{
log4net.LogManager.Shutdown();
try
{

ArrayList ar = GenerateFileList(Path); // generate file list
// find number of chars to remove from orginal file path
int TrimLength = (Directory.GetParent(Path)).ToString().Length;
TrimLength += 1; //remove '\'
FileStream ostream = null;
byte[] obuffer;
ZipOutputStream oZipStream = new ZipOutputStream(System.IO.File.Create(Destination)); // create zip stream
if (password != String.Empty) oZipStream.Password = password;
oZipStream.SetLevel(9); // 9 = maximum compression level
ZipEntry oZipEntry;

DateTime timeStap = DateTime.Now;
string output = "";
int lenghtWrittenString = 0;
double percent = 1;
int countFiles = 0;
foreach (string Fil in ar) // for each file, generate a zipentry
{
countFiles++;
percent = countFiles * 100 / ar.Count;
//Display % on progressScreen
if (timeStap <= DateTime.Now)
{
timeStap = DateTime.Now.AddMilliseconds(1000);
ApplicationDirector.Instance.removeCharachtersFromProgressScreen(lenghtWrittenString);
if (percent < 100.0)
{
output = "\r\nCreating zip-file (" + percent + "%)";
ApplicationDirector.Instance.writeToGui(output);
}
lenghtWrittenString = output.Length;
}

oZipEntry = new ZipEntry(Fil.Remove(0, TrimLength));
oZipStream.PutNextEntry(oZipEntry);

if (!Fil.EndsWith(@"/")) // if a file ends with '/' its a directory
{
ostream = File.OpenRead(Fil);
obuffer = new byte[ostream.Length]; // byte buffer
ostream.Read(obuffer, 0, obuffer.Length);
oZipStream.Write(obuffer, 0, obuffer.Length);
}
}
ApplicationDirector.Instance.removeCharachtersFromProgressScreen(lenghtWrittenString);
ApplicationDirector.Instance.writeToGui("\r\nCreating zip-file (Completed)");
oZipStream.Finish();
oZipStream.Close();
}
catch (Exception ex)
{
ApplicationDirector.Instance.writeToGui("Error during zipping.");
Logger.Instance.ExtraInfo.Add("Zip-File nog created" + ex);
}
}
private static ArrayList GenerateFileList(string Dir)
{
ArrayList mid = new ArrayList();
bool Empty = true;
foreach (string file in Directory.GetFiles(Dir)) // add each file in directory
{
mid.Add(file);
Empty = false;
}

if (Empty)
{
if (Directory.GetDirectories(Dir).Length == 0) // if directory is completely empty, add it
{
mid.Add(Dir + @"/");
}
}
foreach (string dirs in Directory.GetDirectories(Dir)) // do this recursively
{
// set up the excludeDir test
string testDir = dirs.Substring(dirs.LastIndexOf(@"\") + 1).ToUpper();
if (excludeDirs.Contains(testDir))
continue;
foreach (object obj in GenerateFileList(dirs))
{
mid.Add(obj);
}
}
return mid; // return file list
}

public string Destination
{
get { return destination; }
set
{
string path = Path.GetDirectoryName(value);
path = path + "Agfa Zip - "+Path.GetFileNameWithoutExtension(value) + "\\" + Path.GetFileName(value);
destination = path;
Directory.CreateDirectory(Path.GetDirectoryName(destination));
}
}
}
}

Ollie198622-Mar-07 4:06

22-Mar-07 4:06

But you have to know, he releases the locks It just takes to long Frown | :(

Christian Graus22-Mar-07 4:08

22-Mar-07 4:08

That means, something is NOT closed, but it is eventually garbage collected.

Ollie198622-Mar-07 4:14

22-Mar-07 4:14

that works thx!

GC.Collect();
GC.WaitForPendingFinalizers();

Christian Graus22-Mar-07 4:51

22-Mar-07 4:51

That's a hack. You should instead figure out what's going wrong with the zip library.

Ollie198622-Mar-07 4:52

22-Mar-07 4:52

If we have time at the end :->

Christian Graus22-Mar-07 5:04

22-Mar-07 5:04

Well, I'd think if it's a problem in the framework, then others will have encountered it. If you find nothing on google, it's a bug in your code. 'If we have time at the end', means, we're going to leave it broken. At least, that's what I'd expect it to mean.

Vasudevan Deepak Kumar22-Mar-07 5:42

Vasudevan Deepak Kumar

22-Mar-07 5:42

In the TaskManager Extension application, there is a way to force close handle. If we can have that done, the problem is solved.

TaskManager Extension at: http://www.codeproject.com/system/Task_Manager_Extension.asp[^]

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

Ollie198622-Mar-07 6:46