C# Discussion Boards - CodeProject

Tridip Bhattacharjee9-Mar-17 21:52

9-Mar-17 21:52

i am looking for guidance or best practice to review my code or review my colleague code working in same company.

two way i guess exist to review code. one is manual process and one should be automated process where people may use various tools to review code.

so please discuss two different process called manually review code and automated way review code using tools.

please guide me in details. thanks

tbhattacharjee

Re: How to review dotnet code

Pete O'Hanlon9-Mar-17 22:22

Pete O'Hanlon

9-Mar-17 22:22

For automatic reviews, you can use FxCop and StyleCop. For manual reviews, you really should search the web for manual review processes, read them and agree with your colleagues on the best approach to conduct reviews; that's partly going to depend on your code cycle workflow (do you review pre commit to Source Control, or do you do it post commit and in a separate review stage for instance). We can't really help you that much on that side.

This space for rent

Re: How to review dotnet code

Gerry Schmitz10-Mar-17 5:25

Gerry Schmitz

10-Mar-17 5:25

"Review" for what?

How do you measure "success"?

Machine learning involves calculating "distances" from some "ideal".

You need to "classify" your problem (i.e. what are the "measures") before you can achieve anything meaningful.

Unless you actually have some "good code" as a reference and for "training" purposes, you will get nowhere.

"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal

What control can add pictures and text horizontally ?

Member 24584679-Mar-17 19:53

Member 2458467

9-Mar-17 19:53

Do you know what control can add photos and text horizontally as an attached file, when clicking on add button will put the image into the box, if the cell does not have image, insert the image in the horizontal box, if any. Horizontal cell is inserted into the new cell line. You see the attached image file. [IMG]http://imagizer.imageshack.com/img922/2316/JSa9oK.jpg[/IMG]

Re: What control can add pictures and text horizontally ?

Ralf Meier9-Mar-17 21:10

Ralf Meier

9-Mar-17 21:10

There is no ready-made Control which does exactly what you want.
I suggest you create a UserControl which has for example a Button and a ListView (and perhaps something more) and you write the code needed for your requirement ...

Re: What control can add pictures and text horizontally ?

xiecsuk10-Mar-17 0:01

xiecsuk

10-Mar-17 0:01

If it is a website you are building, have a look at Metro UI as a framework. They have some very nice controls for doing what you describe.

Re: What control can add pictures and text horizontally ?

Gerry Schmitz10-Mar-17 5:53

Gerry Schmitz

10-Mar-17 5:53

A StackPanel with the Orientation set to Horizontal; or a WrapPanel.

"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal

Re: What control can add pictures and text horizontally ?

Member 245846712-Mar-17 18:26

Member 2458467

12-Mar-17 18:26

Could you tell me I know StackPanel and WrapPanel it belongs to Visual Studio ? I did not find StackPanel and WrapPanel in Visual Studio.

Re: What control can add pictures and text horizontally ?

Pete O'Hanlon12-Mar-17 21:23

Pete O'Hanlon

12-Mar-17 21:23

They are used in XAML applications such as ones built by WPF.

This space for rent

Re: What control can add pictures and text horizontally ?

Eddy Vluggen13-Mar-17 1:51

Eddy Vluggen

13-Mar-17 1:51

In WinForms, use a normal panel. Drop some smaller panels in there with align=left, and it would fill from left to right.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

c# out parameter must be assigned.... I don't see the logic [solved]

User 110609799-Mar-17 8:48

User 11060979

9-Mar-17 8:48

Dear Experts
Following not a big Thing, I'm more asking where I'm missing the logic.

a.) Example which compiles

public void OutExample_03(out int outValue)
{
    outValue = 0;
    try
    {
    }
    catch (Exception excpt)
    {
        Debug.WriteLine(excpt.Message);
    }
}

b.) Example will not compile.
Message: The Out Parameter 'outValue' must be assigned before control leaves the current method.

public void OutExample_04(out int outValue)
{
    try
    {
        outValue = 0;
    }
    catch (Exception excpt)
    {
        Debug.WriteLine(excpt.Message);
    }
}

Does the Compiler assume for b.) that also enter the "try section" could not happen?

Thank you very much for your comments in advance.

[Edit]
VS 2013 Express.

modified 19-Jan-21 21:04pm.

Re: c# out parameter must be assigned.... I don't see the logic

Richard Deeming9-Mar-17 10:35

Richard Deeming

9-Mar-17 10:35

There's a thread discussing this over on StackOverflow:
c# - Why out parameters are required to be initialized inside both try and catch sections? - Stack Overflow[^]

Basically, the compiler assumes that the try block could fail at any point, including before the assignment happens. As a result, the value is not definitely assigned on all paths.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: c# out parameter must be assigned.... I don't see the logic

User 110609799-Mar-17 10:38

User 11060979

9-Mar-17 10:38

Thank you very much for this. I read that link already, but a confirmation from you helped a lot.

modified 19-Jan-21 21:04pm.

Re: c# out parameter must be assigned.... I don't see the logic

User 110609799-Mar-17 20:28

User 11060979

9-Mar-17 20:28

Again me

On the other hand

public void OutExample_03(out int outValue)
{
    DoAnythingBefore();
    outValue = 0;
}

does also compile, so I really don't see the logic why try catch will be handled Special.
It is like it is Smile | :)

modified 19-Jan-21 21:04pm.

Re: c# out parameter must be assigned.... I don't see the logic

Ralf Meier9-Mar-17 21:14

Ralf Meier

9-Mar-17 21:14

Because at Compile-Time the Compiler doesn't know if the Try-Cath COULD be succesful or not. It only recognized that there is a possibility for not-assigning the variable ...

Re: c# out parameter must be assigned.... I don't see the logic

Richard MacCutchan9-Mar-17 21:19

Richard MacCutchan

9-Mar-17 21:19

Because, as already explained, the try block can terminate before the variable has its value assigned. In this case the catch part will be called and the method returns, but the value of outValue is indeterminate.

In the case above it is assumed (by the compiler) that one of two things will happen:
1. The method completes successfully, in which case outValue will have been correctly assigned.
2. An exception occurs, in which case the method will not complete, so the value of outValue does not matter.

Re: c# out parameter must be assigned.... I don't see the logic

Pete O'Hanlon9-Mar-17 21:21

Pete O'Hanlon

9-Mar-17 21:21

Let me give you an example that might clarify it for you.

public void ThisIsaReallyStupidThingToDo(string input, out int value)
{
  try
  {
    if (string.IsNullOrWhiteSpace(input))
    {
      throw new ArgumentNullException($"The value of {nameof(input)} must be set");
    }
    int.TryParse(input, out value);
  }
  catch (Exception ex)
  {
    // Log and consume the exception...
  }
}

So, if you pass in an empty string, value will never be set because you bypass it completely and hit the exception handler. That's why you have to handle value outside the try/catch.

This space for rent

Re: c# out parameter must be assigned.... I don't see the logic

User 1106097910-Mar-17 9:26

User 11060979

10-Mar-17 9:26

Thank you for your Feedback.
Yes all of this I'm aware. But it is not a real Explanation why

{
  outParam= ..
}

vs.

try
{
  // No other code here!
  outParam= ...
  // more code here
}

will be handled different. I don't see a chance that in the sequence "try{ outParam= ..." something strange can happen.

Anyway it is more a philosophical thing not a real Problem.

Thanks again for your Feedback.

modified 19-Jan-21 21:04pm.

Re: c# out parameter must be assigned.... I don't see the logic

Pete O'Hanlon10-Mar-17 10:41

Pete O'Hanlon

10-Mar-17 10:41

It is a real explanation. It's about consistent predictable behaviour. Because the code can cause inconsistent behaviour in the try block, all cases have to be handled consistently. Put it another way, what if the JITter was to reorganize the code inside the try block, you could end up with a situation where things blow up because you allowed an inconsistent behaviour.

This space for rent

Re: c# out parameter must be assigned.... I don't see the logic

User 1106097910-Mar-17 10:47

User 11060979

10-Mar-17 10:47

I Need to think about it. Most probably I'm too much fixed to my thoughts at the Moment.
Thanks
Bruno

modified 19-Jan-21 21:04pm.

Re: c# out parameter must be assigned.... I don't see the logic

Eddy Vluggen10-Mar-17 12:23

Eddy Vluggen

10-Mar-17 12:23

It is not treated different. The compiler does not check if the code-block is doing something usefull. You introduced it, so it probably has a use (take not of post-processing like some code-injecting frameworks).

It merely checks whether each block has a correct flow. What use would it serve to also see if your code-block does throw exceptions, simply to check whether the exception handler "might" fire? Would make compiling a lot slower, since it would be checking a lot.

Now what is the upside of this check? To not run into the warning?

Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Counter not updating file

xiecsuk9-Mar-17 5:34

xiecsuk

9-Mar-17 5:34

I have created the following code

var filename = "wwwroot/Counter/Counter.txt";
var counterStream = new FileStream(filename, FileMode.Open, FileAccess.ReadWrite, FileShare.None);
var reader = new StreamReader(counterStream);
var visits = Convert.ToInt32(reader.ReadLine());
visits = visits + 1;
var writer = new StreamWriter(counterStream);
writer.Write(visits);
counterStream.Dispose();

As you will realise, it is a counter for a website I am building. I am OK down to the line.

visits = visits + 1

Visits does contain one more than is originally stored in Counter.txt. However, the last three lines are not writing anything back to the file. I was expecting it to write a new line in the file, although obviously I want it to replace the original finally. I am at a loss as to why it hasn't. Could someone point me in the right direction, please.

Re: Counter not updating file

Midi_Mick9-Mar-17 5:59

Midi_Mick

9-Mar-17 5:59

You need to position the file pointer to the appropriate place, either by reading all of the existing lines (and keeping only the last one), or by using Stream.Seek to reposition the file pointer back to the beginning before the Write.

Cheers,

Mick
------------------------------------------------
It doesn't matter how often or hard you fall on your arse, eventually you'll roll over and land on your feet.

Re: Counter not updating file

xiecsuk10-Mar-17 0:06

xiecsuk

10-Mar-17 0:06

Counter.txt only contains the one number, the number of visits the site has had. My code reads and updates it OK but the code after that doesn't write it back to replace the one that is there. That's all I want to do; replace the old with the new value.

Re: Counter not updating file

Midi_Mick10-Mar-17 0:25

Midi_Mick

10-Mar-17 0:25

xiecsuk wrote:
That's all I want to do; replace the old with the new value

In which case you need to Seek the stream pointer back to the beginning of the file before the Write

Cheers,

Mick
------------------------------------------------
It doesn't matter how often or hard you fall on your arse, eventually you'll roll over and land on your feet.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.