Click here to Skip to main content

C / C++ / MFC

Re: Good code, wrong result

David Crow5-Oct-09 4:56

5-Oct-09 4:56

As has been suggested before here, you need to trim this code down to just what is absolutely necessary to exhibit the problem.

If you are seeing 209 out of 210 combinations (i.e., one-off bug), check the while() and for() loops to ensure they are running the expected number of times.

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

Re: Good code, wrong result

Waldemar Ork5-Oct-09 23:29

5-Oct-09 23:29

Unfortunately, You all are wrong. The number of combinations has nothing to do with GetNextCombination or "for" loop. The loop "do...while" is needed instead. Here's the code:
do {
                  Total++;
                  cout << "Combination number. " << Total   << endl;
                  for (unsigned i = 0; i < combination.size(); i++)
                        {

                        const Element &element = elements[combination[i]];
                        cout << element.name << ": " << element.chain << endl;

                        }
               }
         while(cb.GetNextComb(combination));
Thank you and,
Take care!

C++ Helper Wanted

MrMcIntyre4-Oct-09 3:48

4-Oct-09 3:48

Hi,

I am looking for someone to help me with a problem I am having creating a Win32 Client and to help me along the way creating windows for the project which is driving me crazy.

If anyone has spare time that could help me quickly that would be great.

Thanks

Andrew

Andrew McIntyre

Re: C++ Helper Wanted

Maximilien4-Oct-09 4:11

4-Oct-09 4:11

A Win32 client for what ?

Can't you simply create a "new" project with a Wizard ? either a dialog based application or a SDI/MDI application ?

This signature was proudly tested on animals.

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 4:20

4-Oct-09 4:20

For my project.

No, I have created a "new" project and went through the wizard already. But I am stuck a quarter through the code.

Andrew McIntyre

Re: C++ Helper Wanted

Michael Schubert4-Oct-09 4:51

Michael Schubert

4-Oct-09 4:51

MrMcIntyre wrote:
But I am stuck a quarter through the code.

A quarter of what code? Your code? The Wizard code? The Da Vinci code?

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 4:54

4-Oct-09 4:54

The source code.

Andrew McIntyre

Re: C++ Helper Wanted

Michael Schubert4-Oct-09 5:08

Michael Schubert

4-Oct-09 5:08

Right.
From you original post (and some of your previous ones) I gather that you are looking for some kind of tutor.

You have several options:
1. Buy some books and teach yourself programming
2. Pay someone to teach you
3. Find someone who would do that for free (highly unlikely although this appears to be your preferred option)
4. Pay someone to write the code for you.
5. ...

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 5:14

4-Oct-09 5:14

No I don't need someone to write the code I need someone that can help me if I get stuck.

Andrew McIntyre

Re: C++ Helper Wanted

Michael Schubert4-Oct-09 5:19

Michael Schubert

4-Oct-09 5:19

MrMcIntyre wrote:
No I don't need someone to write the code I need someone that can help me if I get stuck.

Fair enough. That's exactly what this site is all about. So, why don't you post the relevant part of your code with a description of what it is supposed to do and where you are stuck?

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 5:23

4-Oct-09 5:23

Thanks.

#include "MyProject.h"<br />
<br />
#define MAX_LOADSTRING 100<br />
<br />
//Global Variabales:<br />
HINSTANCE hInst;							// Current Instance<br />
TCHAR szTitle[MAX_LOADSTRING];				// The Title Bar Text<br />
TCHAR szWindowClass[MAX_LOADSTRING];		// The Main Window Class Name<br />
<br />

Well, I am trying to get the code to create a Win32 client, with certain dimensions and to centre it to screen, but I have missed half of the code out because I have got stuck.

Andrew McIntyre

Re: C++ Helper Wanted

Michael Schubert4-Oct-09 5:34

Michael Schubert

4-Oct-09 5:34

What kind of client?
I suggest you tell us what your app is supposed to do and how you want to implement it (MDI/SDI/Dialog based, etc.).

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 5:39

4-Oct-09 5:39

Well, its a Win32 Client.

Well, its hard to explain, but the application allows family and friends to connect with each other, share photos, videos, music and games in a new way. At the moment I just concentrating on the client window, and the dialog's when users launch the application.

It's not really an instant messaging, its more of a communication and sharing platform where people can upload, watch and share all their multimedia and profiles.

Andrew McIntyre

Re: C++ Helper Wanted

Maximilien4-Oct-09 5:58

4-Oct-09 5:58

MrMcIntyre wrote:
Well, its hard to explain, but the application allows family and friends to connect with each other, share photos, videos, music and games in a new way. At the moment I just concentrating on the client window, and the dialog's when users launch the application.

oh boy ...

Ok, take a big breath ... I think you are aiming too high too early! That looks like an advanced project, not a beginner one.

Start from the basics, because it's not an easy projects to start with.

Get yourself a MFC beginner's book, and do the exercises, go steps by steps...

make connection between what you learn and what you want to do (user interface, behaviours, ... )

Try to emulate/replicate what you've learn and start from there.

This signature was proudly tested on animals.

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 6:09

4-Oct-09 6:09

I know I am only a beginner but I am not completing the project myself. I already have other people to finish the advanced stuff for the project off already I am only doing the basics if you know what I mean. It will all make sense later, you just need to trust me.

Thanks

Andrew McIntyre

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 7:11

4-Oct-09 7:11

Okay. I have started to write the code for the Win32 client, but I may need help along the way as was wondering if you guys will be willing to help me if I get stuck,

Thanks

Andrew McIntyre

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 7:19

4-Oct-09 7:19

When I wrote the code I had 1 failed error. Here the code for the Client, and if someone could tell me what I have done wrong.

#include <windows.h><br />
<br />
const char g_szClassName[] = "MyProject";<br />
<br />
//Step 4: The Window Procedure<br />
LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)<br />
{<br />
	switch(msg)<br />
	{<br />
	case WM_CLOSE:<br />
		DestroyWindow(hwnd);<br />
		break;<br />
	case WM_DESTROY:<br />
		PostQuitMessage(0);<br />
		default;<br />
			return DefWindowProc(hwnd, msg, wParam, lParam);<br />
	}<br />
	return 0;<br />
}<br />
<br />
	int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,<br />
		LPSTR lpCmdLine, int nCmdShow)<br />
	{<br />
		WNDCLASSEX wc;<br />
		HWND hwnd;<br />
		MSG Msg;<br />
<br />
		//Step 1: Registering the Window Class<br />
		wc.cbSize			= sizeof (WNDCLASSEX);<br />
		wb.style			= 0;<br />
		wc.lpfnWndProc		= WndProc;<br />
		wc.cbClsExtra		= 0;<br />
		wc.cbWndExtra		= 0;<br />
		wc.hInstance		= hInstance;<br />
		wc.hIcon			= LoadIcon(NULL, IDI_APPLICATION);<br />
		wc.hCursor			= LoadCursor(NULL, IDC_ARROW);<br />
		wc.hbrBackground	= (HBRUSH) (COLOR_WINDOW+1);<br />
		wc.lpszMenuName		= NULL;<br />
		wc.lpszClassName	= g_szClassName;<br />
		wc.hIconSm			= LoadIcon(NULL, IDI_APPLICATION);<br />
<br />
		if(!RegisterClassEx(&wc))<br />
		{<br />
			MessageBox(NULL, "Window Registration Failed!", "Error",<br />
				MB_ICONEXCLAMATION | MB_OK);<br />
			return 0;<br />
		}<br />
<br />
		//Step 2: Creating the Window<br />
		hwnd = CreateWindowEx(<br />
			WS_EX_CLIENTEDGE,<br />
			g_szClassName,<br />
			"The title of my window",<br />
			WS_OVERLAPPEDWINDOW,<br />
			CW_USERDEFAULT, CS_USERDEFAULT, 903, 729,<br />
			NULL, NULL, hInstance, NULL);<br />
<br />
		if(hwnd == NULL)<br />
		{<br />
			MessageBox(NULL, "Window Creation Failed", "Error!",<br />
				MB_ICONEXCLAMAION | MB_OK);<br />
			return 0;<br />
		}<br />
<br />
		ShowWindow(hwnd, nCmdShow);<br />
		UpdateWindow(hwnd);<br />
<br />
		//Step 3: The Messag Loop<br />
		while(GetMessage(&Msg, NULL, 0,0) > 0)<br />
		{<br />
			TranslateMessage(&Msg);<br />
			DispatchMessage(&Msg);<br />
		}<br />
		return Msg.wParam;<br />
	}<br />

Thanks.

Andrew McIntyre

Re: C++ Helper Wanted [modified]

Michael Schubert4-Oct-09 11:33

Michael Schubert

4-Oct-09 11:33

MrMcIntyre wrote:
When I wrote the code I had 1 failed error

I get 5 or 6 when I try to compile this (VC6, 2003 Platform SDK). The switch statement is screwed up, you're using non-existing window styles, typos, etc.

All I see is a pretty standard Win32 application skeleton that just creates a window and a message loop. Well, it would if you fixed all the obvious errors.

Don't get me wrong - I don't want to discourage you from writing this program but you're getting way ahead of yourself. Once you really understand what the above code does (and know how to fix the errors) you can start putting in your own code.

modified on Sunday, October 4, 2009 5:42 PM

Re: C++ Helper Wanted

MrMcIntyre4-Oct-09 11:51

4-Oct-09 11:51

It's alright. I got the application to work perfectly now.

Andrew McIntyre

Re: C++ Helper Wanted

MrMcIntyre5-Oct-09 9:57

5-Oct-09 9:57

Does anyone know a code to centre the Win32 client to the screen. Just brushing up on a few minor things. Please forgive if I ask too many questions.

Thanks

Andrew McIntyre

Re: C++ Helper Wanted

David Crow5-Oct-09 10:09

5-Oct-09 10:09

MrMcIntyre wrote:
Does anyone know a code to centre the Win32 client to the screen.

If you are using MFC, CenterWindow(). If not, you can still consult its source code to see how it is handled.

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

Re: C++ Helper Wanted

MrMcIntyre5-Oct-09 10:16

5-Oct-09 10:16

Is that the full line of code? If so, where would I place it in the source code.

Andrew McIntyre

Re: C++ Helper Wanted

David Crow5-Oct-09 10:19

5-Oct-09 10:19

MrMcIntyre wrote:
Is that the full line of code?

Did you consult the documentation (or the source code)?

MrMcIntyre wrote:
If so, where would I place it in the source code.

At the point you want the window centered. After the window has been created but before it is rendered would be a good place to start (hint: WM_CREATE).

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

Re: C++ Helper Wanted

MrMcIntyre5-Oct-09 10:21

5-Oct-09 10:21

What documentation, I haven't read any documents

Andrew McIntyre

Re: C++ Helper Wanted

Richard MacCutchan5-Oct-09 10:44

Richard MacCutchan

5-Oct-09 10:44

MrMcIntyre wrote:
What documentation, I haven't read any documents

And how many times must I suggest that you do, before the message sinks in?

General News Suggestion Question Bug Answer Joke Praise Rant Admin

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.