C / C++ / MFC Discussion Boards

CodingLover4-Nov-07 19:59

4-Nov-07 19:59

But in that way, I have to waist my resources. Because in some case(I mean in a single iteration) full buffer is not use. Frown | :(

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Paresh Chitte4-Nov-07 20:03

Paresh Chitte

4-Nov-07 20:03

Could you please explain the situation ?

Regards,
Paresh.

Re: Dynamic buffer allocation

CodingLover4-Nov-07 20:34

CodingLover

4-Nov-07 20:34

Sure, here it is.

Initially I've used a predefined buffer of size 5000 as follows.

char buffer[5000];

Then on my application I found that the length of a bytes stream and going to read it using the buffer. Sometimes the stream is too small, and in some cases it is too long. So I want to use a dynamic buffer to avoid wasting memory.

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Paresh Chitte4-Nov-07 20:42

Paresh Chitte

4-Nov-07 20:42

Try using realloc.

Regards,
Paresh.

Re: Dynamic buffer allocation

chandu0044-Nov-07 21:10

chandu004

4-Nov-07 21:10

hai,
iam not sure weather the following logic suits your application but you can try it.
1.at the start of your loop, as you are caluculating the length, allocate that many number of bytes.
2.use them however you want them.
3.at the end of the loop, release them i mean, de allocate (free) them.

as far as i know, once the loop ends, the memory allocated should automatically be freed.
good luck.

Re: Dynamic buffer allocation

CodingLover4-Nov-07 21:34

CodingLover

4-Nov-07 21:34

Sure, the thing I found difficult is that how to create a dynamic buffer. Now it is ok.

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Nelek4-Nov-07 22:07

Nelek

4-Nov-07 22:07

What about...

void* pBuffer = NULL;
;
//Get your size into your int
;
pBuffer = new BYTE [intSize];
;
// use it as u need
;
delete [] pBuffer;
pBuffer = NULL;

Greetings.

--------
M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?

Help me to understand what I'm saying, and I'll explain it better to you

Wink | ;)

Re: Dynamic buffer allocation

CodingLover4-Nov-07 22:12

CodingLover

4-Nov-07 22:12

Nelek wrote:
void* pBuffer = NULL;
;
//Get your size into your int
;
pBuffer = new BYTE [intSize];

I have a question here. If I'm correct buffer data type is byte, but in initialization you have use it as void. I'm confusing on it, can you explain it little more.

Nelek wrote:
pBuffer = NULL;

Here, if I use this within a loop I don't want to do this, right?

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

vijay_aroli4-Nov-07 23:15

vijay_aroli

4-Nov-07 23:15

Eranga Thennakoon wrote:
but in initialization you have use it as void

There is no wrong in doing so. A void pointer can point to a data of another type.

Regards,
Vijay.

God may not give us what we 'want', but he surely gives us what we 'need'.

Re: Dynamic buffer allocation

CodingLover4-Nov-07 23:31

CodingLover

4-Nov-07 23:31

That is interesting to me. So I can use buffers easily, I mean just define them as VOID and later I can decide the actual data type I'm going to use.

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Cedric Moonen4-Nov-07 23:44

Cedric Moonen

4-Nov-07 23:44

That's quite dangerous to do so (specially when you delete the array). If you know the data type upfront, use a buffer of that type and stick to it, it will save you a lot of troubles.

Cédric Moonen
Software developer

Charting control [v1.2]

Re: Dynamic buffer allocation

CodingLover5-Nov-07 0:02

CodingLover

5-Nov-07 0:02

Thanks for your advice. Actually I think it is better to use the buffer gain and again, that mean dynamically initialization and delete is after use. As you say, no need to deal with dangerous situations and better to work with in right way.

Reuse of the buffer will helps me to work fine with the memory.

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

David Crow5-Nov-07 3:38

David Crow

5-Nov-07 3:38

Technically yes, but any time you need to read from or write to the void*, you'd have to cast it first. That's ugly and inefficient.

"Normal is getting dressed in clothes that you buy for work and driving through traffic in a car that you are still paying for, in order to get to the job you need to pay for the clothes and the car and the house you leave vacant all day so you can afford to live in it." - Ellen Goodman

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: Dynamic buffer allocation

CodingLover5-Nov-07 17:13

CodingLover

5-Nov-07 17:13

DavidCrow wrote:
you'd have to cast it first. That's ugly and inefficient.

I agreed with you. When I deal with such instances easily can be misses those casting and stuff. Better to avoid such points in developments. Wink | ;)

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Nelek4-Nov-07 23:43

Nelek

4-Nov-07 23:43

The intialization in void is correct, you can after cast to other types.

For the second question...

If you are changing the size for every iteration... you must do it at the last line of your loop.

void* pBuffer = NULL;

for (int i = 0; i < numFiles; i++)
{
	CFile f (a_szFileName[i], CFile::modeCreate | CFile::modeWrite);
	pBuffer = new BYTE [(a_differentSizes[i])];

	//Fill the buffer with the relevant data

	f.Write (pBuffer, (a_differentSizes[i] * sizeof (BYTE)));
	
	//Last Line
	delete [] pBuffer;
	pBuffer = NULL;
}

If you are using a simple iteration to go through the buffer, you should logically write the creation and the deletion at the beggining and at the end of your working area respectively, not into the loop.

void* pBuffer = NULL;
pBuffer = new BYTE [nBufferSize];

for (int i = 0; i < nBufferSize; i++)
{
	//do whatever you want with the individual BYTEs in the buffer

	if (*(pBuffer + i) == "F")
		//do something
}

delete [] pBuffer;
pBuffer = NULL;

was it what you wanted to know?

Re: Dynamic buffer allocation

CodingLover5-Nov-07 0:07

CodingLover

5-Nov-07 0:07

Nelek wrote:
The intialization in void is correct, you can after cast to other types.

Please if you can read my last replay for Cedric Moonen post. I have a suggestion.

Nelek wrote:
pBuffer = NULL;

Actually my question is that, why you do this after free/delete the buffer. Is it required.

I appreciate your help all the time...
Eranga Smile | :)

Re: Dynamic buffer allocation

Nelek5-Nov-07 1:03

Nelek

5-Nov-07 1:03

I have read Cedric's answer. I agree, but this doesn't mean is incorrect. If I know the format, I usually use the format. The code above was an example.

About the NULL after deleting, it actually is not a must, but it doesn't disturb at all, and I use it so, maybe to ensure that if I reuse the buffer, it won't go trhough ASSERT (pBuffer) by mistake because it still has the last address (although no datas in).

Re: Dynamic buffer allocation

CodingLover5-Nov-07 17:10

CodingLover

5-Nov-07 17:10

Nelek wrote:
About the NULL after deleting, it actually is not a must, but it doesn't disturb at all, and I use it so, maybe to ensure that if I reuse the buffer, it won't go trhough ASSERT (pBuffer) by mistake because it still has the last address (although no datas in).

That is really interesting pal. Actually those kind of hints are really helpful in a large project. Because I wont miss anything and not cause any damage in the future developments. Big Grin | :-D