C / C++ / MFC

Hamed Mosavi wrote:

What are issues with these classes:

Hamed Mosavi wrote:

What are issues with these classes:

class A
{
  class B
  {
  };
  B m_b;

  B* SomeFunc();
};

A::B* A::SomeFunc()
{
  return &m_b;
}

Mark Salsbery
Microsoft MVP - Visual C++

Mark Salsbery wrote:

Missing semi-colons, non-descriptive class names, missing scope resolution operator, ...

Hamed Mosavi wrote:

Anyway, I found my problem

Mark Salsbery
Microsoft MVP - Visual C++

dellthinker wrote:

I've googled/yahoo'ed all over to find a simple explanation on how to use it and i havnt found anything close to how to use it properly.

<br />
#include <windows.h><br />
#include <iostream><br />
using namespace std;<br />
<br />
int main(i)<br />
{<br />
   CreateProcess(("notpad.exe"),NULL,NULL,NULL,FALSE,0,NULL,NULL,NULL,NULL);<br />
  printf("Failed because: %s", GetLastError());<br />
<br />
   return 0;<br />
}<br />

dellthinker wrote:

int main(i)

dellthinker wrote:

printf("Failed because: %s", GetLastError());

printf("Failed because: %lu", GetLastError());

    STARTUPINFO StartupInfo;
    memset(&StartupInfo, 0, sizeof(STARTUPINFO));
    StartupInfo.cb = sizeof(STARTUPINFO);  

    PROCESS_INFORMATION ProcessInformation;

    if (0 == ::CreateProcess(_T("C:\\Windows\\system32\\notepad.exe"), //  LPCTSTR lpApplicationName,
                            NULL,                    //  LPTSTR lpCommandLine,
                            NULL,                    //  LPSECURITY_ATTRIBUTES lpProcessAttributes,
                            NULL,                    //  LPSECURITY_ATTRIBUTES lpThreadAttributes,
                            FALSE,                   //  BOOL bInheritHandles,
                            NORMAL_PRIORITY_CLASS,   //  DWORD dwCreationFlags,
                            NULL,                    //  LPVOID lpEnvironment,
                            NULL,                    //  LPCTSTR lpCurrentDirectory,
                            &StartupInfo,            //  LPSTARTUPINFO lpStartupInfo,
                            &ProcessInformation      //  LPPROCESS_INFORMATION lpProcessInformation
                            ))
    {
        TRACE1("Failed because: %lu", ::GetLastError());
    }
    else
    {
        // Succeeded!

        ::CloseHandle(ProcessInformation.hProcess);
        ::CloseHandle(ProcessInformation.hThread);
    }

Mark Salsbery
Microsoft MVP - Visual C++

/*Loop da janela*/
WPARAM TemplateWindow::MessageLoop()
{
<font color="Red">    while(GetMessage(&msg, m_hwnd, NULL, NULL))
</font>    {
        if(m_uiType == MDI)
        {
            if(!TranslateMDISysAccel(m_hwndFrame, &msg))
            {
                TranslateMessage(&msg);
                DispatchMessage(&msg);
            }
        }
        if(m_uiType == SDI)
        {
            TranslateMessage(&msg);
            DispatchMessage(&msg);
        }

<font color="Red">// This is bad design - Using a timer is WAY more efficient
//   than spinning in a loop that mostly does nothing except 
//   consume CPU
//            }
//        }
//        else
//        if(m_uiChildCount > 0)
//        {
//            SendMessage(childsInfo[0].hwnd, WM_PAINT, NULL, NULL);
//        }
//        SwapBuffers(m_hdc);
    }</font>

    return msg.wParam;
}

LRESULT CALLBACK MainWindowCallback(HWND hwnd, UINT uiMessage, WPARAM wParam, LPARAM lParam)
{
    HMENU hMainMenu;
    hMainMenu = CreateMenu(); <font color="Red">//<-- MAJOR resource leak!!!</font>
    static int siRuler = IDM_NEWRULER, siText = IDM_NEWTEXT, siNodule = IDM_NEWNODULE, siPath = IDM_NEWRULERPATH;
    switch(uiMessage)
    {
    case WM_CREATE:
    {
        ...
       <font color="Red"> // should return 0 if successful, -1 to fail the create</font>
        break;
    }
    case WM_CLOSE:
    {
        delete TextMenu;
        delete RulerMenu;
        delete PathMenu;
        delete NoduleMenu;
        delete ProceedingMenu;
        delete ScreenShotMenu;

        <font color="Red">// The default window proc calls DestroyWindow()
        return DefFrameProc(hwnd, g_hwndClient, uiMessage, wParam, lParam);</font>
    }
    <font color="Red">case WM_NCDESTROY:
        PostQuitMessage(0);
        break;</font>
        ...
    <font color="Red">default: 
        break;</font>
    }

    <font color="Red">return DefFrameProc(hwnd, g_hwndClient, uiMessage, wParam, lParam);
}</font>

Mark Salsbery
Microsoft MVP - Visual C++

<br />
7E41DACF   push        0<br />
7E41DAD1   push        0Ch<br />
7E41DAD3   pop         edx<br />
7E41DAD4   lea         ecx,[ebp-0Ch]<br />
7E41DAD7   mov         dword ptr [ebp-0Ch],edi<br />
7E41DADA   call        7E4194A4               <==that is the place where it stops<br />
<br />