Visual Basic

Re: Working with StreamReader/Writer [modified]

14-Aug-06 8:21

I have a simple project that i am trying to figure out how to complete.

I have a .txt file that I am reading from. I would like to be able to read it into a RTF control change the text around and save it back.

I was trying to make a shortcut and delete the file then create it and write the information from the RTF box or a stored string variable but no luck...something is holding the file open and I cannot figure out what it is.

Code is below.

Public Class Summary<br />
    Dim path As String = Application.StartupPath & "\"<br />
    Dim fileName As String = "ChangeLog.txt"<br />
    Dim MyString As String<br />
<br />
    Private Sub Summary_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load<br />
<br />
        Dim Sr As New IO.StreamReader(path & fileName, True)<br />
<br />
        Sr.BaseStream.Seek(0, IO.SeekOrigin.Begin)<br />
<br />
        Do While Sr.Peek > -1<br />
            MyString = Sr.ReadToEnd<br />
        Loop<br />
        With rtSummary<br />
            .ReadOnly = True<br />
            .Text = MyString<br />
        End With<br />
        Sr.Close()<br />
<br />
    End Sub<br />
<br />
    Private Sub ToolStripButton3_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnSave.Click<br />
        Dim Sw As New IO.StreamWriter(path & fileName, False)<br />
<br />
        If IO.File.Exists(path & fileName) Then<br />
            IO.File.Delete(fileName)<br />
            IO.File.Create(fileName)<br />
            Sw.WriteLine(vbCrLf & MyString & vbCrLf & rtSummary.Text)<br />
            Sw.Flush()<br />
            Sw.Close()<br />
        Else<br />
            IO.File.Create(path & fileName)<br />
            Sw.WriteLine(vbCrLf & rtSummary.Text)<br />
            Sw.Flush()<br />
            Sw.Close()<br />
        End If<br />
        Me.Dispose()<br />
    End Sub<br />
<br />
    Private Sub ToolStripButton1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnEdit.Click<br />
        rtSummary.ReadOnly = False<br />
    End Sub<br />
<br />
    Private Sub ToolStripButton2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnClear.Click<br />
        rtSummary.Clear()<br />
    End Sub<br />
<br />
    Private Sub Summary_FormClosing(ByVal sender As Object, ByVal e As System.Windows.Forms.FormClosingEventArgs) Handles Me.FormClosing<br />
        If rtSummary.Text IsNot "" Then<br />
           <br />
        End If<br />
    End Sub<br />
End Class

I know that some of this has no relevance to the problem but i thought i would include it nonetheless. What is holding the fle open so i cannot delete it. Or...is there a better way to accomplish what I am trying to accomplish?

Thanks in advance.

Thanks,

Taen Karth

Stephen McGuire14-Aug-06 8:52

14-Aug-06 8:52

Can you describe what is happening?
Is your textbox getting the text?

Your Sr.ReadToEnd should not be in a loop, since you are not reading each line...you are already reading the whole stream in one hit!

You should also close the SteamReader as soon as you have finished with it. Before you do anything with the data retrieved...
Steve

-- modified at 14:54 Monday 14th August, 2006

Taen_Karth14-Aug-06 8:55

14-Aug-06 8:55

Well that sure makes sense!...hehe
My RTF box IS in fact gettnig all the text, What is happening is that when it gets to the line:

IO.File.Delete(fileName)

It states that it cannot perform the action because the file requested is still in use.

Loop removed.

Thanks,

Taen Karth

Stephen McGuire14-Aug-06 9:15

14-Aug-06 9:15

You don't have the file open in another app do you?
Notepad or Word etc?

Steve

Taen_Karth14-Aug-06 9:17

Re: Working with StreamReader/Writer [modified]

14-Aug-06 9:17

Nope.

Thanks,

Taen Karth

Stephen McGuire14-Aug-06 9:23

Re: Working with StreamReader/Writer [modified]

14-Aug-06 9:23

You only have 'filname' for the file to delete.
Shouldn't this be 'path & filename'?

If you are always going to delete the file anyway, you don't have to check whether it exists first. Just code for deleting the file. An exception will not be generated if the file doesn't exist...

Then try using the CreateText method of the IO.File class.

What is that Me.Dispose() supposed to be doing?

Steve

-- modified at 15:26 Monday 14th August, 2006

Stephen McGuire14-Aug-06 9:37

14-Aug-06 9:37

Put your StreamWriter contstructor AFTER your File.Create line.

I think this is holding the file open.
You should only put this after you have created the file!

Steve

-- modified at 15:37 Monday 14th August, 2006

Taen_Karth14-Aug-06 10:00

14-Aug-06 10:00

Ok tried that and still getting this error message:

The process cannot access the file 'C:\Documents and Settings\troy\Desktop\Projects\ChangeLogger\ChangeLogger\bin\Debug\ChangeLog.txt' because it is being used by another process.

This is what the "Save" event looks like now:

Private Sub ToolStripButton3_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnSave.Click<br />
        Dim Sw As New IO.StreamWriter(path & fileName, False)<br />
<br />
<br />
        IO.File.Delete(path & fileName)<br />
        IO.File.CreateText(path & fileName)<br />
        Sw.WriteLine(vbCrLf & MyString & vbCrLf & rtSummary.Text)<br />
        Sw.Flush()<br />
        Sw.Close()<br />
        <br />
        Me.Dispose()<br />
    End Sub

Any ideas? btw thanks for the suggestions so far!

Thanks,

Taen Karth

Stephen McGuire14-Aug-06 10:10

14-Aug-06 10:10

The StreamWriter constructor must be moved to here:

Private Sub ToolStripButton3_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnSave.Click<br />
<br />
IO.File.Delete(path & fileName)<br />
IO.File.CreateText(path & fileName)<br />
Dim Sw As New IO.StreamWriter(path & fileName, False)<br />
Sw.WriteLine(vbCrLf & MyString & vbCrLf & rtSummary.Text)<br />
Sw.Flush()<br />
Sw.Close()<br />
<br />
End Sub

I have also removed the Me.Dispose() line.
If you want to do that, do it in the form's closed event handler.

Steve

Taen_Karth14-Aug-06 10:31

14-Aug-06 10:31

Still the same "File is in use" error as before...

Thanks,

Taen Karth

Taen_Karth14-Aug-06 10:38

14-Aug-06 10:38

Jeez...now I get that error on this line:
Dim Sw As New IO.StreamWriter(path & fileName, False)

and I do not get any errors on the two lines right before it that create adn delete the file.

Thanks,

Taen Karth

Stephen McGuire14-Aug-06 10:51

14-Aug-06 10:51

Sorry. I forgot to move the other line. Should be like this:

Private Sub ToolStripButton3_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tsbtnSave.Click<br />
<br />
IO.File.Delete(path & fileName)<br />
Dim Sw As IO.StreamWriter = IO.File.CreateText(path & fileName)<br />
Sw.WriteLine(vbCrLf & MyString & vbCrLf & rtSummary.Text)<br />
Sw.Flush()<br />
Sw.Close()<br />
<br />
End Sub

Steve

Taen_Karth14-Aug-06 11:24