ASP.NET

19-Dec-13 0:55

Hello,

I am trying to execute the following query string url:
api/item?name=storm&name=prest,
but I cannot get the code to work.

I am using the split function to request same records at the same time.

public class ItemController : ApiController
{
    private cdwEntities db = new cdwEntities();

    public HttpResponseMessage Get([FromUri] Query query)
    {
        var data = db.database_ICs.AsQueryable();

        if (query.name != null)
        {
            **data = data.Where(c => c.Name.Split("&").Contains(query.name));**

        }
        if (query.id!= null)
        {
            data = data.Where(c => c.ID== query.id);
        }

        if (!data.Any())
        {
            var message = string.Format("No data was found");
            return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
        }

        return Request.CreateResponse(HttpStatusCode.OK, data);
    }
}

Any help would be very much appreciated.

Richard Deeming19-Dec-13 2:05

19-Dec-13 2:05

Your code is taking the name from the database, splitting it on the ampersand character, and looking to see if any of the parts contain the string "storm,prest". So, for example, this would match a record where the name was "A&B&storm,prest&C".

I suspect you want to split the name from the query, and see if it contains the name from the database.

data = data.Where(c => query.name.Split(',').Contains(c.Name));

This would return records where the name is equal to either "storm" or "prest".

If you want to return records where the name contains any of the values passed in the querystring then it gets a little more complicated.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78619-Dec-13 2:12

19-Dec-13 2:12

Thank you so much for your response richard and thank you for clarifying the problem. Yes, that is correct, I would like the query string to return where name is either equal to 'storm' or 'prest'.

is their any example or functionality i can look at to build this method.

I really appreciate your help and time.
Many thanks.

Richard Deeming19-Dec-13 2:18

19-Dec-13 2:18

The code I posted in my previous answer should do what you want, assuming the name parameter comes through as I think it will. If not, you'll need to add a breakpoint to your method and inspect the value of the query.name property to see how it's being read.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78620-Dec-13 4:59

20-Dec-13 4:59

Thank you so much for response. I amended my code according to your suggestion, but sadly I could not get the code to work. I was getting "does not recognize the method 'System.String[] Split(Char[]" error and I changed the following line of code from:

var data = db.database_BWICs.AsQueryable();

to:

public class ItemController : ApiController
    {
        private cdwEntities db = new cdwEntities();

        public HttpResponseMessage Get([FromUri] Query query)
        {
            var data = db.database_ICs.AsEnumerable();

            if (query.name != null)
            {
                //data = data.Where(c => c.Name == query.name);
                data = data.Where(c => query.name.Split('&').Contains(c.Name));
                
                //data = data.Where(c => c.Name.Split('&').Contains(query.name));
            }
            if (query.id!= null)
            {
                data = data.Where(c => c.ID== query.id);
            }
            
            if (!data.Any())
            {
                var message = string.Format("No data was found");
                return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
            }

            return Request.CreateResponse(HttpStatusCode.OK, data);
        }
    }

After, changing the above line, I was able to resolve the above error. But I still cannot request two records of name in the URL: api/item?name=storm&name=prest
It only shows the result for the first name record in the url(storm). Is there a way to execute this functionality using any any other built-in function or some kind of pseudo code.

Thank you so much for your help and time.

Richard Deeming20-Dec-13 5:22

20-Dec-13 5:22

What's the value of the query.name property?

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78620-Dec-13 5:47

20-Dec-13 5:47

Thank you for response back. the value of the "query.name" is string.I submitted query class code for further reference.

namespace API_Dec.Controllers
{
    public class Query
    {

        public string name { get; set; }
        public string id{ get; set; }
        public string deal_type { get; set; }
        public string price_type { get; set; }
        public Nullable<DateTime> startDate { get; set; }
        public Nullable<DateTime> endDate{ get; set; }
    }
}

Many Thanks

Richard Deeming20-Dec-13 8:17

20-Dec-13 8:17

Yes, but what's the value in the name property when you submit your query? Does it contain "storm,prest", or something else?

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78620-Dec-13 10:06

20-Dec-13 10:06

I apologize for the confusion.

I am passing both 'storm' and 'prest' in the query string. So, my values contain 'storm' and 'storm'. when I pass 'name=storm', i get back 4 records but when i pass 'name=storm&name=prest', i get same 4 storm records and the query does not read the second name value.

many thanks for your time and help

miss78623-Dec-13 3:50

23-Dec-13 3:50

Hi Richard.
Thank you so much for your time and help. I am writing to inform, I manage to get the 'split' function to pass multiple records for the parameter name. I am little stuck on getting the 'split name' to work other parameter query. When I run a call = api/data?name=storm,prest&price_type=talk, I get 'no data' message on the client-end. Is there a way to filter the following above query string?

public HttpResponseMessage Get([FromUri] Query query)
        {
            var data = db.database_ICs.AsQueryable();


            if (query.name!= null)
            {
                 data = data.Where(c => query.name.Split(',').Contains(c.Name));
            }
            if (query.price_type != null)
            {
                data = data.Where(c => c.Cover == query.price_type);
            }
            
            if (!data.Any())
            {
                var message = string.Format("No data was found");
                return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
            }

            return Request.CreateResponse(HttpStatusCode.OK, data);
        }

I really appreciate your support and time. Many thanks.

Richard Deeming6-Jan-14 8:35

6-Jan-14 8:35

So if you call api/data?name=storm&price_type=talk, you get 4 records?

And if you call api/data?name=storm,storm&price_type=talk, do you still get the same records?

What is the value of query.name when you call api/data?name=storm,prest&price_type=talk?

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss7867-Jan-14 5:50

7-Jan-14 5:50

Hi Richard. Thank you so much for your help and apology for the late response.
Hope you had a nice Christmas holiday and happy new year.

I manage to get the code partially working by adding 'toList' with split function. So the code works for the following url = 'api/item/name=storm,prest'. However, I cannot get the code to execute two parameters together such as 'api/item?name=storm,prest&id=123', it throws a no data found error.

I am assuming there is an issue with using contain, if so, is there another function i could use. Any help would be very much appreciated.
Thank you so much for your time and help.

public class ItemController : ApiController
    {
        private cdwEntities db = new cdwEntities();
 
        public HttpResponseMessage Get([FromUri] Query query)
        {
            var data = db.database_ICs.AsQueryable();
 
            if (query.name != null)
            {
		 var ids = query.name.Split(',').ToList();
                 data = data.Where(c => ids.Contains(c.Name));
            }
            if (query.id!= null)
            {
                 var ids = query.id.Split(',').ToList();
                data = data.Where(c => ids.Contains(c.ID));
            }
            
            if (!data.Any())
            {
                var message = string.Format("No data was found");
                return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
            }
 
            return Request.CreateResponse(HttpStatusCode.OK, data);
        }
    }

Richard Deeming7-Jan-14 8:03

7-Jan-14 8:03

And are you absolutely certain that you have a record with ID = 123 and either Name = storm or Name = prest?

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss7869-Jan-14 6:25

9-Jan-14 6:25

Apology for late reply. I been trying to get this filter to work for the past couple of days but so far I am sadly failing.

I am trying to filter data by searching for many values for certain parameter. for example, filter data by id1 = 123 (or),234&(or)id=345&name=..ect. Apology for not making my problem clear. I usually check the any api query string by converting it into sql schema, to look for same records/data with the web api query string.

I can get the 'contain' function to work with two parameter like so:

if (query.id1!= null || query.id2!= null)
            {
                data = data.Where(c => c.ID1.Contains(query.id1) || c.ID2.Contains(query.id2));
            }

but i would like to able search many ids from parameter id1 or id2, for example: api/item?id1=345,567&id2=678

I cannot seem to get 'split' function to work with the above code layout.

Thank you for your time and help.

Richard Deeming9-Jan-14 7:50

9-Jan-14 7:50

Every time you post a message, the code changes! Confused | :confused:

In your previous message, you said you'd managed to get Split working to search for multiple names. You've now changed the code to search for ID1 or ID2, and to only return records where the value in the database contains the full value passed in the querystring.

I think you need to go back to the start and describe exactly what you are trying to achieve with this method. It would also help to have a stable description of your database entities and query class.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78613-Jan-14 5:03

13-Jan-14 5:03

Hello, I would like to sincerely apologies for the confusion with my data parameters. i will try to explain the continuous issue I am currently experiencing with the 'split' function
as clearly and with
the requested classes and entities.

I would like to be able to call multiple 'name' and 'id1''s entities in a single call, such as api/test?name=storm,prest&id1=123. So far, I can get only get one of the parameter's (name or id1) to output multiple string values.
If I try to execute, the following with more than two parameters: api/test?name=storm,prest&id1=123, I get a 'no data error'.

This is my updated code:
please note: the split function has been updated for checking null strings in 'name' and 'ids' parameters.

public HttpResponseMessage Get([FromUri] Query query)
        {
            var data = db.database_ICs.AsQueryable();

            if (!String.IsNullOrEmpty(query.name))
            {
                var ids = query.name.Split(',').ToList();                
                //data = data.Where(c => c.Name == query.name);
                data = data.Where(c => ids.Any(i => (c.Name!= null && c.Name.Contains(i))));
            }

            if (!String.IsNullOrEmpty(query.id1))
            {
                var ids = query.id1.Split(',').ToList();
                
                data = data.Where(c => ids.Any(i => (c.ID1!= null && c.ID1.Contains(i))));
                data = data.Where(c => c.Name == query.name);
            }

            if (!String.IsNullOrEmpty(query.id2))
            {
                var ids = query.id2.Split(',').ToList();

                //data = data.Where(c => ids.Any(i => (c.ID2!= null && c.ID2.Contains(i))));
                data = data.Where(c => c.ID2 == query.id2);
            }

            if (query.deal_type != null)
            {
                data = data.Where(c => c.Type == query.deal_type);
            }
            if (!data.Any())
            {
                var message = string.Format("No data was found");
                return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
            }

            return Request.CreateResponse(HttpStatusCode.OK, data);
        }


public class Query
    {

        public string name { get; set; }
        public string id1{ get; set; }
        public string id2{ get; set; }
        public string deal_type { get; set; }
        
    }</pre>

Name	id1	id2	deal_type
prest	789		ms
prest	345		ms
storm		456	bs
storm			bs
ariel	123		rs
ariel		223	rs


Thank you so much your time and help. Many thanks.

Richard Deeming13-Jan-14 7:49

13-Jan-14 7:49

OK, I think I see the problem. You're combining the filters for multiple parameters by chaining calls to the Where method. This will only return records which match all of the filters. Looking at your data, none of the records match both ID1 = 123 and (Name.Contains("storm") || Name.Contains("prest")).

I'm guessing you want to return records which match any of the filters. In this case, the simplest option is to use the Union method:

var data = db.database_ICs.AsQueryable();
var filteredData = new List<IQueryable<database_IC>>();

if (!string.IsNullOrEmpty(query.name))
{
    var ids = query.name.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.Name != null && c.Name.Contains(i)));
    }
}

if (!string.IsNullOrEmpty(query.id1))
{
    var ids = query.id1.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.ID1 != null && c.ID1.Contains(i)));
    }
}

if (!string.IsNullOrEmpty(query.id2))
{
    var ids = query.id2.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.ID2 != null && c.ID1.Contains(i)));
    }
}

if (query.deal_type != null)
{
    filteredData.Add(data.Where(c => c.Type == query.deal_type));
}

// If no filters passed, return all data.
// Otherwise, combine the individual filters using the Union method
// to return all records which match at least one filter.
if (filteredData.Count != 0)
{
    data = filteredData.Aggregate(Queryable.Union);
}

if (!data.Any())
{
    var message = string.Format("No data was found");
    return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
}

return Request.CreateResponse(HttpStatusCode.OK, data);

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78614-Jan-14 5:08

14-Jan-14 5:08

Thank you so much for time and solution. from your suggested code, i was able to execute query name and id1.

I have one small issue, when I add deal_type filter parameter to the ids search string, I do not get the accurate number of records. When i search for query 'name=storm, prest&id1=6782345', i get 10 records, from which have 9 have a deal_type= cs and other with deal-type=ms.

If search the above query with the deal-type parameter such as (api/test?name=storm,prest&id2=6782345&deal_type=ms), I should get 1 record but instead I get 2700 records.

I tired editing/debugging the code using the following logic, but I cannot seem to get to a working solution:
([id1 = value1 or value2] or [id1 = values1 or value2]) and deal_type = ms

Any example would be very much helpful. Apology for causing so much trouble. I really appreciate your hardwork and advice.
Many thanks

Richard Deeming14-Jan-14 10:59

14-Jan-14 10:59

Try moving the deal_type filter to the start:

var data = db.database_ICs.AsQueryable();

// If a deal_type is specified, only return records for that deal type:
if (query.deal_type != null)
{
    data = data.Where(c => c.Type == query.deal_type);
}

// If any other filters are specified, return records which match any of them:
var filteredData = new List<IQueryable<database_IC>>();

if (!string.IsNullOrEmpty(query.name))
{
    var ids = query.name.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.Name != null && c.Name.Contains(i)));
    }
}

if (!string.IsNullOrEmpty(query.id1))
{
    var ids = query.id1.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.ID1 != null && c.ID1.Contains(i)));
    }
}

if (!string.IsNullOrEmpty(query.id2))
{
    var ids = query.id2.Split(',');
    foreach (string i in ids)
    {
        filteredData.Add(data.Where(c => c.ID2 != null && c.ID1.Contains(i)));
    }
}

// If no filters passed, return all data.
// Otherwise, combine the individual filters using the Union method
// to return all records which match at least one filter.
if (filteredData.Count != 0)
{
    data = filteredData.Aggregate(Queryable.Union);
}

if (!data.Any())
{
    var message = string.Format("No data was found");
    return Request.CreateErrorResponse(HttpStatusCode.NotFound, message);
}

return Request.CreateResponse(HttpStatusCode.OK, data);

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

miss78628-Jan-14 6:52