|
elektrowolf wrote: C# isn't too fast, too
Uh, ***trying not to sound rude***, how inefficiently do you code?
|
|
|
|
|
.. I mean compared to C++. I don't think it's too slow, I've never had problems with C#'s performance, but for some algorithms you need C++.
|
|
|
|
|
elektrowolf wrote: but for some algorithms you need C++.
like what?
Yes, i'd agree there is a slight performance decrease compaired to c++ but it's neglible.
|
|
|
|
|
Thread t = new Thread(delegate()
{
while (keepShowing)
{
this.Dispatcher.Invoke(System.Windows.Threading.DispatcherPriority.Normal, new RefreshDelegate(delegate()
{
if (!(Mouse.LeftButton == MouseButtonState.Released &&
Mouse.MiddleButton == MouseButtonState.Released &&
Mouse.RightButton == MouseButtonState.Released &&
Mouse.XButton1 == MouseButtonState.Released &&
Mouse.XButton2 == MouseButtonState.Released))
{
if (!insideControl)
{
for (int i = 0; i < this.MenuButtons.Count; i++)
{
if (this.MenuButtons[i].PopupMenu != null && this.MenuButtons[i].PopupMenu.IsMouseInside)
{
return;
}
}
keepShowing = false;
}
}
}));
Thread.Sleep(10);
}
this.Dispatcher.Invoke(System.Windows.Threading.DispatcherPriority.Normal, new RefreshDelegate(delegate()
{
this.IsOpen = false;
}));
});
t.Name = "Capture Click Events Thread";
t.Priority = ThreadPriority.AboveNormal;
t.Start();
A thread with anonamous delegate to a dispatcher with an anonamous delegate.... crazy talk I say. I don't remember exactly where it is (hence I havn't posted it), but I have a thread with anonamous delegate to a dispatcher with an anonamous delegate to a thread with anonamous delegate to a dispatcher with an anonamous delegate somewhere. *Ps. It's in the RibbonControl library, oops (http://www.codeproject.com/KB/WPF/ribboncontrol.aspx[^])
|
|
|
|
|
Yeah, that looks like abuse.
|
|
|
|
|
It's the way forward
Still, it's a shame they didn't go back to the ways of .NET 1 where you could just directly modify gui properties directly. I remember seeing the justification for it, but frankly .NET 1 never gave me any problems so why change it.
|
|
|
|
|
Nothing really wrong with that... maybe you are just scared of nested closures You should probably stay away from any functional language in that case
|
|
|
|
|
I'd question perhaps how maintainable that is though!
|
|
|
|
|
I don't even know the code that belongs to and it is rather easy to see what it does. It needs a delegate to invoke back to the GUI thread from within the runner thread. As an exercise, convert that code to a non-anonymous delegate way, you will see the resulting code will be much more disconnected, and a lot more verbose. Unless he is repeating the code anywhere else, I see no reason to refactor it.
|
|
|
|
|
leppie wrote: you will see the resulting code will be much more disconnected
Certainly, however convert it to the .NET 1.0 way and it'll be far less confusing.
|
|
|
|
|
Derek Bartram wrote: I'd question perhaps how maintainable that is though!
The more I think about it, the more I find the answer is very.
All the code is in one place, and isn't abomnably long.
At worst it could be said that the threaded method should be declared rather anonymous, the others are just what anonymous methods were intended for.
I'm largely language agnostic
After a while they all bug me
|
|
|
|
|
|
I just found a bunch of properties made read-only like this (I think they're from a template):
set
{
}
Huh? If you want it to be read-only, make it read-only!
|
|
|
|
|
That's not so much read-only as it is a "la la la I'm not listening la la la" property.
Please don't bother me... I'm hacking right now. Don't look at me like that - doesn't anybody remember what "hacking" really means?
|
|
|
|
|
Actually, I have found that sometimes you need to do that.
I can't remember the exact reasoning, but a couple weeks ago I was trying to pass a readonly property to a .NET function of some sort and it would throw an error, despite, the property not being written too...the "fix" was to have an empty set...and I believe I marked it as deprecated so it threw a compile error if someone tried to write to it.
|
|
|
|
|
The ObsoleteAttribute can't be applied to a property accessor.
The class in question is implementing an abstract class, which specifies both get and set. I should have checked that before I posted this, but still... the set should throw a NotImplementedException or something. Failing that, the accessor should be functional.
|
|
|
|
|
Well, if the guy who owns the interface doesn't want to remove the set from the interface, I guess you are pretty much stucked with that.
|
|
|
|
|
Yes, but silently ignoring the value is poor style.
|
|
|
|
|
PIEBALDconsult wrote: silently ignoring the value is poor style.
Yes, it is. I can only imagine the headache of trying to track it down on a Friday afternoon.
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
|
|
|
|
|
Well, personally I say get rid of properties anyway! There is simply no point in them other than making the language more bloated and less clear.... In the good old days....
.name = public class variable, didn't run any code, just gave access.... now will it run code, or won't it!?!?!??!?
|
|
|
|
|
Sure they can be abused, but I wouldn't get rid of them just because of that.
|
|
|
|
|
Maybe, but it just seams like a lazy way of coding that means it's harder to tell what code is actually doing. Personally I feel it makes using other people's code harder (particularily badly written code where the property name is misleading)
|
|
|
|
|
But properly written properties do data validation, and will modify any other values that need to be modified when that property changes.
|
|
|
|
|
That's the problem though... the amount of people who i've seen doing things like modify data structures in property gets, is pretty high. Why leave elements of the language that can result in really hard to debug code and misconceptions?
|
|
|
|
|
But, often, if you don't modify the data of the class, when you set the property, your data may be invalid...and calling functionX at that time will result in invalid results, or errors.
|
|
|
|