Click here to Skip to main content
15,921,837 members

The Weird and The Wonderful

   

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

 
GeneralRe: Check for True to return True... Pin
MehGerbil14-Jul-11 2:40
MehGerbil14-Jul-11 2:40 
GeneralThis code may not quite do what it says it does. PinPopular
RCoate29-Jun-11 14:34
RCoate29-Jun-11 14:34 
GeneralRe: This code may not quite do what it says it does. Pin
walterhevedeich29-Jun-11 15:35
professionalwalterhevedeich29-Jun-11 15:35 
GeneralRe: This code may not quite do what it says it does. Pin
BobJanova30-Jun-11 3:39
BobJanova30-Jun-11 3:39 
GeneralRe: This code may not quite do what it says it does. Pin
walterhevedeich30-Jun-11 13:15
professionalwalterhevedeich30-Jun-11 13:15 
GeneralRe: This code may not quite do what it says it does. Pin
RCoate30-Jun-11 15:28
RCoate30-Jun-11 15:28 
JokeRe: This code may not quite do what it says it does. Pin
Peter_in_278030-Jun-11 16:05
professionalPeter_in_278030-Jun-11 16:05 
GeneralRe: This code may not quite do what it says it does. Pin
BrainiacV5-Jul-11 7:43
BrainiacV5-Jul-11 7:43 
GeneralRe: This code may not quite do what it says it does. Pin
User 75994145-Jul-11 5:04
User 75994145-Jul-11 5:04 
GeneralRe: This code may not quite do what it says it does. Pin
BobJanova5-Jul-11 7:19
BobJanova5-Jul-11 7:19 
GeneralRe: This code may not quite do what it says it does. Pin
timpattinson5-Jul-11 12:43
timpattinson5-Jul-11 12:43 
GeneralRe: This code may not quite do what it says it does. PinPopular
0bx29-Jun-11 21:23
0bx29-Jun-11 21:23 
GeneralRe: This code may not quite do what it says it does. Pin
BobJanova30-Jun-11 3:26
BobJanova30-Jun-11 3:26 
GeneralRe: This code may not quite do what it says it does. Pin
Tarun.K.S30-Jun-11 3:20
Tarun.K.S30-Jun-11 3:20 
GeneralRe: This code may not quite do what it says it does. Pin
chmod22225-Jul-11 1:52
chmod22225-Jul-11 1:52 
GeneralRe: This code may not quite do what it says it does. Pin
James H5-Jul-11 2:19
James H5-Jul-11 2:19 
GeneralRe: This code may not quite do what it says it does. Pin
chmod22225-Jul-11 2:24
chmod22225-Jul-11 2:24 
GeneralRe: This code may not quite do what it says it does. Pin
James H5-Jul-11 3:38
James H5-Jul-11 3:38 
GeneralRe: This code may not quite do what it says it does. Pin
chmod22225-Jul-11 4:09
chmod22225-Jul-11 4:09 
GeneralRe: This code may not quite do what it says it does. Pin
austin hamman5-Jul-11 4:27
austin hamman5-Jul-11 4:27 
GeneralRe: This code may not quite do what it says it does. Pin
chmod22225-Jul-11 4:31
chmod22225-Jul-11 4:31 
GeneralRe: This code may not quite do what it says it does. Pin
User 48350475-Jul-11 3:39
User 48350475-Jul-11 3:39 
GeneralRe: This code may not quite do what it says it does. Pin
Mark AJA5-Jul-11 9:01
Mark AJA5-Jul-11 9:01 
GeneralRe: This code may not quite do what it says it does. Pin
Gates VP5-Jul-11 9:17
Gates VP5-Jul-11 9:17 
So that second gem is not totally useless if it's trying to fill out an Interface of some type. In PHP I've done crazy stuff like this b/c PHP only supports functions in Interfaces so you end with "constants" as "functions".

As to your first case, this has a full boat of failures. That whole block of if... elseif... else -> do the same thing is actually pretty comical. The fact that it's in a for loop and "finds something" but doesn't break is really just odd.

But the kicker to me is that he has sets the app variable and then has a return value of true. Which basically says "hey check the app variable you passed me, I hammered it and returned the app I think I found"

Thank goodness it's private and hopefully caused minimal destruction Smile | :)
GeneralRe: This code may not quite do what it says it does. Pin
KP Lee6-Jul-11 6:41
KP Lee6-Jul-11 6:41 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.