Counting price cell, off my dynamic table only gets last row

Question

0.00/5 (No votes)

See more:

Hi, I'm making a dynamic table with textboxes, and from each row I will summarize the prices based on the choices they have made. Thif I have 10 rows, I have 10 prizes that I would like to summarize in a literal sum. But my counter does not work properly, it only takes the last row in my table and putting in total

What I have tried:

string total = "";
for (int j = 0; j < Rows; j++)
{
    TextBox t = (TextBox)(PlaceHolder1.FindControl("txtPrice_" + j));

    string[] values = {t.Text};
    double number;
    CultureInfo culture = null;

    foreach (string value in values)
    {
        try
        {
            culture = CultureInfo.CreateSpecificCulture("dk-DK");
            number = Double.Parse(value, culture);


            total = value.ToString();
        }
        catch (FormatException)
        {

            culture = CultureInfo.CreateSpecificCulture("dk-DK");


            total = value.ToString();
        }


    }
    litSum.Text = total;
}

Posted 3-Mar-18 23:10pm

Martin Lauritsen

Updated 4-Mar-18 0:21am

Add a Solution

Comments

George Swan 4-Mar-18 5:24am

I'm not sure what you are trying to achieve but to sum values in a loop you need to add the present value to the previous total. You seem to be replacing the total with latest value during each iteration.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-03-04T00:21:00

Solution 1

Well yes.
What you are doing is this:

C#

int total = 0;
for (int i = 1; i < 10; i++)
   {
   total = i;
   }
Console.WriteLine(total);

And you are surprised when the result is always "9".
Of course it is: you overwrite the value of total each time you go round the loop.
What you need to do is:

int total = 0;
for (int i = 1; i < 10; i++)
   {
   total += i;
   }
Console.WriteLine(total);

And you will get the sum.
But you don't need to be so complicated!

culture = CultureInfo.CreateSpecificCulture("dk-DK");
NumberStyles style = NumberStyles.Number;
double number;
double total = 0.0;
foreach (string value in values)
    {
    if (Double.TryParse(value, style, culture, out number))
       {
       total += Number;
       }
    }
litSum.Text = total.ToString();

Posted 4-Mar-18 0:21am

OriginalGriff

Updated 4-Mar-18 0:22am

v2

Comments

Martin Lauritsen 4-Mar-18 7:12am

It works thank you so much, i triede to change to decimal, so it keeps the decimals. But it's not working, you have any idea why ?:) i accept the solution

OriginalGriff 4-Mar-18 7:23am

Without seeing your code and exactly what you did? No idea! :laugh:
Always assume we can't see your screen...

Martin Lauritsen 4-Mar-18 7:36am

haha ofc ;)
decimal Number = 0;
decimal total = 0;

for (int j = 0; j < Rows; j++)
{
TextBox t = (TextBox)(PlaceHolder1.FindControl("txtPrice_" + j));

string[] values = { t.Text };

CultureInfo culture = null;

culture = CultureInfo.CreateSpecificCulture("dk-DK");
NumberStyles style = NumberStyles.Number;

foreach (string value in values)
{
if (decimal.TryParse(value, style, culture, out Number))
{
total += Number;
}
litSum.Text = String.Format("{0:0.00}", total.ToString());
}
}

OriginalGriff 4-Mar-18 7:58am

Why are you creating an array of one value, just to process it with a foreach loop? Makes no real sense...

Start by looking at exactly what is in your text boxes - and I mean exactly, use the debugger to find out - and look at what it returns as a result of the TryParse.
Get rid of the array and the foreach - you don't need either - and move the culture and style definitions outside your outer loop.

What inputs do you get, and what happens when you get them?

            decimal number = 0;
            decimal total = 0;
            CultureInfo culture = CultureInfo.CreateSpecificCulture("dk-DK");
            NumberStyles style = NumberStyles.Number;

            for (int j = 0; j < Rows; j++)
                {
                TextBox t = (TextBox)(PlaceHolder1.FindControl("txtPrice_" + j));
                if (t != null)
                    {
                    string value = t.Text;
                    if (decimal.TryParse(value, style, culture, out number))
                        {
                        total += number;
                        }
                    }  // breakpoint this line, and look at value and number
                }
            litSum.Text = String.Format("{0:0.00}", total.ToString());

Martin Lauritsen 4-Mar-18 8:30am

i get the number out like this 58750 and it should be 587.50

Martin Lauritsen 4-Mar-18 8:31am

or this 1.942,00

OriginalGriff 4-Mar-18 9:05am

And what - exactly - are you putting in to get it?
What - exactly - is in the Textbox.Text property? The debugger will show you, but I can't see your screen!

Martin Lauritsen 4-Mar-18 9:12am

txt1 = 293,75
txt2 = 493,75
Total = 787,5

OriginalGriff 4-Mar-18 10:16am

Ah. That's simple.
You got the culture code wrong. It's not "dk-DK" for Denmark, it's "da-DK" for "Danish - Denmark"
Change to this:

CultureInfo culture = CultureInfo.CreateSpecificCulture("da-DK");

And it'll work.

Martin Lauritsen 4-Mar-18 11:01am

omg you right, thank you so much for all the help, it now works :)

OriginalGriff 4-Mar-18 11:12am

You're welcome!