Problem on showing output in C

Question

1.00/5 (1 vote)

See more:

#include <stdio.h>
struct subjectRecord
{
    char subjectCode;
    char subjectName;
    char lecturer;
    int creditHour;
}subject[10];
int main(void)
{
    int a;
    for(a = 1; a <= 10; a++)
    {
        printf("\nEnter Subject Code: ");
        scanf("%s", &subject[a].subjectCode);
        printf("Enter Subject Name: ");
        scanf("%s", &subject[a].subjectName);
        printf("Enter Lecturer Name: ");
        scanf("%s", &subject[a].lecturer);
        printf("Enter Credit Hour: ");
        scanf("%d", &subject[a].creditHour);
    }
    for(a = 1; a <=10; a++){
    printf("Subject Code :%s\n",subject[a].subjectCode);
        printf("Subject Name: %d %d%d\n", subject[a].subjectName);
    printf("Lecturer Name:%s\n",subject[a].lecturer);
    printf("Credit Hour:%s\n",subject[a].creditHour);
   }
}

Please could someone explain where the error in my code is, as when I try to run the program an error message is displayed as follows:
'Program has got a problem and needs to close.'

[Edited following line to above so it makes sense:
'may i know where is my error because when i accept all the input and show the output, it say need to close got problem ==']

Posted 3-May-11 7:01am

Jayfam

Updated 3-May-11 7:05am

Ed Nutting

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ed Nutting · Answer 1 · 2011-05-03T07:24:00

You appear to have four significant problems two related to memory issues and two with format. The first is that when you read in the subjectCode, subjectName and lecturer strings you try to assign them to chars. This will give you a memory leak as it will overun the memory assigned to one char. The code you should use in your struct should be as follows:

gc

struct subjectRecord
{
    char subjectCode[100]; //Make sure an array of 100 chars is enough space to fit the full string your expecting into. Likewise for the next two variables.
    char subjectName[100];
    char lecturer[100];
    int creditHour;
}subject[10];

The next problem is that oyu try to have a for loop starting at one and going up to ten but using the same variable (a) to index into the subjectarray. This is a problem because arrays do not start from index 1 but from index 0, they are 'zero-based'. This means that what you think of as element (or subjectRecord) 1 in your subject array is actually element 0 and element 10 is element 9, 8 is 7 etc etc. Your for loops should therefore look like the following:

C

for(a = 0; a < 10; a++)
{
    printf("\nEnter Subject Code: ");
    scanf("%s", &subject[a].subjectCode);
    printf("Enter Subject Name: ");
    scanf("%s", &subject[a].subjectName);
    printf("Enter Lecturer Name: ");
    scanf("%s", &subject[a].lecturer);
    printf("Enter Credit Hour: ");
    scanf("%d", &subject[a].creditHour);

}
//and then:
for(a = 0; a <10; a++)
{
    printf("Subject Code :%s\n",subject[a].subjectCode);
    //printf("Subject Name: %d %d%d\n", subject[a].subjectName); Your other problem here was using %d for a string, it should be the below:
    printf("Subject Name: %s\n", subject[a].subjectName);
    printf("Lecturer Name:%s\n",subject[a].lecturer);
    //printf("Credit Hour:%s\n",subject[a].creditHour); And again %s instead of %d:
    printf("Credit Hour:%d\n",subject[a].creditHour); 
}

Your last two problems would cause probably fatal formatting issues. See the code above for explaination.

Hope this helps,

Ed :)