Empty path name is not legal when I save images C# windows application

Question

0.00/5 (No votes)

See more:

I want to save multiple Images now when I save all the 2 images I get no exception... but when I try to save only 1 or 2 or its throws an exception "Empty Path is not legal". my code is here

What I have tried:

C#

byte[] img = null;
  FileStream fs = new FileStream(imgloc, FileMode.Open, FileAccess.Read);
  BinaryReader br = new BinaryReader(fs);
  img = br.ReadBytes((int)fs.Length);

  //

  byte[] img1 = null;
  FileStream fs1 = new FileStream(imgloc1, FileMode.Open, FileAccess.Read);
  BinaryReader br1 = new BinaryReader(fs1);
  img1 = br1.ReadBytes((int)fs1.Length);


  //
  con.Open();
  SqlCommand cmd1 = new SqlCommand("insert into easypaisa (trid,selectopt,smobile,rmobile,snic,rnic,tamount,tcharges,totalcharges,date,descr,inv_no,Company,user_name,sprof,dataimg,image2) values ('" + textBox1.Text + "','" + comboBox1.Text + "','" + textBox2.Text + "','" + textBox3.Text + "','" + textBox4.Text + "','" + textBox5.Text + "','" + textBox6.Text + "','" + textBox7.Text + "','" + textBox8.Text + "','" + dateTimePicker1.Value.ToString("MM-dd-yyyy") + "','" + textBox10.Text + "','" + textBox9.Text + "','" + comboBox2.Text + "','" + Get_User_label.Text + "','" + textBox13.Text + "',@dataimg,@image2)", con);
  cmd1.Parameters.Add(new SqlParameter("@dataimg", img));
  cmd1.Parameters.Add(new SqlParameter("@image2", img1));
  cmd1.ExecuteNonQuery();
  con.Close();

  MessageBox.Show("Data Saved successfully", "Important Message",
                   MessageBoxButtons.OK, MessageBoxIcon.Information);

Posted 27-Nov-16 2:07am

Member 12861580

Updated 27-Nov-16 2:17am

Wendelius

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Answer 1 · 2016-11-27T02:16:00

Solution 1

First of all, you should never concatenate the values directly to the SQL statement. This leaves you open for SQL injections, conversion problems and so on.

What comes to the error itself, try to pinpoint the location where the exception is thrown. Use the debugger and have a look at the values you pass to the methods. For example what do the imgloc and imgloc1 contain.

Another thing is that you should use using blocks and try..catch structures to ensure that you properly dispose the objects and handle the errors correctly. For more information, have a look at Properly executing database operations[^]

Posted 27-Nov-16 2:16am

Wendelius

Updated 27-Nov-16 2:17am

v2

Comments

Member 12861580 28-Nov-16 8:48am

Sorry I dont Understand What can i do for this Error

Wendelius 28-Nov-16 9:13am

To get more information about the reason for the exception place a breakpoint on the line

FileStream fs = new FileStream(imgloc, FileMode.Open, FileAccess.Read);

Does imgloc contain a correct value. If it does, repeat the same with

FileStream fs1 = new FileStream(imgloc1, FileMode.Open, FileAccess.Read);

Also investigate the exact row that is causing the exception.

When this is done you know more about the reason for the error and if it is that either of those variables contain invalid path.

When this is fixed concentrate on using parameters for the query and implement the using blocks and the try..catch blocks.