I cant add data to my SQL

Question

1.00/5 (2 votes)

See more:

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Data.SqlClient;

namespace StudensDetails
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            // TODO: This line of code loads data into the 'database1DataSet1.Table' table. You can move, or remove it, as needed.
            this.tableTableAdapter1.Fill(this.database1DataSet1.Table);
            // TODO: This line of code loads data into the 'database1DataSet.Table' table. You can move, or remove it, as needed.
            this.tableTableAdapter.Fill(this.database1DataSet.Table);
        }

        private void button1_Click(object sender, EventArgs e)
        {
            SqlConnection cn = new SqlConnection(global::StudensDetails.Properties.Settings.Default.Database1ConnectionString);
            try
            {
                string sql = "INSERT INTO [Table] (Student_ID,StudentName) values(" + textBox1.Text + ",N'" + textBox2.Text + "')";
                SqlCommand exeSql = new SqlCommand(sql, cn);
                cn.Open();
                exeSql.ExecuteNonQuery();

                MessageBox.Show("Add New Record Done.", "Messeg", MessageBoxButtons.OK, MessageBoxIcon.Information);
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message , "Error" , MessageBoxButtons.OK , MessageBoxIcon.Error);
            }
            finally
            {
                cn.Close();
            }
        }

        private void button2_Click(object sender, EventArgs e)
        {
            this.tableTableAdapter.Fill(this.database1DataSet.Table);
        }
    }
}

What I have tried:

I try a lot of time i cant add

Posted 14-Nov-16 17:56pm

Member 12850701

Updated 14-Nov-16 19:54pm

StM0n

v2

Add a Solution

Comments

StM0n 15-Nov-16 0:17am

* Sorry to ask, but what have you tried?
* Any error messages?
* Is there a table called [Table] in your database?
* Do they have the proper columns you specified?
* Are you aware of the fact, that your code is open for sql injection?

Help us to help you :)

Suvendu Shekhar Giri 15-Nov-16 0:40am

Have you tried debugging?

I suspect, you table name should be something like "Students" or so and you just forgot to replace that in the INSERT query.

In that case, your query should look like-

INSERT INTO [Students] (Student_ID,StudentName) values ...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-11-14T19:54:00

For starters, don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

C#

using (SqlConnection con = new SqlConnection(strConnect))
    {
    con.Open();
    using (SqlCommand cmd = new SqlCommand("INSERT INTO [Table] (StudentId, StudentName) VALUES (@ID, @NM)", con))
        {
        cmd.Parameters.AddWithValue("@ID", textBox1.Text);
        cmd.Parameters.AddWithValue("@NM", textBox2.Text);
        cmd.ExecuteNonQuery();
        }
    }

Once you have done that, check your connection string. Try setting up a connection in VS with the Server Explorer pane:
1) Open Server Explorer.
2) Right click "Data connections" and select "Add connection"
3) In the dialog that follows, select your DataSource, and database, specify the security info, and press the "Test connection" button.
4) When the connection works, press "OK"
5) Highlight your database in the Server Explorer pane, and look at the Properties pane. A working example of the connection string will be shown, which you can copy and paste into your app or config file.
Then, check your names and columns: "Table" is an unlikely name for a table, and the two columns you reference use different naming conventions, so it's likely that one of them is wrong as well.
Check the datatypes: are they text? I.e. in SQL Server are they declared as VARCHAR or NVARCHAR? How big are they? Are they INT, or FLOAT instead?

And look at the exception: use the debugger to examine what it says is going on - SQL error message can be unhelpful, but they do give clues.