i dont know what should i do?

Question

1.00/5 (3 votes)

See more:

// samakhano0m.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include <string>
#include <iostream>
#include <algorithm>
using namespace std;
 
int main()
{
	int n , m ;
	int i = 0 , j = 0 ;
	
	cout << " Enter the lengh of string1 " << endl ;
	cin >> n ;
	cout << " Enter the lengh of string2 " << endl ;
	cin >> m ;
	char A[100];       char B[100];
	cout << "Enter the string1 : " << endl ;
	for( int j = 0 ; j < n ; j++ ){
	     cin >> A[j] ;
	}
	
	cout << "Enter the string2 : " << endl ;
	for( int i = 0 ; i < m ; i++ ){
	    cin >> B[i] ;
	}
	i=0;   j=0;   int r=0;
		for (j = 0;j< n-1 ;j++ )
			{
				if( B[i] == A[j] )
				{
					r++ ;
					if (i=m-1){
						i=0;
					}
					i++;
				}
				
				else
				{
					i = 0 ;
				}
		
		}
	cout << (r/m);
	
	
	return 0 ;
}

this program compare 2 string
a= xxxxxxyx
b=xy
but it does not ?

Posted 23-Apr-11 6:36am

yay hello

Updated 23-Apr-11 23:27pm

v2

Add a Solution

3 solutions

Solution 2

There's a ton of errors in that code, I'll only address the loop:

while( j < n )
{
  for( int i = 0 ; i < m ;  ) //<-- No brackets
    for( int j = 0 ; j < n ; ) //<-- No brackets 
      if( B == A ) //<-- Comparing pointers, not characters, in no way using indexes (so loops are worthless anyway)
      {
	i++ ;
	cout << "yay"  ;
      }
      else
      {
	j++ ;
      }
}

Posted 23-Apr-11 8:38am

Albert Holguin

Comments

mbue 23-Apr-11 16:51pm

Thats right. The variables i & j are declared 3 times. There is a potential possibility for buffer overflows without limit n & m to max 100 (buffer length). There must not be brackets for single statements, but this looks better. All that are not really errors but them make no sense at all.
Regards.

Sergey Alexandrovich Kryukov 23-Apr-11 22:26pm

My 5. You surely don't need to eat a whole egg to tell it's bad.
--SA

Solution 3

How about not flooding this forum with questions, instead working on one thing, and actually working, reading your source material, reading online articles, and trying to learn C++ instead of trying to get us to fix it all for you ?

Posted 29-Jun-11 22:01pm

Christian Graus

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2011-04-23T07:11:00

It's clearly a homework question, even if not, a student would simply needs a 5 minute copy-pen to see what is happening here:

while( j < n )
{
  for( int i = 0 ; i < m ;  )
     for( int j = 0 ; j < n ; )
	if( B == A )
	{
	    i++ ;
	    cout << "yay"  ;
	}
	else
	{
            j++ ;
	}
}

It's pretty clear on what is happening here. You don't need a running environment to see/debug to find the issue and implementation. Further, why not write a new one by yourself instead of correcting it, if you have that option. I see lots of issues here... starting with, if two string lengths are different what is left to be compared?