How to avoid duplicate insert into database?

Question

0.00/5 (No votes)

See more:

I write a query for insert records but some times it insert duplicate records
my query like this

DECLARE @cnt AS INT
SET @cnt=(SELECT COUNT(*) FROM
tbltest
WHERE
Empcode= @Uid AND
SID= @Sid AND
PID= @Pid AND
EmpID=@EmpId AND
RMID= @RMId AND
EndTime IS NULL)

IF @cnt=0
BEGIN
insert into tbltest (EmpCode,sid,Pid,Empid,RmId,Param1,Starttime,Transtype) values(
@Uid,
@Sid,
@Pid,
@EmpId,
@RMId,
@processname_param1,@CURRDATE,'Input')
END

i used code for avoiding duplication but some times it insert duplicate records.

Posted 13-Jan-16 20:36pm

Dj@y

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2016-01-13T20:41:00

Solution 1

Add a primary key to this table.
This primary key would be a combination of those columns that together define a unique field.

Even inf you don't want to define a primary key, you can define a unique constraint - Create Unique Constraints[^].

Posted 13-Jan-16 20:41pm

Abhinav S

Comments

Dj@y 14-Jan-16 2:52am

i already use primary key.

Abhinav S 14-Jan-16 2:57am

Check the data you are passing. Something could be wrong with the count query.
Use a unique constraint on non-primary fields.

Dj@y 14-Jan-16 3:06am

Boss i can't applay unique on non-primary fields, it avoid me to insert data for another user which have same field except EmpId

_Asif_ · Answer 2 · 2016-01-13T20:57:00

Solution 2

Try removing AND EndTime is NULL filter in your select query and check again

SQL

SET @cnt=(SELECT COUNT(*) FROM 
tbltest 
WHERE 
Empcode= @Uid AND 
SID= @Sid AND 
PID= @Pid AND 
EmpID=@EmpId AND 
RMID= @RMId)

Posted 13-Jan-16 20:57pm

_Asif_

Comments

Dj@y 14-Jan-16 3:03am

My all insertion is depend on EndTime only if EndTime is null then only i insert record.

_Asif_ 14-Jan-16 3:06am

Can you share your rows that has been duplicated with the original one?