How to do Sequence Number in Stored Procedure

Question

0.00/5 (No votes)

See more:

Hi.

I have an issue in below SP.
I have created DOno in Sequence (MS2012)
If execute SP, Dono for all record shows same.

Pls advise me

Maideen

Here is SP

SQL

ALTER Procedure [dbo].[W_usp_SO_GENERATION]
	@SoNo nvarchar(20),
	@SoDate datetime,
	@STDB nvarchar(5),
	@Products nvarchar(50),
	@issueNo nvarchar(10),
	@User nvarchar(20),
	@terminal nvarchar(50)

As
Begin

Declare @DoNo varchar(10)
SET @DoNo = next value for DONo
set @DoNo = 'DO-' + right('000000'+convert(varchar,@DoNo),6) 

INSERT INTO [dbo].[SOMaster_TEMP] (SoNo, SODate, SVCode, SVName,  MVCode, DistCode,RouteCode,Area,Edition, SeqNo,
								   Qty,Rate, STDB, BSTD, BEND, BLOS,Products, IssueNo, CreatedBy, CreatedOn, Terminal, 
								   DONo,GSTP,Type)

SELECT      @sono, @SoDate,  SVCode,  SVName,  MVCode,  DistCode, RouteCode, Area, Edition,  SeqNo,  '0', Rate, @STDB, '0', '0', '1', @Products, @issueNo, @User, @SoDate, 
	@terminal,  @DoNo, '6', type  FROM      [dbo].[vwRDMS]

Posted 13-Jul-15 15:59pm

Maideen Abdul Kader

Add a Solution

Comments

_Asif_ 14-Jul-15 2:33am

SET @DoNo = next value for DONo -- Please let us know how you getting next value for DONo?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2015-07-13T18:34:00

Based on the code you provided, value for @DoNo variable should be different on each call.

For seeing the sequence behaviour you can use PRINT statement to show the content of you variable, like:

SQL

Declare @DoNo varchar(10)
SET @DoNo = next value for DoNo
PRINT @DoNo
set @DoNo = 'DO-' + right('000000'+convert(varchar,@DoNo),6) 
PRINT @DoNo

As a side note, I would suggest storing the value from the sequence as-is. If you need to format it when displayed, either do the formatting in SELECT statements or use a computed column.

EDIT:

If the select used in the insert return several rows then the same value from the variable is used for all of the rows. Because of this the value need to be generated on row basis.

So try modifying the procedure as follows

SQL

ALTER Procedure [dbo].[W_usp_SO_GENERATION]
	@SoNo nvarchar(20),
	@SoDate datetime,
	@STDB nvarchar(5),
	@Products nvarchar(50),
	@issueNo nvarchar(10),
	@User nvarchar(20),
	@terminal nvarchar(50)
 
AS
BEGIN
 
INSERT INTO [dbo].[SOMaster_TEMP] 
   (SoNo, SODate, SVCode, SVName,  MVCode, DistCode,
    RouteCode,Area,Edition, SeqNo,Qty,Rate, STDB, BSTD, BEND, BLOS,
    Products, IssueNo, CreatedBy, CreatedOn, Terminal, DONo,GSTP,Type)
SELECT @sono, @SoDate,  SVCode,  SVName,  MVCode,  DistCode, RouteCode, 
       Area, Edition,  SeqNo,  '0', Rate, @STDB, '0', '0', '1', 
       @Products, @issueNo, @User, @SoDate, @terminal,  
       'DO-' + right('000000'+convert(varchar,(next value for DoNo)),6), 
       '6', type  
FROM [dbo].[vwRDMS]