Id is not incremented after it become 10

Question

3.00/5 (2 votes)

See more:

C#

SqlCommand cmd1 = new SqlCommand("select max(id) from login1",conn);
                      int id1 = Convert.ToInt32(cmd1.ExecuteScalar());
               id1 =id1 + 1;
//Here  id is primary key.but it will not increment after digit 10,it remain as it is

Posted 31-Mar-11 0:26am

aparnaChandras

Updated 31-Mar-11 0:31am

Prerak Patel

v3

Add a Solution

Comments

Mahendra.p25 31-Mar-11 6:29am

Clear your Question what is the error?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prerak Patel · Answer 1 · 2011-03-31T00:37:00

Solution 1

1)id1 is int, which can't limit your count to 10.
2)id column in login1 could possibly be tinyint, which also allows 0 to 255, so no problem.

It makes me think to check if you have any silly constraint on login1.

Posted 31-Mar-11 0:37am

Prerak Patel

Updated 31-Mar-11 0:38am

v2

Dylan Morley · Answer 2 · 2011-03-31T00:44:00

The way you're doing this is wrong and is a habit you should get out of right now

It's the job of the database to allocate primary key identifiers, not your code. Trying to get a MAX of a field, then increment by 1 is not the way you should be doing this.

Instead, your field id in table login1 should be set as an Identity (SQL Server)

This means when you add a record to the table, the database engine will automatically assign an ID to the new record, which you can then retrieve and return to your application code.

Mahendra.p25 · Answer 3 · 2011-03-31T01:04:00

Solution 3

hi,

always try to give id column as identity(1,1) it will automatically insert int value 1 to your primay id column and when you insert other record it will increment it by 1 you can also changed that as required
as it will reduce your chances of error.

SQL

create table test(id int primary key identity(1,1),Name varchar(200))
insert into test values ('Pratik')

Posted 31-Mar-11 1:04am

Mahendra.p25

Comments

Ankur^\m/ 31-Mar-11 7:44am

Did you mention anything different from the above responder?