Filtrate collection of items in sqlserver 2005

Question

0.00/5 (No votes)

See more:

Respected Sir,
i want to filtrate collection of items that stored in string array variable and pass this variable in where clause but that filtrate only last value like here 'Coal'.not filtrate all variable members
my query is like this///////////////

 string[] r = { "TV", "Radio", "Coal" };
foreach (string name in r)
{
  // MessageBox.Show(name);
 SqlConnection con = new SqlConnection(@"Data Source=.\sqlexpress;Initial Catalog=ERPDB;Integrated Security=True");
 SqlDataAdapter adp;
 DataSet ds = new DataSet();
 adp = new SqlDataAdapter("Select * from Prod_Tbl where ProductName='+name+'"), con);
 adp.Fill(ds, "Prod_Tbl");
 dataGridView1.DataSource = ds.Tables[0].DefaultView;
 }

Posted 28-Mar-11 19:25pm

manasBonton

Updated 28-Mar-11 19:32pm

Prerak Patel

v2

Add a Solution

Comments

manasBonton 29-Mar-11 1:46am

I have tried aleardy "Select * from Prod_Tbl where ProductName='" + name + "'"

Venkatesh Mookkan 29-Mar-11 2:28am

Answer has been updated. check it out

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Venkatesh Mookkan · Accepted Answer · 2011-03-28T19:36:00

Solution 1

Correction:

SQL

"Select * from Prod_Tbl where ProductName='" + name + "'"

Update:
I haven't read your answer properly.

You should not load the DataGridView on the loop. Remove it from the loop and place it outside. Change the foreach to below one.

C#

string filter = string.Empty;
foreach (string name in r)
{
  if (filter.Length > 0)
    filter +=",";
  filter += string.Format("'{0}'",name);
}

Now try below:

SQL

"Select * from Prod_Tbl where ProductName IN (" + filter + ")"

Posted 28-Mar-11 19:36pm

Venkatesh Mookkan

Updated 28-Mar-11 20:26pm

v2

Comments

m@dhu 29-Mar-11 2:18am

That still gives the last element of the array to filter.

Venkatesh Mookkan 29-Mar-11 2:27am

I miss understood the question. Answer has been updated.

manasBonton 29-Mar-11 2:44am

Thank you so much...........
it is working now.

m@dhu · Accepted Answer · 2011-03-28T20:17:00

This dirty code will work but this is not the best solution. You got to handle this in db itself.

C#

string[] r = { "TV", "Radio", "Coal" };
for (int i = 0; i < r.Length; i++)
            {
                ir +="ProductName = "+ r[i] + " or ";

            }
SqlConnection con = new SqlConnection(@"Data Source=.\sqlexpress;Initial Catalog=ERPDB;Integrated Security=True");
            SqlDataAdapter adp;
            DataSet ds = new DataSet();
            adp = new SqlDataAdapter("Select * from Prod_Tbl where "+ir+""), con);
            adp.Fill(ds, "Prod_Tbl");
            dataGridView1.DataSource = ds.Tables[0].DefaultView;