How to make the code short?

Question

0.00/5 (No votes)

See more:

how to make the code short?

Private Sub Timer2_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer2.Tick

VB

Dim c As Double = Val(TextBox5.Text)
Dim b As Double = Val(TextBox4.Text)
Dim a As Double = Val(TextBox6.Text)
TextBox6.Text = a + 0.01
If TextBox6.Text = 0.28 Then
    TextBox4.Text = 25
    TextBox5.Text = 1
End If

If TextBox6.Text = 0.56 Then
    TextBox4.Text = 25 + 25
    TextBox5.Text = 2
End If

If TextBox6.Text = 0.84 Then
    TextBox4.Text = 75
    TextBox5.Text = 3
 End If
If TextBox6.Text = .84 + .28 Then
    TextBox4.Text = 75+25
    TextBox5.Text = 3+!
 End If

ETC......

Posted 25-Feb-15 21:32pm

ara salvador

Updated 25-Feb-15 21:37pm

Tomas Takac

v2

Add a Solution

Comments

CPallini 26-Feb-15 4:07am

I see a pattern there...

Richard MacCutchan 26-Feb-15 6:08am

Why are you storing the values from your textboxes, but then trying to use the text strings as numbers?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2015-02-25T22:15:00

Solution 2

The logic is to get the result of division of current TextBox6 value and 0.28:
Pseudo code:

VB

Const dmod As Double = 0.28

a = TextBox6.Text 
a += .1 
If a > .27 Then 'it is necessary to prevent ...
    TextBox4.Text = Int((a / dmod) * 25)
    TextBox5.Text = Int(a / dmod)
End If

Posted 25-Feb-15 22:15pm

Maciej Los

Updated 25-Feb-15 22:20pm

v3

Comments

ara salvador 26-Feb-15 6:49am

i will put this code on timer...
when i start the timer

txtbox6 = .28
then the value in textbox4 and txtbox5 will change

Rahul Rajat Singh · Accepted Answer · 2015-02-25T22:23:00

Solution 3

If the objective is to shorten the code. perhaps this could help. (algorithm only)

VB

// algorithm only, cant seem to remember VB as its been 14 years since i did any VB

dim baseValue as double = 0.28
dim multiplyFactor as int = 0
dim resultBase as int = 25

multiplyFactor = (int)((double)TextBox6.Text/baseValue)

TextBox4.Text = multiplyFactor * resultBase
TextBox5.Text = multiplyFactor <=3 ? multiplyFactor : "3+!"

P.S. No exception handling and proper type conversion being done in the algo.

P.S.S. Where is my prize now :)

Posted 25-Feb-15 22:23pm

Rahul Rajat Singh

Comments

ara salvador 26-Feb-15 6:47am

syntax error ...

"3+!" ??

Rahul Rajat Singh 26-Feb-15 6:48am

It is an algorithm not code. I have made the declaimer above. Your might want to make it syntactically correct before using it.

ara salvador 26-Feb-15 7:00am

i will put this code on timer...
when i start the timer

txtbox6 = .28
then the value in textbox4 and txtbox5 will change

i will use this code on my project like gasoline station

textbox 4 is liters and textbox 5 is equal to amount of liters then thetextbox 6 is timer only