Replacing the namespace System.Threading.Timers namespace

Question

0.00/5 (No votes)

See more:

Dear All,

I am using the code Using System.Timers.Timer namespace as you can see below:

public partial class FilePooling : ServiceBase
    {
        #region Declarations
        private System.ComponentModel.Container components = null;
        private System.ServiceProcess.ServiceController serviceController1;        
        private System.Timers.Timer timer1;
        DataTable dtHub = new DataTable();
        DataTable dtImage = new DataTable();        
        #endregion
        public FilePooling()
        {
            InitializeComponent();
            this.ServiceName = "FilePooling";
        }
        static void Main()
        {
            System.ServiceProcess.ServiceBase[] ServicesToRun;
            ServicesToRun = new System.ServiceProcess.ServiceBase[] { new FilePooling() };
            System.ServiceProcess.ServiceBase.Run(ServicesToRun);
        }
        private void InitializeComponent()
        {
            this.serviceController1 = new System.ServiceProcess.ServiceController();
            this.timer1 = new System.Timers.Timer();
            ((System.ComponentModel.ISupportInitialize)(this.timer1)).BeginInit();
            this.timer1.AutoReset = false;
            this.timer1.Enabled = true;
            this.timer1.Interval = Convert.ToDouble(ConfigurationSettings.AppSettings["TimerInterval"].ToString());
            this.timer1.Elapsed += new System.Timers.ElapsedEventHandler this.timer1_Elapsed);
            ((System.ComponentModel.ISupportInitialize)(this.timer1)).EndInit();
        }

        # region timer1_Elapsed
        private void timer1_Elapsed(object sender, System.Timers.ElapsedEventArgs e)
        {            
            timer1.Enabled = true;                      
            FileFTPCopy();           
            timer1.Enabled = true;            
        }
}

I want to replace the same with Using System.Threading.Timers namespace. I need to remove the System.Timers.Timer. Plz any one suggest me or edit this if psbl.....

Regards,
Raj

Posted 23-Mar-11 3:39am

Raj.rcr

Updated 23-Mar-11 23:49pm

v3

Add a Solution

3 solutions

Solution 1

Why? In the case of Timer objects, they exist in more than one namespace. This almost forces you to use a fully qualified namespace when using Timer objects. My advice is that if the code works, leave it alone.

If you resist that advice, you could alias the namespace so that it takes less typing, but that obfuscates your code to a certain degree.

C#

using ThreadTimer = System.Threading.Timers;

At that point you can change this:

C#

System.Threading.Timers.Timer myTimer = new System.Threading.Timers.Timer();

to this:

C#

ThreadTimer.Timer myTimer = new ThreadTimer.Timer();

Posted 23-Mar-11 3:49am

#realJSOP

Updated 23-Mar-11 3:50am

v2

Comments

Raj.rcr 24-Mar-11 2:11am

I tried the code that u have posted to replace.. Its not working. Plz give me some other idea..

Solution 2

Using any timer, especially in the Windows Service is pretty bad. You will have much less trouble if your create some thread (what you need to time, some polling?) and use System.Threading.Thread.Sleep.

—SA

Posted 23-Mar-11 13:21pm

Sergey Alexandrovich Kryukov

Comments

Raj.rcr 24-Mar-11 1:30am

Actually, here I am working on windows service with Timers namespace as I have posted above. But I think, I am given the task to remove System.Timers namespace and Use Thread instead. I have no idea on this.. how to do?

Sergey Alexandrovich Kryukov 24-Mar-11 2:35am

This is a big topic. Please see my second Answer.
--SA

Raj.rcr 24-Mar-11 1:45am

how to use Thread.Sleep ? If it is required to use in the code that I have posted, then it vl b helpful for me.

Sergey Alexandrovich Kryukov 24-Mar-11 2:34am

Just call it. Naturally, it's a blocking call, so you call it in a separate thread, for example if this thread is supposed to take periodic action. Do some operation and sleep, in cycle.
--SA

Espen Harlinn 24-Mar-11 3:53am

My 5

Sergey Alexandrovich Kryukov 24-Mar-11 3:59am

Thank you, Espen.
--SA

Raj.rcr 24-Mar-11 5:48am

Hi SA, Thankx for the links.. I have gone through, but I am unable to convert from System.Timers to Threading.Timers... I am having an issue in InitializeComponent() method.. Can u plz edit my code?

Sergey Alexandrovich Kryukov 24-Mar-11 12:14pm

I already answered and explained why not.
--SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-03-23T20:33:00

Answering a follow-up Question: if alternative is using threads, how to use it.

There is a lot to know about it.
Please read some of my Answers to similar Question. Sorry, a lot of information irrelevant to Services. To start with, stop even playing with the idea writing a real Windows Service without threading.

The techniques highly depend on the purpose of the Service. For an example, see a skeleton of Service interfacing via TCP with multiple client which can be considered as subscribers:
Multple clients from same port Number[^].

More Answers on threading are collected here: How to get a keydown event to operate on a different thread in vb.net[^].

Very helpful and simple thread wrapper I develop and use, see also discussion:
How to pass ref parameter to the thread[^].

For inter-thread invocation (which is very important, because the predefined mechanism only exists in UI, which is not available in a Service), see my Tips/Tricks article, with code samples: Simple Blocking Queue for Thread Communication and Inter-thread Invocation[^].

The whole topic is too big to overview it all, especially for the novice. Hope this matter will give you a good ideas on what's involved.

—SA