Incorrect syntax near keyword 'order'

Question

0.00/5 (No votes)

See more:

HTML

private void bind()
    {
        if (k == "2013")
        {
            RadioButtonList2.Visible = false;
        }
        else
        {
            RadioButtonList1.Visible = false;
        }
        GridView1.Columns[6].Visible = true;
        DataSet dsDetails = new DataSet();
        SqlConnection con = new SqlConnection(strCon);
        SqlDataAdapter daDetails;
        daDetails = new SqlDataAdapter("select row_number() over (order by id) as Sno,id,title,year,platform,domain,abstract from NewIEEE where year=" + k + " order by year desc,sno", con);
        con.Open();

        daDetails.Fill(dsDetails);
        GridView1.DataSource = dsDetails; Cache["ds"] = dsDetails;
        GridView1.DataBind();
        con.Close();
    }

error will be occur in

HTML

daDetails.Fill(dsDetails);

pls help me

Posted 8-Oct-14 20:07pm

Krishna Veni

Add a Solution

Comments

Maciej Los 9-Oct-14 2:09am

Does k (year) is a text variable?

Krishna Veni 9-Oct-14 2:28am

it is a string

Krishna Veni 9-Oct-14 2:29am

k is string varible

Maciej Los 9-Oct-14 2:36am

Another question: Does year field is numeric or string data type?

[no name] 9-Oct-14 2:23am

can you put your debuge and see what's value inside k

King Fisher 9-Oct-14 2:30am

Getting any Error? what's that?

Sinisa Hajnal 9-Oct-14 2:46am

Validate that k is indeed a number before passing it into the query. Right now you're just checking if it is 2013 string, not that it is empty...

3 solutions

Solution 1

There are at least 2 reasons of above error:
1) bad data type
If year field is numeric data type, the query:
SQL

select row_number() over (order by id) as Sno,id,title,year,platform,domain,abstract from NewIEEE where year='2013' order by year desc,sno

must be replaced with:

SQL

select row_number() over (order by id) as Sno,id,title,year,platform,domain,abstract
from NewIEEE
where year=2013
order by year desc,sno

2) k variable is empty (which is inacceptable):
SQL

select row_number() over (order by id) as Sno,id,title,year,platform,domain,abstract from NewIEEE where year='' order by year desc,sno

Posted 8-Oct-14 20:43pm

Maciej Los

Comments

King Fisher 9-Oct-14 3:12am

its clear my 5+

Maciej Los 9-Oct-14 6:03am

Thank you ;)

King Fisher 9-Oct-14 6:27am

:) how are you ? its Me King_Fisher :) Do you Remember Me :)

Maciej Los 9-Oct-14 6:34am

Thank you, i'm fine. Nice to see you King Fisher vel NELS 140812. And how are you?

King Fisher 9-Oct-14 6:56am

Thank you, i m good .nice to see you after long time ;)

Maciej Los 9-Oct-14 7:21am

Where have you been?

King Fisher 9-Oct-14 7:34am

work load sir.i would like but i counldn't.

Maciej Los 9-Oct-14 7:36am

OK. I wish you all the best.
Cheers,
Maciej

King Fisher 9-Oct-14 7:52am

Thank you :)

Solution 3

your K value Contain null value.

C#

if(K!="")
{
//your Query

}

so that you can avoid passing Null values

Posted 8-Oct-14 21:11pm

King Fisher

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

_Maxxx_ · Accepted Answer · 2014-10-08T20:53:00

As Maciej says, the k variable is probably an empty string, so your SQL reads

SQL

... where year = order by ...

Easy to check this by running in debug and looking.

If I really, really need to build SQL strings (not recommended) then I do it to a string variable first, which i then use - that way it is easy to debug, as you can set a breakpoint & look at the value, or write the string out to the output window & take a look.