Please show me where I making wrong in code

Question

2.00/5 (2 votes)

See more:

JavaScript

<pre lang="Javascript"><pre lang="Javascript">
i have below table

HTML

<table border="1">
<tr>
	<th><input type="checkbox"  id="selectall" onchange="chkall()"/></th>
	<th>1</th>
	<th>2</th>
</tr>
<tr>
	<td align="center"><input type="checkbox"  value="1"/></td>
	<td>1</td>
	<td>2</td>
</tr>
<tr>
	<td align="center"><input type="checkbox"  value="2"/></td>
	<td>1</td>
	<td>2</td>
</tr>
<tr>
	<td align="center"><input type="checkbox"  value="3"/></td>
	<td>1</td>
	<td>2</td>
</tr>
<tr>
	<td align="center"><input type="checkbox" value="4"/></td>
	<td>1</td>
	<td>2</td>
</tr>
<tr>
	<td align="center"><input type="checkbox"  value="5"/></td>
	<td>1</td>
	<td>2</td>
</tr>
</table>

I have below javascript

JavaScript

function chkall() {
	var sall = document.getElementById("selectall");
	var il = document.getElementsByTagName("input");
	if (sall.checked) {
		for (var i = 0;i < il.length; i++) {
			il(i).checked = true;
		}
	}
}

the code suppose to check all check buttons once we check top one. but its not working as inteded, can anybody help me where i making wrong in code.

Posted 4-Apr-14 3:17am

venkatpvc

Add a Solution

Comments

Prasad Khandekar 4-Apr-14 9:35am

It work's for IE, Please have a look at this (http://jsfiddle.net/X6s7Y/). However it fails on browser's other than IE. Change il(i) to il[i]. The document.getElementsByTagName("input") is going to return an array. The updated demo is at (http://jsfiddle.net/X6s7Y/2/)

venkatpvc 4-Apr-14 9:52am

really thank sir for suggestion.
change from () to []

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prasad Khandekar · Answer 1 · 2014-04-04T03:39:00

Solution 2

Hello,

Change your code as shown below.

JavaScript

function chkall() {
	var sall = document.getElementById("selectall");
	var il = document.getElementsByTagName("input");
    alert(sall.checked);
	if (sall.checked) {
		for (var i = 1;i < il.length; i++) {
			il[i].checked = true;
        }
    }
}

Regards,

Posted 4-Apr-14 3:39am

Prasad Khandekar

Comments

venkatpvc 4-Apr-14 9:53am

its working thank you,

Prasad Khandekar 8-Apr-14 6:39am

Please mark the answer as accepted to close the topic.

Ramug10 · Answer 2 · 2014-04-04T03:26:00

Try this

XML

<table border="1">
<tr>
    <th><input type="checkbox"  id="selectall" onchange="chkall()"/></th>
    <th>Select</th>
    <th>All</th>
</tr>
<tr>
    <td align="center"><input type="checkbox" id="1"  value="1"/></td>
    <td>1</td>
    <td>2</td>
</tr>
<tr>
    <td align="center"><input type="checkbox" id="2"  value="2"/></td>
    <td>1</td>
    <td>2</td>
</tr>
<tr>
    <td align="center"><input type="checkbox" id="3"  value="3"/></td>
    <td>1</td>
    <td>2</td>
</tr>
<tr>
    <td align="center"><input type="checkbox" id="4" value="4"/></td>
    <td>1</td>
    <td>2</td>
</tr>
<tr>
    <td align="center"><input type="checkbox" id="5"  value="5"/></td>
    <td>1</td>
    <td>2</td>
</tr>
</table>

C#

function chkall() {
       var sall = document.getElementById("selectall");
       var il = document.getElementsByTagName("input");
       if (sall.checked) {
           for (var i = 0; i < il.length; i++) {
               il(i).checked = true;
           }
       }
       else
       {
           for (var i = 0; i < il.length; i++) {
               il(i).checked = false;
           }
       }
   }

Thanks,
--RG