Javascript: While loop looping forever

Question

1.00/5 (1 vote)

See more:

This while loop loop loops forever on typing "yes" of "no". Please help!

HTML

<script type="text/javascript">

var y = prompt("Do you want to enter values, type 'Yes' or 'No'!");

while ((y.toUpperCase()!="YES") || (y.toUpperCase()!="NO"))
{
	if (y.toUpperCase()=="YES")
	{
 	alert(y);
	}
	else if (y.toUpperCase()=="NO")
	{
 	alert(y);
	}
	else
	{
	alert("You have type \"" +y+ "\" which is no option! Please type again");
        y = prompt("Do you want to enter values, type 'Yes' or 'No'!");
	}

}
</script>

Posted 15-Mar-14 8:52am

Madhukar Krishna

Updated 15-Mar-14 8:56am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 15-Mar-14 21:48pm

Use the debugger; and you will clearly see what's going on. But more importantly, just think. This is all you would need.
—SA

3 solutions

Solution 2

Try this

JavaScript

var y = prompt("Do you want to enter values, type 'Yes' or 'No'!");

while (y.toUpperCase()!="NO")
{
    if (y.toUpperCase()=="YES")
    {
    	alert(y);
        break;
    }
    else
    {
        alert("You have typed \"" +y+ "\" which is not an option! Please type again");
        y = prompt("Do you want to enter values, type 'Yes' or 'No'!");
    }
}

Posted 15-Mar-14 22:36pm

Richard MacCutchan

Comments

Sergey Alexandrovich Kryukov 16-Mar-14 12:10pm

5ed, but frankly, this solution is not the best, but for the Q&A format...
Much better would be to repeat "think again" until OP get enlightened. This is one of the cases when nothing helps until the student does it all independently.
—SA

Richard MacCutchan 16-Mar-14 12:36pm

I'm well aware of that, but it may help OP to think about why their code is stuck in a loop.

Sergey Alexandrovich Kryukov 16-Mar-14 12:59pm

I was sure you were, this is just a general note for all readers.
Thank you.
—SA

Solution 3

Thanks for the response . I fully understand your answers.Let's iterate:
I type "yes".
Then the while loop starts
it checks (y != "yes") result == false

then it checks (y !="no) result == true

Then it goes on iterating in the while loop.

Thanks guys!!

Posted 16-Mar-14 7:29am

Madhukar Krishna

Comments

CHill60 16-Mar-14 13:35pm

If you have something to add to your question use the Improve Question link - try to avoid posting your own comments as Solutions. If you do this before anyone else posts a solution, then your question will drop out of the list and fewer people will see it. Alternatively, use the Reply link next to a posted solution.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2014-03-15T08:59:00

Solution 1

That is because you have checked both YES and NO (using OR operator) in your while condition and allowed everything and again prompting.

You should probably change OR to AND and try.

Posted 15-Mar-14 8:59am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Updated 15-Mar-14 18:39pm

v3

Comments

Maciej Los 15-Mar-14 16:48pm

Sounds reasonable, but what you suggest to do?
BTW: +5!

Sergey Alexandrovich Kryukov 15-Mar-14 21:50pm

Are you trying to hint about applying for McDonalds's job? :-)
—SA

Maciej Los 16-Mar-14 5:30am

No, it was rhetorical question ;)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 15-Mar-14 22:57pm

Thanks a lot Maciej. :)

Let's wait for OP's reply. :P

Maciej Los 16-Mar-14 5:31am

Agree!

Sergey Alexandrovich Kryukov 15-Mar-14 21:51pm

5ed, no "buts". You don't have to suggests anything because OP did not bother to tell us what did he try to achieve.
—SA

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 15-Mar-14 22:57pm

Thanks a lot Sergey. :)

Madhukar Krishna 16-Mar-14 0:28am

That doesn't answer my question! Somebody suggested to use "break" but that isn't a solution.Please help.Somebody suggest why this simple code is not working.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 16-Mar-14 0:30am

Okay. Tell me what exactly you want to achieve.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 16-Mar-14 0:40am

Answer updated. Take a look.

Sergey Alexandrovich Kryukov 16-Mar-14 12:03pm

It does answer your question. You simply have to think.
—SA

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 16-Mar-14 12:46pm

:)